Re: [ovs-dev] [PATCH v4] classifier: Prevent tries vs n_tries race leading to NULL dereference.

2020-05-28 Thread Ilya Maximets
On 5/28/20 1:22 AM, Eiichi Tsukata wrote: > Hello Ilya > >> On May 28, 2020, at 7:28, Ilya Maximets wrote: >> >> On 5/27/20 4:13 AM, Eiichi Tsukata wrote: >>> Currently classifier tries and n_tries can be updated not atomically, >>> there is a race condition which can lead to NULL dereference. >>

Re: [ovs-dev] [PATCH v4] classifier: Prevent tries vs n_tries race leading to NULL dereference.

2020-05-27 Thread Eiichi Tsukata
Hello Ilya > On May 28, 2020, at 7:28, Ilya Maximets wrote: > > On 5/27/20 4:13 AM, Eiichi Tsukata wrote: >> Currently classifier tries and n_tries can be updated not atomically, >> there is a race condition which can lead to NULL dereference. >> The race can happen when main thread updates a cl

Re: [ovs-dev] [PATCH v4] classifier: Prevent tries vs n_tries race leading to NULL dereference.

2020-05-27 Thread Ilya Maximets
On 5/27/20 4:13 AM, Eiichi Tsukata wrote: > Currently classifier tries and n_tries can be updated not atomically, > there is a race condition which can lead to NULL dereference. > The race can happen when main thread updates a classifier tries and > n_tries in classifier_set_prefix_fields() and at

[ovs-dev] [PATCH v4] classifier: Prevent tries vs n_tries race leading to NULL dereference.

2020-05-26 Thread Eiichi Tsukata
Currently classifier tries and n_tries can be updated not atomically, there is a race condition which can lead to NULL dereference. The race can happen when main thread updates a classifier tries and n_tries in classifier_set_prefix_fields() and at the same time revalidator or handler thread try to