On Thu, Jan 12, 2017 at 01:31:43PM -0800, Justin Pettit wrote:
>
> > On Jan 12, 2017, at 9:23 AM, Ben Pfaff wrote:
> >
> > On Mon, Jan 09, 2017 at 08:46:28PM -0800, Justin Pettit wrote:
> >> I think it would be helpful to have a comment describing this
> >> function. Also mentioning that the ca
> On Jan 12, 2017, at 9:23 AM, Ben Pfaff wrote:
>
> On Mon, Jan 09, 2017 at 08:46:28PM -0800, Justin Pettit wrote:
>> I think it would be helpful to have a comment describing this
>> function. Also mentioning that the caller maintains ownership of
>> 'text'.
>
> There was a lot of missing comm
On Mon, Jan 09, 2017 at 08:46:28PM -0800, Justin Pettit wrote:
> I think it would be helpful to have a comment describing this
> function. Also mentioning that the caller maintains ownership of
> 'text'.
There was a lot of missing comments and documentation. I added a bunch.
> I may be missing
> On Jan 5, 2017, at 5:04 PM, Ben Pfaff wrote:
>
> diff --git a/ofproto/ofproto-dpif-trace.c b/ofproto/ofproto-dpif-trace.c
> index 52c1758..017fbb1 100644
> --- a/ofproto/ofproto-dpif-trace.c
> +++ b/ofproto/ofproto-dpif-trace.c
> @@ -23,165 +23,82 @@
> ...
> +struct oftrace_node *
> +oftrace_r
"ovs-appctl ofproto/trace" is invaluable for debugging, but as the users of
Open vSwitch have evolved it has failed to keep up with the times. It's
pretty easy to design OpenFlow tables and pipelines that resubmit dozens of
times. Each resubmit causes an additional tab of indentation, so the
outp
