[ovs-dev] [PATCH v4 04/15] list: use multi-variable helpers for list loops

2022-03-09 Thread Adrian Moreno
Use multi-variable iteration helpers to rewrite non-safe loops. There is an important behavior change compared with the previous implementation: When the loop ends normally (i.e: not via "break;"), the object pointer provided by the user is NULL. This is safer because it's not guaranteed that it w

Re: [ovs-dev] [PATCH v4 04/15] list: use multi-variable helpers for list loops

2022-03-09 Thread 0-day Robot
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Use ovs_assert() in place of assert() #134 FILE: tests/test-list.c:64: assert(e ==

Re: [ovs-dev] [PATCH v4 04/15] list: use multi-variable helpers for list loops

2022-03-18 Thread Eelco Chaudron
On 9 Mar 2022, at 17:10, Adrian Moreno wrote: > Use multi-variable iteration helpers to rewrite non-safe loops. > > There is an important behavior change compared with the previous > implementation: When the loop ends normally (i.e: not via "break;"), the > object pointer provided by the user i

Re: [ovs-dev] [PATCH v4 04/15] list: use multi-variable helpers for list loops

2022-03-23 Thread Adrian Moreno
On 3/18/22 14:32, Eelco Chaudron wrote: On 9 Mar 2022, at 17:10, Adrian Moreno wrote: Use multi-variable iteration helpers to rewrite non-safe loops. There is an important behavior change compared with the previous implementation: When the loop ends normally (i.e: not via "break;"), the ob