Re: [ovs-dev] [PATCH v4 05/15] list: use short version of safe loops if possible

2022-03-23 Thread Eelco Chaudron
On 23 Mar 2022, at 8:28, Adrian Moreno wrote: > On 3/18/22 14:38, Eelco Chaudron wrote: >> >> >> On 9 Mar 2022, at 17:10, Adrian Moreno wrote: >> >>> Using the SHORT version of the *_SAFE loops makes the code cleaner >>> and less error-prone. So, use the SHORT version and remove the extra >>>

Re: [ovs-dev] [PATCH v4 05/15] list: use short version of safe loops if possible

2022-03-23 Thread Adrian Moreno
On 3/18/22 14:38, Eelco Chaudron wrote: On 9 Mar 2022, at 17:10, Adrian Moreno wrote: Using the SHORT version of the *_SAFE loops makes the code cleaner and less error-prone. So, use the SHORT version and remove the extra variable when possible. In order to be able to use both long and

Re: [ovs-dev] [PATCH v4 05/15] list: use short version of safe loops if possible

2022-03-21 Thread Eelco Chaudron
On 18 Mar 2022, at 14:38, Eelco Chaudron wrote: > On 9 Mar 2022, at 17:10, Adrian Moreno wrote: > >> Using the SHORT version of the *_SAFE loops makes the code cleaner >> and less error-prone. So, use the SHORT version and remove the extra >> variable when possible. >> >> In order to be able to

Re: [ovs-dev] [PATCH v4 05/15] list: use short version of safe loops if possible

2022-03-18 Thread Eelco Chaudron
On 9 Mar 2022, at 17:10, Adrian Moreno wrote: > Using the SHORT version of the *_SAFE loops makes the code cleaner > and less error-prone. So, use the SHORT version and remove the extra > variable when possible. > > In order to be able to use both long and short versions without changing > the

Re: [ovs-dev] [PATCH v4 05/15] list: use short version of safe loops if possible

2022-03-09 Thread 0-day Robot
Bleep bloop. Greetings Adrian Moreno, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Use ovs_assert() in place of assert() #1179 FILE: tests/test-list.c:175:

[ovs-dev] [PATCH v4 05/15] list: use short version of safe loops if possible

2022-03-09 Thread Adrian Moreno
Using the SHORT version of the *_SAFE loops makes the code cleaner and less error-prone. So, use the SHORT version and remove the extra variable when possible. In order to be able to use both long and short versions without changing the name of the macro for all the clients, overload the existing