Re: [ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

2017-12-19 Thread Jan Scheurich
> > > Should this have some additional cover for the ENOSPC case? Meaning, > > we > > > will now increment a failure condition, but I'm not sure it should be > > > considered an 'upcall' failure? After all, we'll still perform the > > actions. > > > > Good question. I inherited

Re: [ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

2017-12-19 Thread Aaron Conole
> Sent: Monday, 18 December, 2017 19:41 > > To: Jan Scheurich > > Cc: d...@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD > performance into dpif-netdev-perf > > > > Hi Jan, > > >

Re: [ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

2017-12-18 Thread Darrell Ball
Scheurich > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf > > Hi Jan, > > Jan Scheurich writes: > > > Add module dpif-netdev-perf to host all PMD performance

Re: [ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

2017-12-18 Thread Jan Scheurich
Hi Aaron, Thanks for the review. Answers in-line. Regards, Jan > -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Monday, 18 December, 2017 19:41 > To: Jan Scheurich > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4 1/3] dpif-ne

Re: [ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

2017-12-18 Thread Aaron Conole
Hi Jan, Jan Scheurich writes: > Add module dpif-netdev-perf to host all PMD performance-related > data structures and functions in dpif-netdev. Refactor the PMD > stats handling in dpif-netdev and delegate whatever possible into > the new module, using clean interfaces to shield dpif-netdev from

[ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

2017-12-18 Thread Jan Scheurich
Add module dpif-netdev-perf to host all PMD performance-related data structures and functions in dpif-netdev. Refactor the PMD stats handling in dpif-netdev and delegate whatever possible into the new module, using clean interfaces to shield dpif-netdev from the implementation details. Accordingly,