Hi Numan,
Sure, yes thats a valid concern.
I will try to address this in V5.
Regards,
Ankur
From: Numan Siddique
Sent: Friday, August 7, 2020 2:37 AM
To: svc.mail.git
Cc: ovs-dev
Subject: Re: [ovs-dev] [PATCH v4 2/2 ovn] External IP based NAT: NORTHD changes
> -Original Message-
> From: dev On Behalf Of Numan Siddique
> Sent: Friday, August 7, 2020 2:38 AM
> To: Ankur Sharma
> Cc: ovs-dev
> Subject: Re: [ovs-dev] [PATCH v4 2/2 ovn] External IP based NAT: NORTHD
> changes to use applied/exempted external ip
>
&g
On Wed, Aug 5, 2020 at 1:56 AM Ankur Sharma wrote:
>
> From: Ankur Sharma
>
> This patch has northd changes which consumes applied/exempted external ip
> configuration per NAT rule in logical flow.
>
> Applied/Exempted external ip range adds an additional match criteria in
>
Bleep bloop. Greetings svc.mail.git, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Empty return followed by brace, consider omitting
#50 FILE: northd/ovn-northd.c:8268:
From: Ankur Sharma
This patch has northd changes which consumes applied/exempted external ip
configuration per NAT rule in logical flow.
Applied/Exempted external ip range adds an additional match criteria in
snat/dnat/unsnat/undant logical flow rules.
For example, if an allowed_external_ip
