Re: [ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

2021-02-25 Thread Toshiaki Makita
On 2021/02/24 4:03, William Tu wrote: + +return 0; +} +#endif + static int xsk_load_prog(struct netdev *netdev, const char *path, struct bpf_object **pobj, int *prog_fd) { +struct netdev_linux *dev OVS_UNUSED = netdev_linux_cast(netdev); struct bpf_object_

Re: [ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

2021-02-23 Thread William Tu
> >>> + > >>> +return 0; > >>> +} > >>> +#endif > >>> + > >>> static int > >>> xsk_load_prog(struct netdev *netdev, const char *path, > >>> struct bpf_object **pobj, int *prog_fd) > >>> { > >>> +struct netdev_linux *dev OVS_UNUSED = netdev_linux_cast(netdev); > >>>

Re: [ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

2021-02-09 Thread Toshiaki Makita
On 2021/02/05 12:03, William Tu wrote: On Thu, Feb 4, 2021 at 5:15 PM William Tu wrote: Hi Toshiaki, Thanks for the patch. I have some questions inline. On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita wrote: This provider offloads classifier to software XDP. It works only when a custom X

Re: [ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

2021-02-04 Thread William Tu
On Thu, Feb 4, 2021 at 5:15 PM William Tu wrote: > > Hi Toshiaki, > > Thanks for the patch. I have some questions inline. > > On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita > wrote: > > > > This provider offloads classifier to software XDP. > > > > It works only when a custom XDP object is loade

Re: [ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

2021-02-04 Thread William Tu
Hi Toshiaki, Thanks for the patch. I have some questions inline. On Thu, Jul 30, 2020 at 7:55 PM Toshiaki Makita wrote: > > This provider offloads classifier to software XDP. > > It works only when a custom XDP object is loaded by afxdp netdev. > The BPF program needs to implement classifier wit

[ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

2020-07-30 Thread Toshiaki Makita
This provider offloads classifier to software XDP. It works only when a custom XDP object is loaded by afxdp netdev. The BPF program needs to implement classifier with array-of-maps for subtable hashmaps and arraymap for subtable masks. The flow api provider detects classifier support in the custo