On 7/7/23 14:22, David Marchand wrote:
> On Fri, Jul 7, 2023 at 1:50 PM Ilya Maximets wrote:
>>> @@ -4268,7 +4295,9 @@ new_device(int vid)
>>> dev->hw_ol_features |= NETDEV_TX_SCTP_CKSUM_OFFLOAD;
>>> }
>>>
>>> -if (userspace_tso_enabled()) {
>>
On Fri, Jul 7, 2023 at 1:50 PM Ilya Maximets wrote:
> > @@ -4268,7 +4295,9 @@ new_device(int vid)
> > dev->hw_ol_features |= NETDEV_TX_SCTP_CKSUM_OFFLOAD;
> > }
> >
> > -if (userspace_tso_enabled()) {
> > +if (userspace_tso_enab
On 7/6/23 21:42, David Marchand wrote:
> At some point in OVS history, some virtio features were announced as
> supported (ECN and UFO virtio features).
>
> The userspace TSO code, which has been added later, does not support
> those features and tries to disable them.
>
> This breaks OVS upgrade
At some point in OVS history, some virtio features were announced as
supported (ECN and UFO virtio features).
The userspace TSO code, which has been added later, does not support
those features and tries to disable them.
This breaks OVS upgrades: if an existing VM already negotiated such
features