Re: [ovs-dev] [PATCH v5 00/15] Fix undefined behavior in loop macros

2022-03-31 Thread Adrian Moreno
On 3/30/22 22:35, Ilya Maximets wrote: On 3/23/22 12:56, Adrian Moreno wrote: When running builds with UBSan, some undefined behavior was detected in the iteration of common data data structures in OVS. Coincidentally, a bug was reported [1] whose root cause whas another, this time undetecte

Re: [ovs-dev] [PATCH v5 00/15] Fix undefined behavior in loop macros

2022-03-30 Thread Ilya Maximets
On 3/23/22 12:56, Adrian Moreno wrote: > When running builds with UBSan, some undefined behavior was detected in the > iteration of common data data structures in OVS. > Coincidentally, a bug was reported [1] whose root cause whas another, this > time undetected, undefined behavior in the iterati

Re: [ovs-dev] [PATCH v5 00/15] Fix undefined behavior in loop macros

2022-03-25 Thread Adrian Moreno
On 3/24/22 10:25, Dumitru Ceara wrote: On 3/23/22 17:24, Ilya Maximets wrote: On 3/23/22 17:11, Adrian Moreno wrote: On 3/23/22 14:25, Eelco Chaudron wrote: One small nit in patch 4, the rest of the changes from v4 to v5 look good. Sorry about that. Dumitru said he might take a look at

Re: [ovs-dev] [PATCH v5 00/15] Fix undefined behavior in loop macros

2022-03-24 Thread Dumitru Ceara
On 3/23/22 17:24, Ilya Maximets wrote: > On 3/23/22 17:11, Adrian Moreno wrote: >> >> >> On 3/23/22 14:25, Eelco Chaudron wrote: >>> One small nit in patch 4, the rest of the changes from v4 to v5 look good. >>> >> >> Sorry about that. Dumitru said he might take a look at the latest version. >> I'

Re: [ovs-dev] [PATCH v5 00/15] Fix undefined behavior in loop macros

2022-03-23 Thread Ilya Maximets
On 3/23/22 17:11, Adrian Moreno wrote: > > > On 3/23/22 14:25, Eelco Chaudron wrote: >> One small nit in patch 4, the rest of the changes from v4 to v5 look good. >> > > Sorry about that. Dumitru said he might take a look at the latest version. > I'll give him some time and resend. If there wi

Re: [ovs-dev] [PATCH v5 00/15] Fix undefined behavior in loop macros

2022-03-23 Thread Adrian Moreno
On 3/23/22 14:25, Eelco Chaudron wrote: One small nit in patch 4, the rest of the changes from v4 to v5 look good. Sorry about that. Dumitru said he might take a look at the latest version. I'll give him some time and resend. //Eelco On 23 Mar 2022, at 12:56, Adrian Moreno wrote: When

Re: [ovs-dev] [PATCH v5 00/15] Fix undefined behavior in loop macros

2022-03-23 Thread Eelco Chaudron
One small nit in patch 4, the rest of the changes from v4 to v5 look good. //Eelco On 23 Mar 2022, at 12:56, Adrian Moreno wrote: > When running builds with UBSan, some undefined behavior was detected in the > iteration of common data data structures in OVS. > Coincidentally, a bug was reported

[ovs-dev] [PATCH v5 00/15] Fix undefined behavior in loop macros

2022-03-23 Thread Adrian Moreno
When running builds with UBSan, some undefined behavior was detected in the iteration of common data data structures in OVS. Coincidentally, a bug was reported [1] whose root cause whas another, this time undetected, undefined behavior in the iteration macros. >From both cases, we conclude that