Re: [ovs-dev] [PATCH v5 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-09-07 Thread Ankur Sharma
] [PATCH v5 1/2 ovn] External IP based NAT: Add Columns and CLI Hi Ankur, Sorry for the late review. This patch LGTM except for one comment. I have few comments in patch 2. Thanks Numan On Thu, Aug 20, 2020 at 8:05 AM Ankur Sharma wrote: > From: Ankur Sharma > > This patch adds

Re: [ovs-dev] [PATCH v5 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-09-01 Thread Numan Siddique
Hi Ankur, Sorry for the late review. This patch LGTM except for one comment. I have few comments in patch 2. Thanks Numan On Thu, Aug 20, 2020 at 8:05 AM Ankur Sharma wrote: > From: Ankur Sharma > > This patch adds following columns to NAT table. > > a. allowed_ext_ips: >Represents Addre

Re: [ovs-dev] [PATCH v5 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-08-19 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #199 FILE: utilities/ovn-nbctl.c:861: N

[ovs-dev] [PATCH v5 1/2 ovn] External IP based NAT: Add Columns and CLI

2020-08-19 Thread Ankur Sharma
From: Ankur Sharma This patch adds following columns to NAT table. a. allowed_ext_ips: Represents Address Set of External IPs for which a NAT rule is applicable. b. exempted_ext_ips: Represents Address Set of External IPs for which a NAT rule is NOT applicable. Additionally, patch