Re: [ovs-dev] [PATCH v6] conntrack: Properly unNAT inner header of related traffic

2023-02-09 Thread Ales Musil
On Thu, Feb 9, 2023 at 1:17 PM Paolo Valerio wrote: > Hi Ales, > > I just have two small nits, but other than that the patch LGTM. > Hi Paolo, I've addressed both comments and added your ack to the patch. Thanks, Ales > > Acked-by: Paolo Valerio > > Ales Musil writes: > > > The inner header

Re: [ovs-dev] [PATCH v6] conntrack: Properly unNAT inner header of related traffic

2023-02-09 Thread Paolo Valerio
Hi Ales, I just have two small nits, but other than that the patch LGTM. Acked-by: Paolo Valerio Ales Musil writes: > The inner header was not handled properly. > Simplify the code which allows proper handling > of the inner headers. > > Reported-at: https://bugzilla.redhat.com/2137754 > Sign

Re: [ovs-dev] [PATCH v6] conntrack: Properly unNAT inner header of related traffic

2023-02-08 Thread Simon Horman
On Wed, Feb 08, 2023 at 07:29:27AM +0100, Ales Musil wrote: > On Tue, Feb 7, 2023 at 11:54 AM Simon Horman > wrote: > > > On Mon, Feb 06, 2023 at 12:46:10PM +0100, Ales Musil wrote: > > > The inner header was not handled properly. > > > Simplify the code which allows proper handling > > > of the

Re: [ovs-dev] [PATCH v6] conntrack: Properly unNAT inner header of related traffic

2023-02-07 Thread Ales Musil
On Tue, Feb 7, 2023 at 11:54 AM Simon Horman wrote: > On Mon, Feb 06, 2023 at 12:46:10PM +0100, Ales Musil wrote: > > The inner header was not handled properly. > > Simplify the code which allows proper handling > > of the inner headers. > > > > Reported-at: https://bugzilla.redhat.com/2137754 >

Re: [ovs-dev] [PATCH v6] conntrack: Properly unNAT inner header of related traffic

2023-02-07 Thread Simon Horman
On Mon, Feb 06, 2023 at 12:46:10PM +0100, Ales Musil wrote: > The inner header was not handled properly. > Simplify the code which allows proper handling > of the inner headers. > > Reported-at: https://bugzilla.redhat.com/2137754 > Signed-off-by: Ales Musil Nice clean-up too :) Reviewed-by: Si

[ovs-dev] [PATCH v6] conntrack: Properly unNAT inner header of related traffic

2023-02-06 Thread Ales Musil
The inner header was not handled properly. Simplify the code which allows proper handling of the inner headers. Reported-at: https://bugzilla.redhat.com/2137754 Signed-off-by: Ales Musil --- v6: Rebase on top of current master. Address comments from Paolo: - Add test case for ICMP related