Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

2018-01-06 Thread Ben Pfaff
On Sat, Jan 06, 2018 at 01:56:20PM +0800, Yang, Yi wrote: > On Fri, Jan 05, 2018 at 04:42:00AM +0800, Ben Pfaff wrote: > > On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > > > Signed-off-by: Yi Yang > > > > This fails to build with Clang (and, I would guess, MSVC):

Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

2018-01-06 Thread Ben Pfaff
On Sat, Jan 06, 2018 at 02:03:09PM +0800, Yang, Yi wrote: > On Fri, Jan 05, 2018 at 04:42:00AM +0800, Ben Pfaff wrote: > > On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > > > > > > Signed-off-by: Yi Yang > > > > > > In odp_execute_actions(), this looks bogus:

Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

2018-01-05 Thread Yang, Yi
On Fri, Jan 05, 2018 at 04:42:00AM +0800, Ben Pfaff wrote: > On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > > > > Signed-off-by: Yi Yang > > > In odp_execute_actions(), this looks bogus: there is nothing to > guarantee that 'buffer' is properly aligned for

Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

2018-01-05 Thread Yang, Yi
On Fri, Jan 05, 2018 at 04:42:00AM +0800, Ben Pfaff wrote: > On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > > Signed-off-by: Yi Yang > > This fails to build with Clang (and, I would guess, MSVC): > ../lib/odp-execute.c:497:21: error: fields must have a

Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

2018-01-04 Thread Ben Pfaff
On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > This patch changes OVS_KEY_ATTR_NSH > to nested attribute and adds three new NSH sub attribute keys: > > OVS_NSH_KEY_ATTR_BASE: for length-fixed NSH base header > OVS_NSH_KEY_ATTR_MD1: for length-fixed MD type 1 context >

[ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

2017-12-08 Thread Yi Yang
This patch changes OVS_KEY_ATTR_NSH to nested attribute and adds three new NSH sub attribute keys: OVS_NSH_KEY_ATTR_BASE: for length-fixed NSH base header OVS_NSH_KEY_ATTR_MD1: for length-fixed MD type 1 context OVS_NSH_KEY_ATTR_MD2: for length-variable MD type 2 metadata Its