Re: [ovs-dev] [PATCH v6 2/5] userspace: L3 tunnel support for GRE and LISP

2017-05-26 Thread Stephen Finucane
On Thu, 2017-05-25 at 09:22 -0700, Ben Pfaff wrote: > On Mon, May 22, 2017 at 01:43:25PM +, Jan Scheurich wrote: > > > I think that parse_gre_header() should perhaps be pickier about > > > the > > > Ethertypes it accepts, since values below 0x600 are not valid > > > Ethertypes and sometimes

Re: [ovs-dev] [PATCH v6 2/5] userspace: L3 tunnel support for GRE and LISP

2017-05-25 Thread Ben Pfaff
On Mon, May 22, 2017 at 01:43:25PM +, Jan Scheurich wrote: > > I think that parse_gre_header() should perhaps be pickier about the > > Ethertypes it accepts, since values below 0x600 are not valid > > Ethertypes and sometimes they are used for special purposes, for example > > OpenFlow uses

Re: [ovs-dev] [PATCH v6 2/5] userspace: L3 tunnel support for GRE and LISP

2017-05-22 Thread Jan Scheurich
> I think that parse_gre_header() should perhaps be pickier about the > Ethertypes it accepts, since values below 0x600 are not valid > Ethertypes and sometimes they are used for special purposes, for example > OpenFlow uses 0x5ff to mean that the frame lacks an Ethertype. I agree. OVS could just

Re: [ovs-dev] [PATCH v6 2/5] userspace: L3 tunnel support for GRE and LISP

2017-05-18 Thread Ben Pfaff
On Fri, May 12, 2017 at 11:07:40AM +, Zoltán Balogh wrote: > From: Jan Scheurich > > Add a boolean "layer3" configuration option for tunnel vports. > The layer3 option defaults to false for all ports except LISP. > GRE ports accept both true and false for

[ovs-dev] [PATCH v6 2/5] userspace: L3 tunnel support for GRE and LISP

2017-05-12 Thread Zoltán Balogh
From: Jan Scheurich Add a boolean "layer3" configuration option for tunnel vports. The layer3 option defaults to false for all ports except LISP. GRE ports accept both true and false for "layer3". A tunnel vport configured with layer3=true receives L3 packets. which