Just one small nit on this one
> datapath-windows/ovsext/Conntrack-icmp.c \
> datapath-windows/ovsext/Conntrack-other.c \
> datapath-windows/ovsext/Conntrack-related.c \
> +datapath-windows/ovsext/Conntrack-nat.c \
[Alin Serdean] tab instead of 4 space
> datapath-windows
> -Original Message-
> From: Sairam Venugopal [mailto:vsai...@vmware.com]
> Sent: Wednesday, May 17, 2017 9:05 PM
> To: Yin Lin ; d...@openvswitch.org
> Cc: Alin Serdean
> Subject: Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module
> in conntrack
>
&
inline comments.
>
>-Original Message-
>From: Sairam Venugopal
>Sent: Tuesday, May 16, 2017 4:50 PM
>To: Yin Lin ; d...@openvswitch.org
>Subject: Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module in
>conntrack
>
>Hi Yin,
>
>Thanks for the patch. P
Thanks Sai for the review! I fixed most of them and explained the remaining
ones in the inline comments.
-Original Message-
From: Sairam Venugopal
Sent: Tuesday, May 16, 2017 4:50 PM
To: Yin Lin ; d...@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT
Hi Yin,
Thanks for the patch. Please find my comments inline.
Thanks,
Sairam
On 5/9/17, 3:59 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yin Lin"
wrote:
>Signed-off-by: Yin Lin
>---
> datapath-windows/automake.mk| 2 +
> datapath-windows/ovsext/Conntrack-nat.c | 424 +++
Signed-off-by: Yin Lin
---
datapath-windows/automake.mk| 2 +
datapath-windows/ovsext/Conntrack-nat.c | 424
datapath-windows/ovsext/Conntrack-nat.h | 39 +++
3 files changed, 465 insertions(+)
create mode 100644 datapath-windows/ovsext/Conntrack-n
