Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

On Fri, Sep 28, 2018 at 12:36 AM Guru Shetty wrote: > > > On Mon, 24 Sep 2018 at 03:10, Miguel Angel Ajo Pelayo > wrote: > >> >> >> No worries Guru, I understand your feeling, I worked with Anil on >> developing this feature, and it's indeed rather complex (we are actually >> replacing

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

On Mon, 24 Sep 2018 at 03:10, Miguel Angel Ajo Pelayo wrote: > > > No worries Guru, I understand your feeling, I worked with Anil on > developing this feature, and it's indeed rather complex (we are actually > replacing keepalived + VRRP with openflow and BFD). > > I'm happy to work on a more

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

No worries Guru, I understand your feeling, I worked with Anil on developing this feature, and it's indeed rather complex (we are actually replacing keepalived + VRRP with openflow and BFD). I'm happy to work on a more detailed documentation, I guess that Numan, Anil and I could team up to help

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

On Fri, Sep 21, 2018 at 11:06 PM Guru Shetty wrote: > > > > > > I have tried to make sense of this patch series a few times. I think > > adding increasing complications like this will make gateway code > > unmaintainable. The whole gateway redirect chassis already makes it > > un-understandable

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

> > > I have tried to make sense of this patch series a few times. I think > adding increasing complications like this will make gateway code > unmaintainable. The whole gateway redirect chassis already makes it > un-understandable and now this will mean that no one will be able to > understand it

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

On Wed, 1 Aug 2018 at 05:18, wrote: > From: venkata anil > > Previous patches in the series doesn't address issue 1 explained in [1] > i.e > 1) removal of router gateway port MAC address on external switches >after expiring of aging time. > 2) then external switches unable to learn the

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

Yes, sorry. I'll take a look early next week. --Justin > On Sep 21, 2018, at 5:47 AM, Anil Venkata wrote: > > Gentle ping :) Thanks > > On Thu, Aug 16, 2018 at 2:05 PM Anil Venkata wrote: > Thanks Ben > > On Wed, Aug 15, 2018 at 6:40 AM, Ben Pfaff wrote: > I've asked Justin to take a

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

Thanks Ben On Wed, Aug 15, 2018 at 6:40 AM, Ben Pfaff wrote: > I've asked Justin to take a look at this series. > > On Tue, Aug 14, 2018 at 08:48:25PM +0530, Anil Venkata wrote: > > Gentle reminder requesting more reviews.. > > > > Mark has reviewed the patch series and Miguel has already

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

I've asked Justin to take a look at this series. On Tue, Aug 14, 2018 at 08:48:25PM +0530, Anil Venkata wrote: > Gentle reminder requesting more reviews.. > > Mark has reviewed the patch series and Miguel has already tested the patch > series. > > Thanks > Anil > > On Tue, Aug 14, 2018 at 7:45

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

Gentle reminder requesting more reviews.. Mark has reviewed the patch series and Miguel has already tested the patch series. Thanks Anil On Tue, Aug 14, 2018 at 7:45 PM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > Thank you very much, > > I wasn't able to perform a proper code

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

Thank you very much, I wasn't able to perform a proper code review, but you can add the Tested-By: Miguel Angel Ajo The issue I described previously seems to be fixed on the v7 of the series. On Mon, Aug 6, 2018 at 9:19 PM Mark Michelson wrote: > On 08/06/2018 01:58 PM, Anil Venkata wrote:

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

On 08/06/2018 01:58 PM, Anil Venkata wrote: Thanks Mark. Kindly look at my comment inline. On Fri, Aug 3, 2018 at 2:17 AM, Mark Michelson > wrote: On 08/01/2018 08:16 AM, vkomm...@redhat.com wrote: From: venkata anil

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

Thanks Mark. Kindly look at my comment inline. On Fri, Aug 3, 2018 at 2:17 AM, Mark Michelson wrote: > On 08/01/2018 08:16 AM, vkomm...@redhat.com wrote: > >> From: venkata anil >> >> Previous patches in the series doesn't address issue 1 explained in [1] >> i.e >> 1) removal of router gateway

Re: [ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

On 08/01/2018 08:16 AM, vkomm...@redhat.com wrote: From: venkata anil Previous patches in the series doesn't address issue 1 explained in [1] i.e 1) removal of router gateway port MAC address on external switches after expiring of aging time. 2) then external switches unable to learn the

[ovs-dev] [PATCH v7 4/4] Replace router internal MAC with gateway MAC for reply packets

From: venkata anil Previous patches in the series doesn't address issue 1 explained in [1] i.e 1) removal of router gateway port MAC address on external switches after expiring of aging time. 2) then external switches unable to learn the gateway MAC as reply packets carry router internal