Re: [ovs-dev] [PATCH v8 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-12-18 Thread Ben Pfaff
On Wed, Dec 18, 2019 at 11:34:32AM +, Vishal Deep Ajmera wrote: > > This introduces a new capabilities flag, which should be documented with > > the other capabilities in vswitch.xml. > > > > Do we read these capabilities in the ofproto layer somewhere ? Or is it for > display and documentati

Re: [ovs-dev] [PATCH v8 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-12-18 Thread Vishal Deep Ajmera via dev
> > I took a look. The underlying issue is that code here mixes integers, > ofp_port_t, and odp_port_t. OVS uses "sparse" annotations to keep these > from being confused, since they are different in important ways. I > spent some time working through the types here and appended a patch that > f

Re: [ovs-dev] [PATCH v8 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-12-17 Thread Ben Pfaff
On Tue, Dec 17, 2019 at 10:26:05PM +0100, Ilya Maximets wrote: > On 17.12.2019 20:23, Ben Pfaff wrote: > > Is there a reason to allow users to turn this off? What is the downside > > of enabling it? Why is it disabled by default? In general, OVS should > > optimize itself to the extent it can ra

Re: [ovs-dev] [PATCH v8 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-12-17 Thread Ilya Maximets
On 17.12.2019 20:23, Ben Pfaff wrote: > Thanks for the patch! > > "sparse" reports some type errors: > > ../ofproto/bond.c:357:30: error: incorrect type in assignment (different > base types) > ../ofproto/bond.c:357:30:expected unsigned int > ../ofproto/bond.c:357:30:got rest

Re: [ovs-dev] [PATCH v8 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-12-17 Thread Ben Pfaff
Thanks for the patch! "sparse" reports some type errors: ../ofproto/bond.c:357:30: error: incorrect type in assignment (different base types) ../ofproto/bond.c:357:30:expected unsigned int ../ofproto/bond.c:357:30:got restricted ofp_port_t [usertype] ofp_port ../ofproto/o

Re: [ovs-dev] [PATCH v8 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-12-17 Thread Matteo Croce
On Tue, Dec 17, 2019 at 11:03 AM Vishal Deep Ajmera wrote: > > Problem: > > In OVS-DPDK, flows with output over a bond interface of type “balance-tcp” > (using a hash on TCP/UDP 5-tuple) get translated by the ofproto layer into > "HASH" and "RECIRC" datapath actions. After recirculation,

[ovs-dev] [PATCH v8 1/1] Avoid dp_hash recirculation for balance-tcp bond selection mode

2019-12-17 Thread Vishal Deep Ajmera via dev
Problem: In OVS-DPDK, flows with output over a bond interface of type “balance-tcp” (using a hash on TCP/UDP 5-tuple) get translated by the ofproto layer into "HASH" and "RECIRC" datapath actions. After recirculation, the packet is forwarded to the bond member port based on 8-bits of the d