Re: [ovs-dev] [PATCH v9] AB bonding: Add "primary" interface concept

2020-07-08 Thread Flavio Leitner
Hi Jeff, On Tue, Jul 07, 2020 at 09:41:00PM +, Jeff Squyres (jsquyres) wrote: > On Jul 2, 2020, at 4:17 PM, Flavio Leitner wrote: > > On Thu, Jun 25, 2020 at 02:03:34PM -0700, Jeff Squyres via dev wrote: [...] > >> diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at > >> index e3402e

Re: [ovs-dev] [PATCH v9] AB bonding: Add "primary" interface concept

2020-07-07 Thread Jeff Squyres (jsquyres) via dev
On Jul 2, 2020, at 4:17 PM, Flavio Leitner wrote: > > > Hi Jeff, > > Thanks for following up. > I have a couple comments inline. > > > On Thu, Jun 25, 2020 at 02:03:34PM -0700, Jeff Squyres via dev wrote: >> In AB bonding, if the current active slave becomes disabled, a >> replacement slave i

Re: [ovs-dev] [PATCH v9] AB bonding: Add "primary" interface concept

2020-07-07 Thread Aaron Conole
Jeff Squyres writes: > In AB bonding, if the current active slave becomes disabled, a > replacement slave is arbitrarily picked from the remaining set of > enabled slaves. This commit adds the concept of a "primary" slave: an > interface that will always be (or become) the current active slave i

Re: [ovs-dev] [PATCH v9] AB bonding: Add "primary" interface concept

2020-07-02 Thread Flavio Leitner
Another thing, consider a small note in NEWS. On Thu, Jul 02, 2020 at 05:17:59PM -0300, Flavio Leitner wrote: > > Hi Jeff, > > Thanks for following up. > I have a couple comments inline. > > > On Thu, Jun 25, 2020 at 02:03:34PM -0700, Jeff Squyres via dev wrote: > > In AB bonding, if the cur

Re: [ovs-dev] [PATCH v9] AB bonding: Add "primary" interface concept

2020-07-02 Thread Flavio Leitner
Hi Jeff, Thanks for following up. I have a couple comments inline. On Thu, Jun 25, 2020 at 02:03:34PM -0700, Jeff Squyres via dev wrote: > In AB bonding, if the current active slave becomes disabled, a > replacement slave is arbitrarily picked from the remaining set of > enabled slaves. This

Re: [ovs-dev] [PATCH v9] AB bonding: Add "primary" interface concept

2020-07-02 Thread Jeff Squyres (jsquyres) via dev
Gentle nudge. Any further feedback on this one? Thank you! > On Jun 25, 2020, at 5:03 PM, Jeff Squyres wrote: > > In AB bonding, if the current active slave becomes disabled, a > replacement slave is arbitrarily picked from the remaining set of > enabled slaves. This commit adds the concept

[ovs-dev] [PATCH v9] AB bonding: Add "primary" interface concept

2020-06-25 Thread Jeff Squyres via dev
In AB bonding, if the current active slave becomes disabled, a replacement slave is arbitrarily picked from the remaining set of enabled slaves. This commit adds the concept of a "primary" slave: an interface that will always be (or become) the current active slave if it is enabled. The rationale