Re: [ovs-dev] [PATCHv2 1/2] ofp-parse: Fix small memory leak when calling parse_ofp_meter_mod_str().

2017-07-06 Thread Justin Pettit
> On Jul 5, 2017, at 4:09 PM, Ben Pfaff wrote: > > On Tue, Jun 27, 2017 at 06:14:43PM -0700, Justin Pettit wrote: >> The function parse_ofp_meter_mod_str() allocates a buffer called >> 'bands', which parse_ofp_meter_mod_str__() then steals for the member >> 'mm->meter.bands'. Calling functions

Re: [ovs-dev] [PATCHv2 1/2] ofp-parse: Fix small memory leak when calling parse_ofp_meter_mod_str().

2017-07-05 Thread Ben Pfaff
On Tue, Jun 27, 2017 at 06:14:43PM -0700, Justin Pettit wrote: > The function parse_ofp_meter_mod_str() allocates a buffer called > 'bands', which parse_ofp_meter_mod_str__() then steals for the member > 'mm->meter.bands'. Calling functions didn't free that stolen value and > the comments for thos

[ovs-dev] [PATCHv2 1/2] ofp-parse: Fix small memory leak when calling parse_ofp_meter_mod_str().

2017-06-27 Thread Justin Pettit
The function parse_ofp_meter_mod_str() allocates a buffer called 'bands', which parse_ofp_meter_mod_str__() then steals for the member 'mm->meter.bands'. Calling functions didn't free that stolen value and the comments for those function didn't indicate that was necessary. Found by valgrind. Sig