Re: [ovs-dev] [PATCHv5 1/2] userspace: Enable TSO support for non-DPDK.

2020-03-12 Thread William Tu
Thanks! I will fix it. On Thu, Mar 12, 2020 at 11:58 AM Flavio Leitner wrote: > > On Thu, Mar 12, 2020 at 10:04:30AM -0700, William Tu wrote: > [...] > > > static inline bool > > -dp_packet_ip_checksum_valid(const struct dp_packet *p) > > -{ > > -return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MA

Re: [ovs-dev] [PATCHv5 1/2] userspace: Enable TSO support for non-DPDK.

2020-03-12 Thread Flavio Leitner
On Thu, Mar 12, 2020 at 10:04:30AM -0700, William Tu wrote: [...] > static inline bool > -dp_packet_ip_checksum_valid(const struct dp_packet *p) > -{ > -return (p->mbuf.ol_flags & PKT_RX_IP_CKSUM_MASK) == > -PKT_RX_IP_CKSUM_GOOD; The indentation here is correct > -} > - > -stati

[ovs-dev] [PATCHv5 1/2] userspace: Enable TSO support for non-DPDK.

2020-03-12 Thread William Tu
This patch enables TSO support for non-DPDK use cases, and also add check-system-tso testsuite. Before TSO, we have to disable checksum offload, allowing the kernel to calculate the TCP/UDP packet checsum. With TSO, we can skip the checksum validation by enabling checksum offload, and with large pa