Re: [ovs-dev] [RFC 00/14] ovn-controller incremental processing.

2018-08-13 Thread Han Zhou
On Mon, Aug 6, 2018 at 10:30 PM, Han Zhou wrote: > > > > On Mon, Aug 6, 2018 at 3:13 AM, Mark Michelson wrote: > > > > Hi Han, > > > > I thought about this more over the weekend, and I was hoping I'd get to respond to my own e-mail before you saw it, because I realized I had a fundamental misunde

Re: [ovs-dev] [RFC 00/14] ovn-controller incremental processing.

2018-08-06 Thread Han Zhou
On Mon, Aug 6, 2018 at 3:13 AM, Mark Michelson wrote: > > Hi Han, > > I thought about this more over the weekend, and I was hoping I'd get to respond to my own e-mail before you saw it, because I realized I had a fundamental misunderstanding of the scope and nature of change handlers. I'll reply t

Re: [ovs-dev] [RFC 00/14] ovn-controller incremental processing.

2018-08-06 Thread Mark Michelson
Hi Han, I thought about this more over the weekend, and I was hoping I'd get to respond to my own e-mail before you saw it, because I realized I had a fundamental misunderstanding of the scope and nature of change handlers. I'll reply to your comments in-line below. On 08/05/2018 03:11 PM, H

Re: [ovs-dev] [RFC 00/14] ovn-controller incremental processing.

2018-08-05 Thread Han Zhou
Hi Mark, Thanks for the review and very valuable comments! (I was on vacation last week so sorry for slow response). On Tue, Jul 31, 2018 at 3:47 AM, Mark Michelson wrote: > > Hi Han, > > I've given this patchset a look, and I was following along pretty well until I got to about patch 11. From t

Re: [ovs-dev] [RFC 00/14] ovn-controller incremental processing.

2018-07-31 Thread Mark Michelson
Hi Han, I've given this patchset a look, and I was following along pretty well until I got to about patch 11. From that point on, I had to re-read the code more times than I care to admit before I finally understood what was going on :) What you have is a structure (lflow_ref_list_node) that

[ovs-dev] [RFC 00/14] ovn-controller incremental processing.

2018-07-24 Thread Han Zhou
This patch series is the rebase of previous patch series [1] on top of master where a series of changes that avoided passing ovsdb IDL (eaa4ead5) has been merged. The major concern of the previous patches are the maintainability of the dependencies. This patch series, thanks for the removal of pass