Re: [ovs-dev] [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size validation.

2018-01-18 Thread Kavanagh, Mark B
>From: Stokes, Ian >Sent: Thursday, January 18, 2018 5:35 PM >To: Kavanagh, Mark B ; d...@openvswitch.org >Subject: RE: [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size >validation. > >> Quick follow-up inline. >> >> >-Original Message- >> >From: Kavanagh, Mark B >> >Sent: Friday, Jan

Re: [ovs-dev] [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size validation.

2018-01-18 Thread Stokes, Ian
> Quick follow-up inline. > > >-Original Message- > >From: Kavanagh, Mark B > >Sent: Friday, January 12, 2018 5:00 PM > >To: Stokes, Ian ; d...@openvswitch.org > >Subject: RE: [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size > >validation. > > > > > > > >>-Original Message- >

Re: [ovs-dev] [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size validation.

2018-01-12 Thread Kavanagh, Mark B
Quick follow-up inline. >-Original Message- >From: Kavanagh, Mark B >Sent: Friday, January 12, 2018 5:00 PM >To: Stokes, Ian ; d...@openvswitch.org >Subject: RE: [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size >validation. > > > >>-Original Message- >>From: Stokes, Ian >>Sen

Re: [ovs-dev] [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size validation.

2018-01-12 Thread Kavanagh, Mark B
>-Original Message- >From: Stokes, Ian >Sent: Tuesday, January 9, 2018 10:54 PM >To: d...@openvswitch.org >Cc: Stokes, Ian ; Kavanagh, Mark B > >Subject: [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size validation. > Hey Ian, Thanks for the patch - some comments inline. Cheers, M

Re: [ovs-dev] [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size validation.

2018-01-09 Thread Stokes, Ian
> -Original Message- > From: Stokes, Ian > Sent: Tuesday, January 9, 2018 10:54 PM > To: d...@openvswitch.org > Cc: Stokes, Ian ; Kavanagh, Mark B > > Subject: [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size > validation. > > This commit replaces MTU_TO_FRAME_LEN(mtu) with > MTU_

[ovs-dev] [RFC PATCH v1 1/1] netdev-dpdk: Fix requested MTU size validation.

2018-01-09 Thread Ian Stokes
This commit replaces MTU_TO_FRAME_LEN(mtu) with MTU_TO_MAX_FRAME_LEN(mtu) when validating if an MTU will exceed NETDEV_DPDK_MAX_PKT_LEN in netdev_dpdk_set_mtu(). When setting an MTU we first check if the requested MTU frame size will exceed the maximum packet frame size supported in netdev_dpdk_se