Re: [ovs-dev] [action upcall meters 1/5] ofproto: Store meters using hmap

2017-04-28 Thread Jarno Rajahalme
> On Apr 27, 2017, at 11:28 PM, Andy Zhou wrote: > > On Thu, Apr 27, 2017 at 3:14 PM, Jarno Rajahalme > wrote: >> This incremental needed to satisfy GCC 4.9.2, due to ‘meter’ potentially >> being used uninitialized: >> >> diff --git

Re: [ovs-dev] [action upcall meters 1/5] ofproto: Store meters using hmap

2017-04-28 Thread Andy Zhou
On Thu, Apr 27, 2017 at 3:14 PM, Jarno Rajahalme wrote: > This incremental needed to satisfy GCC 4.9.2, due to ‘meter’ potentially > being used uninitialized: > > diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c > index 2e80db8..eb060d0 100644 > --- a/ofproto/ofproto.c > +++

Re: [ovs-dev] [action upcall meters 1/5] ofproto: Store meters using hmap

2017-04-27 Thread Jarno Rajahalme
This incremental needed to satisfy GCC 4.9.2, due to ‘meter’ potentially being used uninitialized: diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 2e80db8..eb060d0 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -6564,7 +6564,7 @@ handle_meter_request(struct ofconn *ofconn,

[ovs-dev] [action upcall meters 1/5] ofproto: Store meters using hmap

2017-04-14 Thread Andy Zhou
Currently, meters are stored in a fixed pointer array. It is not very efficient since the controller, at least in theory, can pick any meter id (up to the limits to uint32_t), not necessarily within the lower end of a region, or in close range to each other. In particular, OFPM_SLOWPATH and