Thanks Ben and Eelco
On Tue, Apr 30, 2019 at 9:18 AM Eelco Chaudron wrote:
>
>
> On 30 Apr 2019, at 18:10, Ben Pfaff wrote:
>
> > On 25.04.2019 2:47, William Tu wrote:
> >> +#define unlikely OVS_UNLIKELY
> >> +#define likely OVS_LIKELY
> >> +#define barrier() __asm__ __volatile__("": :
On 30 Apr 2019, at 18:10, Ben Pfaff wrote:
> On 25.04.2019 2:47, William Tu wrote:
>> +#define unlikely OVS_UNLIKELY
>> +#define likely OVS_LIKELY
>> +#define barrier() __asm__ __volatile__("": : :"memory")
>> +#define smp_rmb() barrier()
>> +#define smp_wmb() barrier()
>
> Does any of this
On 25.04.2019 2:47, William Tu wrote:
> +#define unlikely OVS_UNLIKELY
> +#define likely OVS_LIKELY
> +#define barrier() __asm__ __volatile__("": : :"memory")
> +#define smp_rmb() barrier()
> +#define smp_wmb() barrier()
Does any of this mean we're cutting and pasting Linux kernel code into
OVS
One more thing.
On 25.04.2019 2:47, William Tu wrote:
> +#define unlikely OVS_UNLIKELY
> +#define likely OVS_LIKELY
> +#define barrier() __asm__ __volatile__("": : :"memory")
> +#define smp_rmb() barrier()
> +#define smp_wmb() barrier()
You may probably use something like this:
#include
On 27.04.2019 16:28, William Tu wrote:
> > if WIN32
> > lib_libopenvswitch_la_SOURCES += \
> > diff --git a/lib/dp-packet.c b/lib/dp-packet.c
> > index 0976a35e758b..a61552f72988 100644
> > --- a/lib/dp-packet.c
> > +++ b/lib/dp-packet.c
> > @@ -22,6 +22,9 @@
> >
On Thu, Apr 25, 2019 at 8:09 AM Ilya Maximets
wrote:
> Hi.
>
> This is not a full review. Just a bunch of thoughts.
>
> See inline.
>
> Best regards, Ilya Maximets.
>
> On 25.04.2019 2:47, William Tu wrote:
> > The patch introduces experimental AF_XDP support for OVS netdev.
> > AF_XDP is a new
On Fri, Apr 26, 2019 at 2:46 AM Ilya Maximets
wrote:
> On 25.04.2019 2:47, William Tu wrote:
> > diff --git a/lib/netdev.c b/lib/netdev.c
> > index 7d7ecf6f0946..c30016b34033 100644
> > --- a/lib/netdev.c
> > +++ b/lib/netdev.c
> > @@ -145,6 +145,7 @@ netdev_initialize(void)
> >
On 25.04.2019 2:47, William Tu wrote:
> diff --git a/lib/netdev.c b/lib/netdev.c
> index 7d7ecf6f0946..c30016b34033 100644
> --- a/lib/netdev.c
> +++ b/lib/netdev.c
> @@ -145,6 +145,7 @@ netdev_initialize(void)
> netdev_register_provider(_linux_class);
>
Hi Ilya,
Very appreciated for your review!
I will fix/address your comments in my next version.
see replies inline
On Thu, Apr 25, 2019 at 8:09 AM Ilya Maximets
wrote:
> Hi.
>
> This is not a full review. Just a bunch of thoughts.
>
> See inline.
>
> Best regards, Ilya Maximets.
>
> On
Hi.
This is not a full review. Just a bunch of thoughts.
See inline.
Best regards, Ilya Maximets.
On 25.04.2019 2:47, William Tu wrote:
> The patch introduces experimental AF_XDP support for OVS netdev.
> AF_XDP is a new address family working together with eBPF/XDP.
> A socket with AF_XDP
10 matches
Mail list logo
