Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: C99 style comment
#196 FILE: ovn/controller/chassis.c:343:
// Return the first chassis mac.
WARNING: Line is 81 characters long (recommended limit is 79)
#311 FILE: ovn/controller/physical.c:238:
put_replace_router_port_mac_flows(const struct sbrec_port_binding
*localnet_port,
WARNING: Line lacks whitespace around operator
#323 FILE: ovn/controller/physical.c:250:
int tag = localnet_port->tag?*localnet_port->tag:0;
ERROR: C99 style comment
#337 FILE: ovn/controller/physical.c:264:
// Get chassis mac
ERROR: C99 style comment
#366 FILE: ovn/controller/physical.c:293:
// Parsing of mac failed.
ERROR: C99 style comment
#373 FILE: ovn/controller/physical.c:300:
// Replace Mac flow
WARNING: Empty return followed by brace, consider omitting
#396 FILE: ovn/controller/physical.c:323:
}
WARNING: Line is 80 characters long (recommended limit is 79)
#408 FILE: ovn/controller/physical.c:796:
put_replace_router_port_mac_flows(binding, chassis, local_datapaths,
ERROR: C99 style comment
#455 FILE: ovn/northd/ovn-northd.c:508:
// No value in network_type is taken as OVERLAY.
WARNING: Line is 88 characters long (recommended limit is 79)
#539 FILE: ovn/ovn-nb.ovsschema:33:
"enum": ["set", ["overlay",
"vlan"]]},
WARNING: Line is 81 characters long (recommended limit is 79)
#576 FILE: ovn/ovn-sb.xml:299:
column="external_ids:ovn-chassis-mac-mappings"/> column of the
Open_vSwitch
WARNING: Line is 91 characters long (recommended limit is 79)
WARNING: Line lacks whitespace around operator
#607 FILE: ovn/utilities/ovn-nbctl.c:575:
ls-add [SWITCH] [TYPE] create a logical switch named SWITCH of TYPE vlan
or overlay\n\
Lines checked: 1039, Warnings: 8, Errors: 5
Please check this out. If you feel there has been an error, please email
acon...@bytheb.org
Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
