Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: C99 style comment
#57 FILE: ovn/controller/pinctrl.c:224:
#define GARP_DEF_REPEAT_INTERVAL_MS (3 * 60 * 1000) // 3 mins
ERROR: C99 style comment
#126 FILE: ovn/controller/pinctrl.c:2574:
// Router Port binding without ip and mac configured.
WARNING: Line is 82 characters long (recommended limit is 79)
#134 FILE: ovn/controller/pinctrl.c:2582:
const char *lrp_name = smap_get(&binding_rec->options,
"distributed-port");
WARNING: Line is 85 characters long (recommended limit is 79)
#137 FILE: ovn/controller/pinctrl.c:2585:
distributed_port = lport_lookup_by_name(sbrec_port_binding_by_name,
lrp_name);
WARNING: Line is 95 characters long (recommended limit is 79)
#146 FILE: ovn/controller/pinctrl.c:2594:
const char *network_type = smap_get(&peer_port->datapath->external_ids,
"network-type");
ERROR: C99 style comment
#148 FILE: ovn/controller/pinctrl.c:2596:
// Advertise GARP only of logical switch is of type vlan.
ERROR: Improper whitespace around control block
#205 FILE: ovn/controller/pinctrl.c:2953:
SSET_FOR_EACH(gw_port, local_l3gw_ports) {
WARNING: Line is 82 characters long (recommended limit is 79)
#225 FILE: ovn/controller/pinctrl.c:2973:
cr_port = lport_lookup_by_name(sbrec_port_binding_by_name,
cr_peer_name);
WARNING: Line is 81 characters long (recommended limit is 79)
#232 FILE: ovn/controller/pinctrl.c:2980:
is_cr_resident =
pinctrl_is_chassis_resident(sbrec_port_binding_by_name,
ERROR: C99 style comment
#241 FILE: ovn/controller/pinctrl.c:2989:
// Router Port binding without ip and mac configured.
Lines checked: 386, Warnings: 5, Errors: 5
Please check this out. If you feel there has been an error, please email
acon...@bytheb.org
Thanks,
0-day Robot
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
