Hi, Eelco
Thanks for your comments.
Eelco Chaudron 于2022年4月29日周五 18:54写道：
>
>
> On 12 Apr 2022, at 11:09, Peng He wrote:
>
> > David Marchand 于2022年4月12日周二 16:40写道：
> >
> >> On Thu, Apr 7, 2022 at 4:13 AM Peng He wrote:
> >>>
> >>> I understand there is no need to introduce a rcu api,
> >>>
On 12 Apr 2022, at 11:09, Peng He wrote:
> David Marchand 于2022年4月12日周二 16:40写道：
>
>> On Thu, Apr 7, 2022 at 4:13 AM Peng He wrote:
>>>
>>> I understand there is no need to introduce a rcu api,
>>> but at least put these codes into a separate function ? :-)
>>
>> No strong opinion.
>>
>>
Thanks!
David Marchand 于2022年4月12日周二 16:49写道：
> On Tue, Apr 12, 2022 at 4:17 AM Peng He wrote:
> >
> > Hi,
> >
> > with make check -C build-asan TESTSUITEFLAGS="-k meter -d"
> > the ovs is build with asan enabled, is this feature already in current
> > building system?
> >
> > I did not find
David Marchand 于2022年4月12日周二 16:40写道：
> On Thu, Apr 7, 2022 at 4:13 AM Peng He wrote:
> >
> > I understand there is no need to introduce a rcu api,
> > but at least put these codes into a separate function ? :-)
>
> No strong opinion.
>
>
> >> diff --git a/ofproto/ofproto-dpif.c
On Tue, Apr 12, 2022 at 4:17 AM Peng He wrote:
>
> Hi,
>
> with make check -C build-asan TESTSUITEFLAGS="-k meter -d"
> the ovs is build with asan enabled, is this feature already in current
> building system?
>
> I did not find it. Can anyone give some hint?
> Thanks !
I used a similar
On Thu, Apr 7, 2022 at 4:13 AM Peng He wrote:
>
> I understand there is no need to introduce a rcu api,
> but at least put these codes into a separate function ? :-)
No strong opinion.
>> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
>> index 6601f2346..402cdcdf5 100644
>> ---
Hi,
with make check -C build-asan TESTSUITEFLAGS="-k meter -d"
the ovs is build with asan enabled, is this feature already in current
building system?
I did not find it. Can anyone give some hint?
Thanks !
David Marchand 于2022年4月7日周四 02:55写道：
> On Sat, Mar 26, 2022 at 3:43 AM Peng He wrote:
I understand there is no need to introduce a rcu api,
but at least put these codes into a separate function ? :-)
a minor issue, see below:
David Marchand 于2022年4月7日周四 02:55写道：
> On Sat, Mar 26, 2022 at 3:43 AM Peng He wrote:
> >
> > add a rcu_barrier before close_dpif_backer to ensure that
>
On Sat, Mar 26, 2022 at 3:43 AM Peng He wrote:
>
> add a rcu_barrier before close_dpif_backer to ensure that
> all meters has been freed before id_pool_destory meter's
> id-pool.
>
> Signed-off-by: Peng He
On the principle, the issue seems fixed.
And I have been running successfully 'make check
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Peng He needs to sign off.
WARNING: Unexpected sign-offs from developers who are not
add a rcu_barrier before close_dpif_backer to ensure that
all meters has been freed before id_pool_destory meter's
id-pool.
Signed-off-by: Peng He
---
ofproto/ofproto-dpif.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index
11 matches
Mail list logo
