Re: [ovs-dev] [ovs-dev v2 2/4] ofproto-dpif-upcall: fix race condition

2022-08-22 Thread Mike Pattrick
On Sun, Aug 21, 2022 at 12:34 AM Peng He wrote: > > Hi Mike > > Intuitionally, I do not think it is a good idea. I agree with you, that change is really a sledge hammer. I'll collect some telemetry from the Massif check to see why exactly the race condition is occurring. Cheers, M > > if src->u

Re: [ovs-dev] [ovs-dev v2 2/4] ofproto-dpif-upcall: fix race condition

2022-08-20 Thread Peng He
Hi Mike Intuitionally, I do not think it is a good idea. if src->ukey_state = DELETED, but dst is to bring it back to ALIVE (some state), then this is a bug, because it breaks the state machine behind. I think the checking we can relax here is only when dst and ukey stat is in EVICTED and DELETE

Re: [ovs-dev] [ovs-dev v2 2/4] ofproto-dpif-upcall: fix race condition

2022-08-16 Thread Mike Pattrick
On Tue, Aug 16, 2022 at 4:04 AM Peng He wrote: > > Hi, Mike > > by changing it into the function, you mean relax the checking if the state is > either EVICTED or DELETED? > In my testing code, I changed it to this: diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index

Re: [ovs-dev] [ovs-dev v2 2/4] ofproto-dpif-upcall: fix race condition

2022-08-16 Thread Peng He
Hi, Mike by changing it into the function, you mean relax the checking if the state is either EVICTED or DELETED? Mike Pattrick 于2022年8月15日周一 20:16写道: > On Sat, Jun 4, 2022 at 11:19 AM Peng He wrote: > > > > There is a race condition between the revalidator threads and > > the handler/pmd th

Re: [ovs-dev] [ovs-dev v2 2/4] ofproto-dpif-upcall: fix race condition

2022-08-15 Thread Mike Pattrick
On Sat, Jun 4, 2022 at 11:19 AM Peng He wrote: > > There is a race condition between the revalidator threads and > the handler/pmd threads. > > revalidator PMD threads > push_dp_ops deletes a key and tries > to del the dp magaflow. > do

Re: [ovs-dev] [ovs-dev v2 2/4] ofproto-dpif-upcall: fix race condition

2022-06-04 Thread 0-day Robot
Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not a

[ovs-dev] [ovs-dev v2 2/4] ofproto-dpif-upcall: fix race condition

2022-06-04 Thread Peng He
There is a race condition between the revalidator threads and the handler/pmd threads. revalidator PMD threads push_dp_ops deletes a key and tries to del the dp magaflow. does the upcall, generates a new ukey,