Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

Ilya Maximets 于2023年8月12日周六 02:18写道： > On 8/11/23 19:37, Ilya Maximets wrote: > > On 8/9/23 05:02, Peng He wrote: > >> OVS allows overlapping megaflows, as long as the actions of these > >> megaflows are equal. However, the current implementation of action > >> modification relies on flow_lookup

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

On 8/11/23 19:37, Ilya Maximets wrote: > On 8/9/23 05:02, Peng He wrote: >> OVS allows overlapping megaflows, as long as the actions of these >> megaflows are equal. However, the current implementation of action >> modification relies on flow_lookup instead of ufid, this could result >> in looking

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

On 8/9/23 05:02, Peng He wrote: > OVS allows overlapping megaflows, as long as the actions of these > megaflows are equal. However, the current implementation of action > modification relies on flow_lookup instead of ufid, this could result > in looking up a wrong megaflow and make the ukeys and me

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

again, I forget the fixes tag ... 0-day Robot 于2023年8月9日周三 11:19写道： > Bleep bloop. Greetings Peng He, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Author

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not a

[ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

OVS allows overlapping megaflows, as long as the actions of these megaflows are equal. However, the current implementation of action modification relies on flow_lookup instead of ufid, this could result in looking up a wrong megaflow and make the ukeys and megaflows inconsistent Just like the test

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

Ilya Maximets 于2023年7月28日周五 20:25写道： > On 7/28/23 11:02, Peng He wrote: > > > > > > Ilya Maximets mailto:i.maxim...@ovn.org>> > 于2023年7月28日周五 00:59写道： > > > > On 7/27/23 04:31, Peng He wrote: > > > > > > > > > Eelco Chaudron mailto:echau...@redhat.com> >

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

On 7/28/23 11:02, Peng He wrote: > > > Ilya Maximets mailto:i.maxim...@ovn.org>> 于2023年7月28日周五 > 00:59写道： > > On 7/27/23 04:31, Peng He wrote: > > > > > > Eelco Chaudron mailto:echau...@redhat.com> > >> 于2023年7月6日周四 > 15:

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

Ilya Maximets 于2023年7月28日周五 00:59写道： > On 7/27/23 04:31, Peng He wrote: > > > > > > Eelco Chaudron mailto:echau...@redhat.com>> > 于2023年7月6日周四 15:52写道： > > > > > > > > On 6 Jul 2023, at 4:32, Peng He wrote: > > > > > Eelco Chaudron mailto:echau...@redhat.com>> > 于2023年7月5日周三 22:16写道： > >

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

On 7/27/23 04:31, Peng He wrote: > > > Eelco Chaudron mailto:echau...@redhat.com>> > 于2023年7月6日周四 15:52写道： > > > > On 6 Jul 2023, at 4:32, Peng He wrote: > > > Eelco Chaudron mailto:echau...@redhat.com>> > 于2023年7月5日周三 22:16写道： > > > >> > >> > >> On 1 Jul 2023, at 4:

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

Eelco Chaudron 于2023年7月6日周四 15:52写道： > > > On 6 Jul 2023, at 4:32, Peng He wrote: > > > Eelco Chaudron 于2023年7月5日周三 22:16写道： > > > >> > >> > >> On 1 Jul 2023, at 4:43, Peng He wrote: > >> > >>> OVS allows overlapping megaflows, as long as the actions of these > >>> megaflows are equal. However,

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

On 7/5/23 16:22, Eelco Chaudron wrote: >>> +dnl Hold the prefix 10.1.2.2/24 by another 10s. >>> +AT_CHECK([ovs-appctl netdev-dummy/receive p1 >>> 'ipv4(src=10.0.0.1,dst=10.1.2.2),tcp(src=1,dst=2)']) >>> +dnl Send more 10.1.0.2 to make 10.1.0.0/16 tuple preprend 10.1.2.0/24 >>> tuple in pvector of

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

Eelco Chaudron 于2023年7月6日周四 15:52写道： > > > On 6 Jul 2023, at 4:32, Peng He wrote: > > > Eelco Chaudron 于2023年7月5日周三 22:16写道： > > > >> > >> > >> On 1 Jul 2023, at 4:43, Peng He wrote: > >> > >>> OVS allows overlapping megaflows, as long as the actions of these > >>> megaflows are equal. However,

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

On 6 Jul 2023, at 4:32, Peng He wrote: > Eelco Chaudron 于2023年7月5日周三 22:16写道： > >> >> >> On 1 Jul 2023, at 4:43, Peng He wrote: >> >>> OVS allows overlapping megaflows, as long as the actions of these >>> megaflows are equal. However, the current implementation of action >>> modification relies

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

Eelco Chaudron 于2023年7月5日周三 22:16写道： > > > On 1 Jul 2023, at 4:43, Peng He wrote: > > > OVS allows overlapping megaflows, as long as the actions of these > > megaflows are equal. However, the current implementation of action > > modification relies on flow_lookup instead of ufid, this could resul

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

On 5 Jul 2023, at 16:16, Eelco Chaudron wrote: > On 1 Jul 2023, at 4:43, Peng He wrote: > >> OVS allows overlapping megaflows, as long as the actions of these >> megaflows are equal. However, the current implementation of action >> modification relies on flow_lookup instead of ufid, this could r

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

On 1 Jul 2023, at 4:43, Peng He wrote: > OVS allows overlapping megaflows, as long as the actions of these > megaflows are equal. However, the current implementation of action > modification relies on flow_lookup instead of ufid, this could result > in looking up a wrong megaflow and make the uk

Re: [ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

Bleep bloop. Greetings Peng He, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Peng He needs to sign off. WARNING: Unexpected sign-offs from developers who are not a

[ovs-dev] [ovs-dev v4] dpif-netdev: fix dpif_netdev_flow_put

OVS allows overlapping megaflows, as long as the actions of these megaflows are equal. However, the current implementation of action modification relies on flow_lookup instead of ufid, this could result in looking up a wrong megaflow and make the ukeys and megaflows inconsistent Just like the test