Re: [ovs-dev] [patch v2 3/3] conntrack: Disable algs by default.

2017-12-04 Thread Darrell Ball
On 11/30/17, 8:02 AM, "Aaron Conole" wrote: Darrell Ball writes: > There is a bug here in that the control connection should still be created even though it is likely an unused control connection. > The following incremental fixes it.

Re: [ovs-dev] [patch v2 3/3] conntrack: Disable algs by default.

2017-11-30 Thread Aaron Conole
Darrell Ball writes: > There is a bug here in that the control connection should still be created > even though it is likely an unused control connection. > The following incremental fixes it. Good catch. While thinking about it, I was wondering if it would be possible to

Re: [ovs-dev] [patch v2 3/3] conntrack: Disable algs by default.

2017-11-29 Thread Darrell Ball
There is a bug here in that the control connection should still be created even though it is likely an unused control connection. The following incremental fixes it. diff --git a/lib/conntrack.c b/lib/conntrack.c index fed9f61..18016c1 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -505,7

[ovs-dev] [patch v2 3/3] conntrack: Disable algs by default.

2017-11-22 Thread Darrell Ball
Presently, alg processing is enabled by default to better exercise code. This is similar to kernels before 4.7 as well. The recommended default behavior in the newer kernels is to only process algs if a helper is supplied in a conntrack rule. The behavior is changed to match the later kernels.