Re: [ovs-dev] [patch v5] conntrack: ignore port for ICMP/ICMPv6 NAT.

2019-06-07 Thread Ben Pfaff
On Wed, Jun 05, 2019 at 03:35:34PM -0700, Darrell Ball wrote: > From: solomon > > ICMP/ICMPv6 fails, if the src/dst port is set in a common NAT rule. > For example: > actions=ct(nat(dst=172.16.1.100:5000),commit,table=40) > > Fixes: 4cd0481c9e8b ("conntrack: Fix wasted work for ICMP NAT.") > CC:

Re: [ovs-dev] [patch v5] conntrack: ignore port for ICMP/ICMPv6 NAT.

2019-06-05 Thread solomon
It looks good to meļ¼Œthank you. Darrell Ball wrote: > From: solomon > > ICMP/ICMPv6 fails, if the src/dst port is set in a common NAT rule. > For example: > actions=ct(nat(dst=172.16.1.100:5000),commit,table=40) > > Fixes: 4cd0481c9e8b ("conntrack: Fix wasted work for ICMP NAT.") > CC: Darrell

[ovs-dev] [patch v5] conntrack: ignore port for ICMP/ICMPv6 NAT.

2019-06-05 Thread Darrell Ball
From: solomon ICMP/ICMPv6 fails, if the src/dst port is set in a common NAT rule. For example: actions=ct(nat(dst=172.16.1.100:5000),commit,table=40) Fixes: 4cd0481c9e8b ("conntrack: Fix wasted work for ICMP NAT.") CC: Darrell Ball Signed-off-by: solomon Signed-off-by: Darrell Ball Co-authore