Re: [ovs-dev] [patch v5 2/2] conntrack: Add rcu support.

2019-05-06 Thread Darrell Ball
On Mon, May 6, 2019 at 8:01 AM Ben Pfaff wrote: > On Thu, May 02, 2019 at 09:34:05PM -0700, Darrell Ball wrote: > > For performance and code simplification reasons, add rcu support for > > conntrack. The array of hmaps is replaced by a cmap as part of this > > conversion. Using a single map also

Re: [ovs-dev] [patch v5 2/2] conntrack: Add rcu support.

2019-05-06 Thread Ben Pfaff
On Thu, May 02, 2019 at 09:34:05PM -0700, Darrell Ball wrote: > For performance and code simplification reasons, add rcu support for > conntrack. The array of hmaps is replaced by a cmap as part of this > conversion. Using a single map also simplifies the handling of NAT > and allows the removal o

Re: [ovs-dev] [patch v5 2/2] conntrack: Add rcu support.

2019-05-03 Thread Darrell Ball
I do have the following incremental in my local queue: This fixes a theoretical bug in TCP shutdown. diff --git a/lib/conntrack-icmp.c b/lib/conntrack-icmp.c index f00a4c4..f128d5d 100644 --- a/lib/conntrack-icmp.c +++ b/lib/conntrack-icmp.c @@ -46,12 +46,12 @@ conn_icmp_cast(const struct conn *c

[ovs-dev] [patch v5 2/2] conntrack: Add rcu support.

2019-05-02 Thread Darrell Ball
For performance and code simplification reasons, add rcu support for conntrack. The array of hmaps is replaced by a cmap as part of this conversion. Using a single map also simplifies the handling of NAT and allows the removal of the nat_conn map and friends. Per connection entry locks are introd