Re: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

2021-06-16 Thread Ferriter, Cian
sha > Basavapatna > Subject: RE: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header > files. > > > Hi Ian, > > > > Thanks for the review. My responses are inline. > > > > > -Original Message- > > > From: Stokes, Ian &g

Re: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

2021-06-15 Thread Stokes, Ian
> Hi Ian, > > Thanks for the review. My responses are inline. > > > -Original Message- > > From: Stokes, Ian > > Sent: Wednesday 19 May 2021 16:54 > > To: Ferriter, Cian ; ovs-dev@openvswitch.org > > Cc: i.maxim...@ovn.org > > Subject:

Re: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

2021-06-10 Thread Ferriter, Cian
Hi Ian, Thanks for the review. My responses are inline. > -Original Message- > From: Stokes, Ian > Sent: Wednesday 19 May 2021 16:54 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v12 01/16] dpif-netdev: Refactor

Re: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

2021-05-19 Thread Stokes, Ian
> Split the very large file dpif-netdev.c and the datastructures > it contains into multiple header files. Each header file is > responsible for the datastructures of that component. > > This logical split allows better reuse and modularity of the code, > and reduces the very large file

Re: [ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

2021-05-17 Thread 0-day Robot
Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Improper whitespace around control block #231 FILE: lib/dpif-netdev-private-dfc.h:111:

[ovs-dev] [v12 01/16] dpif-netdev: Refactor to multiple header files.

2021-05-17 Thread Cian Ferriter
From: Harry van Haaren Split the very large file dpif-netdev.c and the datastructures it contains into multiple header files. Each header file is responsible for the datastructures of that component. This logical split allows better reuse and modularity of the code, and reduces the very large