Hi Flavio,
Thanks for the review. My responses are inline.
Thanks,
Cian
> -Original Message-
> From: Flavio Leitner
> Sent: Friday 18 June 2021 13:12
> To: Ferriter, Cian
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v13 01/12] dpi
Hello,
Some comments below.
On Thu, Jun 17, 2021 at 05:18:14PM +0100, Cian Ferriter wrote:
> From: Harry van Haaren
>
> Split the very large file dpif-netdev.c and the datastructures
> it contains into multiple header files. Each header file is
> responsible for the datastructures of that
Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#374 FILE: lib/dpif-netdev-private-dfc.h:111:
From: Harry van Haaren
Split the very large file dpif-netdev.c and the datastructures
it contains into multiple header files. Each header file is
responsible for the datastructures of that component.
This logical split allows better reuse and modularity of the code,
and reduces the very large
