Re: [ovs-dev] [v14 01/11] dpif-netdev: Refactor to multiple header files.

2021-07-07 Thread Ferriter, Cian
Hi Flavio, Thanks for the info. My response is inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Tuesday 6 July 2021 20:36 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v14 01/11] dpif-netdev: Re

Re: [ovs-dev] [v14 01/11] dpif-netdev: Refactor to multiple header files.

2021-07-06 Thread Flavio Leitner
On Thu, Jul 01, 2021 at 04:06:09PM +0100, Cian Ferriter wrote: > From: Harry van Haaren > > Split the very large file dpif-netdev.c and the datastructures > it contains into multiple header files. Each header file is > responsible for the datastructures of that component. > > This logical split

Re: [ovs-dev] [v14 01/11] dpif-netdev: Refactor to multiple header files.

2021-07-06 Thread Flavio Leitner
On Tue, Jul 06, 2021 at 04:20:59PM -0300, Flavio Leitner wrote: > > Hi, > > I was reviewing the patch while testing and I can consistently > loss 1Mpps (or more) on a P2P scenario with this flow table: > ovs-ofctl add-flow br0 in_port=dpdk0,actions=output:dpdk1 > > TX: 14Mpps > RX without

Re: [ovs-dev] [v14 01/11] dpif-netdev: Refactor to multiple header files.

2021-07-06 Thread Flavio Leitner
Hi, I was reviewing the patch while testing and I can consistently loss 1Mpps (or more) on a P2P scenario with this flow table: ovs-ofctl add-flow br0 in_port=dpdk0,actions=output:dpdk1 TX: 14Mpps RX without patch: +12.6Mpps RX with patch: 11.67Mpps CPU: Intel(R) Xeon(R) Silver 4114 CPU @

Re: [ovs-dev] [v14 01/11] dpif-netdev: Refactor to multiple header files.

2021-07-01 Thread 0-day Robot
Bleep bloop. Greetings Cian Ferriter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #530 FILE: lib/dpif-netdev-private-dpcls.h:97:

[ovs-dev] [v14 01/11] dpif-netdev: Refactor to multiple header files.

2021-07-01 Thread Cian Ferriter
From: Harry van Haaren Split the very large file dpif-netdev.c and the datastructures it contains into multiple header files. Each header file is responsible for the datastructures of that component. This logical split allows better reuse and modularity of the code, and reduces the very large