Re: [ovs-dev] [v2] odp-execute: Check IPv4 checksum offload flag in AVX.

2024-06-25 Thread Eelco Chaudron
On 17 Jun 2024, at 16:08, Emma Finn wrote: > The AVX implementation for IPv4 action did not check whether > the IPv4 checksum offload flag has been set and was incorrectly > calculating checksums in software. Adding a check to skip AVX > checksum calculation when offload flags are set. > > Sign

Re: [ovs-dev] [v2] odp-execute: Check IPv4 checksum offload flag in AVX.

2024-06-21 Thread Eelco Chaudron
On 20 Jun 2024, at 20:48, Mike Pattrick wrote: > On Mon, Jun 17, 2024 at 10:08 AM Emma Finn wrote: >> >> The AVX implementation for IPv4 action did not check whether >> the IPv4 checksum offload flag has been set and was incorrectly >> calculating checksums in software. Adding a check to skip A

Re: [ovs-dev] [v2] odp-execute: Check IPv4 checksum offload flag in AVX.

2024-06-20 Thread Mike Pattrick
On Mon, Jun 17, 2024 at 10:08 AM Emma Finn wrote: > > The AVX implementation for IPv4 action did not check whether > the IPv4 checksum offload flag has been set and was incorrectly > calculating checksums in software. Adding a check to skip AVX > checksum calculation when offload flags are set. >

Re: [ovs-dev] [v2] odp-execute: Check IPv4 checksum offload flag in AVX.

2024-06-20 Thread Eelco Chaudron
On 20 Jun 2024, at 13:01, Finn, Emma wrote: >> -Original Message- >> From: Eelco Chaudron >> Sent: Thursday, June 20, 2024 9:48 AM >> To: Finn, Emma >> Cc: ovs-dev@openvswitch.org; m...@redhat.com >> Subject: Re: [v2] odp-execute: Check IPv4 checksum offload flag in AVX. >> >> On 17 Ju

Re: [ovs-dev] [v2] odp-execute: Check IPv4 checksum offload flag in AVX.

2024-06-20 Thread Finn, Emma
> -Original Message- > From: Eelco Chaudron > Sent: Thursday, June 20, 2024 9:48 AM > To: Finn, Emma > Cc: ovs-dev@openvswitch.org; m...@redhat.com > Subject: Re: [v2] odp-execute: Check IPv4 checksum offload flag in AVX. > > On 17 Jun 2024, at 16:08, Emma Finn wrote: > > > The AVX impl

Re: [ovs-dev] [v2] odp-execute: Check IPv4 checksum offload flag in AVX.

2024-06-20 Thread Eelco Chaudron
On 17 Jun 2024, at 16:08, Emma Finn wrote: > The AVX implementation for IPv4 action did not check whether > the IPv4 checksum offload flag has been set and was incorrectly > calculating checksums in software. Adding a check to skip AVX > checksum calculation when offload flags are set. > > Signed-

[ovs-dev] [v2] odp-execute: Check IPv4 checksum offload flag in AVX.

2024-06-17 Thread Emma Finn
The AVX implementation for IPv4 action did not check whether the IPv4 checksum offload flag has been set and was incorrectly calculating checksums in software. Adding a check to skip AVX checksum calculation when offload flags are set. Signed-off-by: Emma Finn Reported-by: Eelco Chaudron --- li