> > -Original Message-
> > From: Eelco Chaudron
> > Sent: Wednesday, July 7, 2021 10:41 AM
> > To: Van Haaren, Harry
> > Cc: Amber, Kumar ; d...@openvswitch.org;
> > i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
> >
> > Subject
> -Original Message-
> From: Eelco Chaudron
> Sent: Wednesday, July 7, 2021 10:41 AM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; d...@openvswitch.org;
> i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
>
> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add
t; From: Eelco Chaudron
>>>> Sent: Friday, July 2, 2021 8:10 AM
>>>> To: Van Haaren, Harry
>>>> Cc: Amber, Kumar ; d...@openvswitch.org;
>>>> i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
>>>>
>>>> Subject: Re: [ovs-dev] [v
>> Cc: Amber, Kumar ; d...@openvswitch.org;
> >> i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
> >>
> >> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation
> >> function for
> >> miniflow extract
> >>
> >>
>
es, Ian
>>
>> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function
>> for
>> miniflow extract
>>
>>
>>
>> On 1 Jul 2021, at 19:24, Van Haaren, Harry wrote:
>>
>>>> -Original Message-
>>
> -Original Message-
> From: Eelco Chaudron
> Sent: Friday, July 2, 2021 8:10 AM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; d...@openvswitch.org;
> i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
>
> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add
es, Ian
>>
>> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function
>> for
>> miniflow extract
>>
>>
>>
>> On 29 Jun 2021, at 13:05, Van Haaren, Harry wrote:
>>
>>> Hi Eelco,
>>>
>>> Would you
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday, July 1, 2021 5:19 PM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; d...@openvswitch.org;
> i.maxim...@ovn.org; Flavio Leitner ; Stokes, Ian
>
> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add
On 29 Jun 2021, at 13:05, Van Haaren, Harry wrote:
> Hi Eelco,
>
> Would you describe the actual test being run below?
>
> I'm having a hard time figuring out what the actual datapath packet flow is.
> It seems strange
> that MFEX optimizations are affected by flow-count, that doesn't really
haudron
> Sent: Tuesday, June 29, 2021 7:36 PM
> To: Amber, Kumar
> Cc: Van Haaren, Harry ; d...@openvswitch.org;
> i.maxim...@ovn.org; Stokes, Ian ; Flavio Leitner
>
> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function
> for miniflow extract
>
Hi,
On Tue, Jun 29, 2021 at 03:20:36PM +, Amber, Kumar wrote:
> Hi Flavio,
>
> Replies inline.
>
> > >
> > > Guess the above needs to be atomic.
> > >
> > > Removed based on Flavio comments.
> >
> > I asked to initialize that using an API and Eelco is asking to set it
> > atomically.
> >
> > -Original Message-
> > From: Amber, Kumar
> > Sent: Thursday, June 24, 2021 12:27 PM
> > To: Stokes, Ian ; d...@openvswitch.org; Van Haaren,
> Harry
> >
> > Cc: i.maxim...@ovn.org
> > Subject: RE: [ovs-dev] [v4 02/12] dpif-netdev: Add a
> Hi Ian,
>
> Thanks for reviews, replies are inlined.
>
Thanks Amber looking forward to the v5.
BR
Ian
>
>
>
> > > +/* Call optimized miniflow for each batch of packet. */
> > > +uint32_t hit_mask = mfex_impls[j].extract_func(packets,
> > > test_keys,
> > > +
;; Stokes, Ian
mailto:ian.sto...@intel.com>>; Flavio Leitner
mailto:f...@sysclose.org>>
Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for
miniflow extract
On 17 Jun 2021, at 18:27, Kumar Amber wrote:
This patch introduced the auto-validation functi
Hi Flavio,
Replies inline.
> >
> > Guess the above needs to be atomic.
> >
> > Removed based on Flavio comments.
>
> I asked to initialize that using an API and Eelco is asking to set it
> atomically.
> The requests are complementary, right?
>
Yes True sorry for confusion so we have
; Amber, Kumar
Cc: d...@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian
; Flavio Leitner
Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation
function for miniflow extract
On 17 Jun 2021, at 18:27, Kumar Amber wrote:
This patch introduced the auto-validation function which
allows
tch.org; i.maxim...@ovn.org; Stokes, Ian
> ; Flavio Leitner
> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function
> for miniflow extract
>
>
> On 17 Jun 2021, at 18:27, Kumar Amber wrote:
>
> This patch introduced the auto-validation function w
Hi Eelco,
Thanks Again for reviews , Pls find my replies inline.
From: Eelco Chaudron
Sent: Tuesday, June 29, 2021 5:14 PM
To: Van Haaren, Harry ; Amber, Kumar
Cc: d...@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian
; Flavio Leitner
Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto
On 17 Jun 2021, at 18:27, Kumar Amber wrote:
This patch introduced the auto-validation function which
allows users to compare the batch of packets obtained from
different miniflow implementations against the linear
miniflow extract and return a hitmask.
The autovaidator function can be
Flavio Leitner ;
Stokes, Ian
Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation
function for miniflow extract
Hi Kumar,
I plan to review this patch set, but I need to go over the dpif AVX512
set first to get a better understanding.
However, I did run some performance tests
, Harry
; Flavio Leitner ; Stokes, Ian
Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for
miniflow extract
Hi Kumar,
I plan to review this patch set, but I need to go over the dpif AVX512 set
first to get a better understanding.
However, I did run some performanc
Hi Flavio,
Thanks Again replies are inlined.
> > /* Implementations of available extract options. */ static struct
> > dpif_miniflow_extract_impl mfex_impls[] = {
> > + {
> > +.probe = NULL,
> > +.extract_func = dpif_miniflow_extract_autovalidator,
> > +.name =
Hi,
I haven't tested the patch set yet.
I left some comments in line.
On Thu, Jun 17, 2021 at 09:57:44PM +0530, Kumar Amber wrote:
> This patch introduced the auto-validation function which
> allows users to compare the batch of packets obtained from
> different miniflow implementations
Hi Kumar,
I plan to review this patch set, but I need to go over the dpif AVX512
set first to get a better understanding.
However, I did run some performance tests on old hardware (as I do not
have an AVX512 system) and notice some degradation (and improvements).
This was a single run for
> -Original Message-
> From: Ilya Maximets
> Sent: Thursday, June 24, 2021 12:06 PM
> To: Ilya Maximets ; Stokes, Ian ;
> Amber, Kumar ; d...@openvswitch.org; Van Haaren,
> Harry
> Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function
> fo
> -Original Message-
> From: Amber, Kumar
> Sent: Thursday, June 24, 2021 12:27 PM
> To: Stokes, Ian ; d...@openvswitch.org; Van Haaren,
> Harry
>
> Cc: i.maxim...@ovn.org
> Subject: RE: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function
Hi Ian,
Thanks for reviews, replies are inlined.
> > +/* Call optimized miniflow for each batch of packet. */
> > +uint32_t hit_mask = mfex_impls[j].extract_func(packets, test_keys,
> > +keys_size, in_port,
> > + pmd_handle);
>
>
On 6/24/21 12:58 PM, Ilya Maximets wrote:
> On 6/24/21 12:46 PM, Stokes, Ian wrote:
>>> +
>>> +if (!miniflow_equal([i].mf, _keys[i].mf)) {
>>> +uint32_t block_cnt = miniflow_n_values([i].mf);
>>> +VLOG_ERR("Autovalidation blocks failed for %s pkt %d",
On 6/24/21 12:46 PM, Stokes, Ian wrote:
>> +
>> +if (!miniflow_equal([i].mf, _keys[i].mf)) {
>> +uint32_t block_cnt = miniflow_n_values([i].mf);
>> +VLOG_ERR("Autovalidation blocks failed for %s pkt %d",
>> + mfex_impls[j].name,
> This patch introduced the auto-validation function which
> allows users to compare the batch of packets obtained from
> different miniflow implementations against the linear
> miniflow extract and return a hitmask.
>
> The autovaidator function can be triggered at runtime using the
> following
This patch introduced the auto-validation function which
allows users to compare the batch of packets obtained from
different miniflow implementations against the linear
miniflow extract and return a hitmask.
The autovaidator function can be triggered at runtime using the
following command:
$
31 matches
Mail list logo
