> -Original Message-
> From: dev On Behalf Of Amber, Kumar
> Sent: Thursday, July 1, 2021 9:43 AM
> To: Flavio Leitner
> Cc: d...@openvswitch.org; i.maxim...@ovn.org
> Subject: Re: [ovs-dev] [v4 11/12] dpif-netdev/mfex: add more AVX512 traffic
> profiles
>
>
Hi Flavio,
Pls find the replies inline,
> > +mfex_vlan_pcp(const uint8_t vlan_pcp, uint64_t *block) {
> > +/* Bitwise-OR in the CFI flag, keeping other data the same. */
> > +uint8_t *cfi_byte = (uint8_t *) block;
> > +cfi_byte[2] = 0x10 | vlan_pcp;
>
> Trying to reduce the magic
>> ;
>> Stokes, Ian
>> Subject: RE: [ovs-dev] [v4 11/12] dpif-netdev/mfex: add more AVX512 traffic
>> profiles
>>
>> Hi Eelco,
>>
>> Pls find my comments inline.
>
> Snip away all except the "callbacks" topic.
>
>>> NIT: As
Hi,
On Thu, Jun 17, 2021 at 09:57:53PM +0530, Kumar Amber wrote:
> From: Harry van Haaren
>
> This commit adds 3 new traffic profile implementations to the
> existing avx512 miniflow extract infrastructure. The profiles added are:
> - Ether()/IP()/TCP()
> - Ether()/Dot1Q()/IP()/UDP()
> -
> -Original Message-
> From: Amber, Kumar
> Sent: Wednesday, June 30, 2021 4:10 PM
> To: Eelco Chaudron ; Van Haaren, Harry
>
> Cc: d...@openvswitch.org; i.maxim...@ovn.org; Flavio Leitner
> ;
> Stokes, Ian
> Subject: RE: [ovs-dev] [v4 11/12] dpif-netdev/mf
Hi Eelco,
Pls find my comments inline.
> > #define KMASK_ETHER 0x1FFFULL
> > +#define KMASK_DT1Q 0x000FULL
>
> This was messing me up, as this suggests this is a 16-byte mask, but this is
> only 8,
> so maybe we should indicate it by removing the two leading zeros?
>
>#define
On 17 Jun 2021, at 18:27, Kumar Amber wrote:
> From: Harry van Haaren
>
> This commit adds 3 new traffic profile implementations to the
> existing avx512 miniflow extract infrastructure. The profiles added are:
> - Ether()/IP()/TCP()
> - Ether()/Dot1Q()/IP()/UDP()
> -
From: Harry van Haaren
This commit adds 3 new traffic profile implementations to the
existing avx512 miniflow extract infrastructure. The profiles added are:
- Ether()/IP()/TCP()
- Ether()/Dot1Q()/IP()/UDP()
- Ether()/Dot1Q()/IP()/TCP()
The design of the avx512 code here is for scalability to
