Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-07 Thread Van Haaren, Harry
> -Original Message- > From: Stokes, Ian > Sent: Wednesday, July 7, 2021 3:38 PM > To: Eelco Chaudron ; Van Haaren, Harry > ; Amber, Kumar > Cc: Amber, Kumar ; Ferriter, Cian > ; ovs-dev@openvswitch.org; f...@sysclose.org; > i.maxim...@ovn.org > Subject: RE: [v6 00/11] MFEX Infrastructure

Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-07 Thread Stokes, Ian
> On 7 Jul 2021, at 12:13, Van Haaren, Harry wrote: > > > Hi All, > > > > This thread has dissolved into unnecessary time-wasting on nitpick changes. > There is no > > technical issue with uint32_t, so this patch remains as is, and this should > > be > accepted for merge. > > > > If you feel diff

Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-07 Thread Eelco Chaudron
On 7 Jul 2021, at 12:13, Van Haaren, Harry wrote: > Hi All, > > This thread has dissolved into unnecessary time-wasting on nitpick changes. > There is no > technical issue with uint32_t, so this patch remains as is, and this should > be accepted for merge. > > If you feel differently, reply to

Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-07 Thread Van Haaren, Harry
Hi All, This thread has dissolved into unnecessary time-wasting on nitpick changes. There is no technical issue with uint32_t, so this patch remains as is, and this should be accepted for merge. If you feel differently, reply to this with a detailed description of a genuine technical bug. Reg

Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-07 Thread Amber, Kumar
Hi Eelco, I tried with the suggestion “zd” is deprecated and in place of it %"PRIdSIZE`` is mentioned which still causes build failure on non-ssl 32 bit builds. Regards Amber From: Eelco Chaudron Sent: Wednesday, July 7, 2021 3:02 PM To: Van Haaren, Harry Cc: Amber, Kumar ; Ferriter, Cian ;

Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-07 Thread Eelco Chaudron
On 7 Jul 2021, at 11:09, Van Haaren, Harry wrote: -Original Message- From: Eelco Chaudron Sent: Wednesday, July 7, 2021 9:35 AM To: Amber, Kumar Cc: Ferriter, Cian ; ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van Haaren, Harry ; Stokes, Ian Subject: Re: [v6 00

Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-07 Thread Van Haaren, Harry
> -Original Message- > From: Eelco Chaudron > Sent: Wednesday, July 7, 2021 9:35 AM > To: Amber, Kumar > Cc: Ferriter, Cian ; ovs-dev@openvswitch.org; > f...@sysclose.org; i.maxim...@ovn.org; Van Haaren, Harry > ; Stokes, Ian > Subject: Re: [v6 00/11] MFEX Infrastructure + Optimizations

Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-07 Thread Eelco Chaudron
On 6 Jul 2021, at 17:06, Amber, Kumar wrote: > Hi Eelco , > > > Here is the diff vor v6 vs v5 : > > Patch 1 : > > diff --git a/lib/dpif-netdev-private-extract.c > b/lib/dpif-netdev-private-extract.c > index 1aebf3656d..4987d628a4 100644 > --- a/lib/dpif-netdev-private-extract.c > +++ b/lib/dp

Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-06 Thread Amber, Kumar
Hi Eelco , Here is the diff vor v6 vs v5 : Patch 1 : diff --git a/lib/dpif-netdev-private-extract.c b/lib/dpif-netdev-private-extract.c index 1aebf3656d..4987d628a4 100644 --- a/lib/dpif-netdev-private-extract.c +++ b/lib/dpif-netdev-private-extract.c @@ -233,7 +233,7 @@ dpif_miniflow_extrac

Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-06 Thread Amber, Kumar
Hi Eelco, Only 3 lines Changed so nothing much just a build failure was addressed 😊 Regards Amber > -Original Message- > From: Eelco Chaudron > Sent: Tuesday, July 6, 2021 8:04 PM > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van > Haaren, H

Re: [ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-06 Thread Eelco Chaudron
Cian, Which patches change, so I know where to update my review? None of the commit messages show v6 changes. //Eelco On 6 Jul 2021, at 15:11, Cian Ferriter wrote: > v6 updates: > - Fix non-ssl build > v5 updates: > - reabse onto latest DPIF v14 > - use Enum for mfex impls > - add pmd core id

[ovs-dev] [v6 00/11] MFEX Infrastructure + Optimizations

2021-07-06 Thread Cian Ferriter
v6 updates: - Fix non-ssl build v5 updates: - reabse onto latest DPIF v14 - use Enum for mfex impls - add pmd core id set paramter in set command - get command modified to display the pmd thread for individual mfex functions - resolved comments from Eelco, Ian, Flavio - Use Atomic to get and set mi