Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-13 Thread Eelco Chaudron
On 13 Jul 2021, at 5:37, Amber, Kumar wrote: > Hi Eelco, Flavio , > > Pls find my comments Inline. > ACK, replied to in v10 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Amber, Kumar
Hi Eelco, Flavio , Pls find my comments Inline. > > +/* For the first call, this will be choosen based on the > > + * compile time flag and if nor flag is set it is set to > > + * default scalar. > > + */ > > +if (OVS_UNLIKELY(!default_mfex_func_set)) { > > +

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Aaron Conole
Aaron Conole writes: > Ilya Maximets writes: > >> On 7/12/21 5:10 PM, David Marchand wrote: >>> On Mon, Jul 12, 2021 at 4:43 PM Ilya Maximets wrote: >> ovsrobot has issues with reporting the status right now, but this >> patch fails the build in GHA: >>

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Aaron Conole
Ilya Maximets writes: > On 7/12/21 5:10 PM, David Marchand wrote: >> On Mon, Jul 12, 2021 at 4:43 PM Ilya Maximets wrote: > ovsrobot has issues with reporting the status right now, but this > patch fails the build in GHA: > https://github.com/ovsrobot/ovs/actions/runs/1021787643

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Ilya Maximets
On 7/12/21 4:57 PM, Van Haaren, Harry wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Monday, July 12, 2021 3:43 PM >> To: Van Haaren, Harry ; Ilya Maximets >> ; Amber, Kumar ; ovs- >> d...@openvswitch.org >> Cc: f...@sysclose.org; echau...@redhat.com; Ferriter, Cian >> ;

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Ilya Maximets
On 7/12/21 5:10 PM, David Marchand wrote: > On Mon, Jul 12, 2021 at 4:43 PM Ilya Maximets wrote: ovsrobot has issues with reporting the status right now, but this patch fails the build in GHA: https://github.com/ovsrobot/ovs/actions/runs/1021787643 >>> >>> Thanks for linking on

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread David Marchand
On Mon, Jul 12, 2021 at 4:43 PM Ilya Maximets wrote: > >> ovsrobot has issues with reporting the status right now, but this > >> patch fails the build in GHA: > >> https://github.com/ovsrobot/ovs/actions/runs/1021787643 > > > > Thanks for linking on results. > > > > I've spot-checked a bunch of

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Van Haaren, Harry
> -Original Message- > From: Ilya Maximets > Sent: Monday, July 12, 2021 3:43 PM > To: Van Haaren, Harry ; Ilya Maximets > ; Amber, Kumar ; ovs- > d...@openvswitch.org > Cc: f...@sysclose.org; echau...@redhat.com; Ferriter, Cian > ; Stokes, Ian > Subject: Re: [v9 01/12] dpif-netdev: Add

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Ilya Maximets
On 7/12/21 4:02 PM, Van Haaren, Harry wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Monday, July 12, 2021 2:25 PM >> To: Amber, Kumar ; ovs-dev@openvswitch.org >> Cc: f...@sysclose.org; echau...@redhat.com; i.maxim...@ovn.org; Van Haaren, >> Harry ; Ferriter, Cian ; >>

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Van Haaren, Harry
> -Original Message- > From: Ilya Maximets > Sent: Monday, July 12, 2021 2:25 PM > To: Amber, Kumar ; ovs-dev@openvswitch.org > Cc: f...@sysclose.org; echau...@redhat.com; i.maxim...@ovn.org; Van Haaren, > Harry ; Ferriter, Cian ; > Stokes, Ian > Subject: Re: [v9 01/12] dpif-netdev: Add

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Ilya Maximets
On 7/12/21 7:51 AM, kumar Amber wrote: > From: Kumar Amber > > This patch introduces the MFEX function pointers which allows > the user to switch between different miniflow extract implementations > which are provided by the OVS based on optimized ISA CPU. > > The user can query for the

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Flavio Leitner
On Mon, Jul 12, 2021 at 02:22:46PM +0200, Eelco Chaudron wrote: > See some comments below… > > For this patch series, I’m only looking at the diff from v6..v9, not a full > review. > I will do basic compilation and some tests at the end. > > Cheers, > > Eelco > > > On 12 Jul 2021, at 7:51,

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread Eelco Chaudron
See some comments below… For this patch series, I’m only looking at the diff from v6..v9, not a full review. I will do basic compilation and some tests at the end. Cheers, Eelco On 12 Jul 2021, at 7:51, kumar Amber wrote: > From: Kumar Amber > > This patch introduces the MFEX function

Re: [ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread 0-day Robot
Bleep bloop. Greetings kumar Amber, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I

[ovs-dev] [v9 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

2021-07-12 Thread kumar Amber
From: Kumar Amber This patch introduces the MFEX function pointers which allows the user to switch between different miniflow extract implementations which are provided by the OVS based on optimized ISA CPU. The user can query for the available minflow extract variants available for that CPU by