Re: [ovs-dev] Openvswitch patch doubts:conntrack: Fix missed 'conn' lookup checks.

2021-06-29 Thread Ben Pfaff
On Mon, Jun 28, 2021 at 11:45:11AM +0800, user wrote: > I think this situation may not happen, because if there are two pkts > are going to create the same conntrack, their headers will be roughly > the same, the rss of the hardware will assign the packets to the same > cpu, so there is no chance

[ovs-dev] Openvswitch patch doubts:conntrack: Fix missed 'conn' lookup checks.

2021-06-27 Thread user
Hi Ben, I think this situation may not happen, because if there are two pkts are going to create the same conntrack, their headers will be roughly the same, the rss of the hardware will assign the packets to the same cpu, so there is no chance for two threads to try to insert the same

Re: [ovs-dev] Openvswitch patch doubts:conntrack: Fix missed 'conn' lookup checks.

2021-06-25 Thread Ben Pfaff
On Fri, Jun 25, 2021 at 11:36:12AM +0800, user wrote: > Hi Darrell, > I'm currently doing some tests on OVS-DPDK and trying to optimize it, > in the process I found your patch(28274f7 conntrack: Fix missed 'conn' lookup > checks.) made OVS check for the presence of the 'conn' entry before

[ovs-dev] Openvswitch patch doubts:conntrack: Fix missed 'conn' lookup checks.

2021-06-25 Thread user
Hi Darrell, I'm currently doing some tests on OVS-DPDK and trying to optimize it, in the process I found your patch(28274f7 conntrack: Fix missed 'conn' lookup checks.) made OVS check for the presence of the 'conn' entry before inserting it: @@ -1158,8 +1165,11 @@ process_one(struct