Re: [ovs-dev] discussing memory leak in netdev_tc_init_flow_api() and ovs-system behavior

2023-08-10 Thread Roi Dayan via dev
On 10/08/2023 15:26, Ilya Maximets wrote: > On 8/10/23 09:59, Roi Dayan wrote: >> Hi, >> >> We noticed a possible memory leak in netdev_tc_init_flow_api() >> as we allocate memory for meter_police_ids with id_pool_create() >> but we never destroy it. > > Hi, Roi. > > I'd not consider this as a

Re: [ovs-dev] discussing memory leak in netdev_tc_init_flow_api() and ovs-system behavior

2023-08-10 Thread Ilya Maximets
On 8/10/23 09:59, Roi Dayan wrote: > Hi, > > We noticed a possible memory leak in netdev_tc_init_flow_api() > as we allocate memory for meter_police_ids with id_pool_create() > but we never destroy it. Hi, Roi. I'd not consider this as a leak. The pool is allocated once and stored in a static m

[ovs-dev] discussing memory leak in netdev_tc_init_flow_api() and ovs-system behavior

2023-08-10 Thread Roi Dayan via dev
Hi, We noticed a possible memory leak in netdev_tc_init_flow_api() as we allocate memory for meter_police_ids with id_pool_create() but we never destroy it. I added a code to refcount netdev_tc_init_flow_api and so in netdev_tc_uninit_flow_api() to destroy it and noticed some behavior about ovs-s