Re: [ovs-dev] gateway logic question (was: Re: [PATCH v2 1/5] ovsdb-idl: Redesign use of indexes.)

2018-06-13 Thread Han Zhou
I think it may be a corner case, since in most cases we just need one gateway port per logical router. And for my understanding OpenStack doesn't have the API to set more than one gateway ports for a logical router, so at least it should be no issue in that set up. On Tue, Jun 12, 2018 at 9:39 AM,

Re: [ovs-dev] gateway logic question (was: Re: [PATCH v2 1/5] ovsdb-idl: Redesign use of indexes.)

2018-06-12 Thread Guru Shetty
There are 2 types of gateways in OVN - a "gateway router" and a "distributed gateway router port". The latter is where BFD is used and has been mostly been maintained by the OpenStack folks. I am adding the original authors for comment. I am not very familiar with the latter implementation. On 12

[ovs-dev] gateway logic question (was: Re: [PATCH v2 1/5] ovsdb-idl: Redesign use of indexes.)

2018-06-12 Thread Ben Pfaff
Hi Guru, Han raised the following question while reading a patch of mine. Will you give your opinion? On Mon, Jun 11, 2018 at 07:17:13PM -0700, Han Zhou wrote: > > +static struct ovs_list * > > +bfd_find_ha_gateway_chassis( > > +struct ovsdb_idl_index *sbrec_port_binding_by_datapath, > > +