Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

2021-07-15 Thread Ilya Maximets
On 7/15/21 8:31 PM, Dumitru Ceara wrote: > On 7/15/21 7:37 PM, Han Zhou wrote: >> On Thu, Jul 15, 2021 at 9:17 AM Ilya Maximets wrote: >>> >>> On 6/29/21 9:57 PM, Ilya Maximets wrote: >> Regarding the current patch, I think it's better to add a test case to >> cover the scenario and

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

2021-07-15 Thread Dumitru Ceara
On 7/15/21 7:37 PM, Han Zhou wrote: > On Thu, Jul 15, 2021 at 9:17 AM Ilya Maximets wrote: >> >> On 6/29/21 9:57 PM, Ilya Maximets wrote: > Regarding the current patch, I think it's better to add a test case to > cover the scenario and confirm that existing connections didn't > reset.

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

2021-07-15 Thread Han Zhou
On Thu, Jul 15, 2021 at 9:17 AM Ilya Maximets wrote: > > On 6/29/21 9:57 PM, Ilya Maximets wrote: > >>> Regarding the current patch, I think it's better to add a test case to > >>> cover the scenario and confirm that existing connections didn't reset. With > >>> that: > >>> Acked-by: Han Zhou >

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

2021-07-15 Thread Ilya Maximets
On 6/29/21 9:57 PM, Ilya Maximets wrote: >>> Regarding the current patch, I think it's better to add a test case to >>> cover the scenario and confirm that existing connections didn't reset. With >>> that: >>> Acked-by: Han Zhou > > I'll work on a unit test for this. Hi. Here is a unit test

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

2021-06-29 Thread Ben Pfaff
On Tue, Jun 29, 2021 at 09:57:44PM +0200, Ilya Maximets wrote: > For the more or less automatic ways of solving the disbalance there are > few more ideas that we can explore: > > - Try to measure the load on the ovsdb-server process and report it > somehow in the _Server database, so the client

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

2021-06-29 Thread Ilya Maximets
On 6/29/21 8:05 PM, Ben Pfaff wrote: > On Tue, Jun 29, 2021 at 10:29:59AM -0700, Han Zhou wrote: >> On Tue, Jun 29, 2021 at 8:43 AM Ben Pfaff wrote: >>> >>> On Tue, Jun 29, 2021 at 12:56:18PM +0200, Ilya Maximets wrote: If a new database server added to the cluster, or if one of the

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

2021-06-29 Thread Ben Pfaff
On Tue, Jun 29, 2021 at 10:29:59AM -0700, Han Zhou wrote: > On Tue, Jun 29, 2021 at 8:43 AM Ben Pfaff wrote: > > > > On Tue, Jun 29, 2021 at 12:56:18PM +0200, Ilya Maximets wrote: > > > If a new database server added to the cluster, or if one of the > > > database servers changed its IP address

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

2021-06-29 Thread Han Zhou
On Tue, Jun 29, 2021 at 8:43 AM Ben Pfaff wrote: > > On Tue, Jun 29, 2021 at 12:56:18PM +0200, Ilya Maximets wrote: > > If a new database server added to the cluster, or if one of the > > database servers changed its IP address or port, then you need to > > update the list of remotes for the

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

2021-06-29 Thread Ben Pfaff
On Tue, Jun 29, 2021 at 12:56:18PM +0200, Ilya Maximets wrote: > If a new database server added to the cluster, or if one of the > database servers changed its IP address or port, then you need to > update the list of remotes for the client. For example, if a new > OVN_Southbound database server

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

2021-06-29 Thread Dumitru Ceara
On 6/29/21 12:56 PM, Ilya Maximets wrote: > If a new database server added to the cluster, or if one of the > database servers changed its IP address or port, then you need to > update the list of remotes for the client. For example, if a new > OVN_Southbound database server is added, you need to