Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-11 Thread David Marchand
On Wed, Apr 10, 2019 at 4:24 PM Ilya Maximets wrote: > On 10.04.2019 17:10, David Marchand wrote: > > Incorporated this change, and it works fine, I get similar numbers > with/without a bitmap, so I dropped the bitmap. > > I would say we are only missing some information in > dpif-netdev/pmd-rxq-

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-10 Thread Jan Scheurich
> > > > I am afraid it is not a valid assumption that there will be similarly large > number of OVS PMD threads as there are queues. > > > > In OpenStack deployments the OVS is typically statically configured to use a > few dedicated host CPUs for PMDs (perhaps 2-8). > > > > Typical Telco VNF VMs,

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-10 Thread Ilya Maximets
On 10.04.2019 17:10, David Marchand wrote: > On Wed, Apr 10, 2019 at 9:32 AM David Marchand > wrote: > > On Tue, Apr 9, 2019 at 1:42 PM Ilya Maximets > wrote: > > > What do you think about something like this (not eve

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-10 Thread David Marchand
On Wed, Apr 10, 2019 at 9:32 AM David Marchand wrote: > On Tue, Apr 9, 2019 at 1:42 PM Ilya Maximets > wrote: > >> >> What do you think about something like this (not even compile tested): >> --- >> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c >> index bd9718824..0cf492a3b 100644 >> --- a/

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-10 Thread Ilya Maximets
On 10.04.2019 16:12, Jan Scheurich wrote: > Hi Ilya, > >>> >>> With a simple pvp setup of mine. >>> 1c/2t poll two physical ports. >>> 1c/2t poll four vhost ports with 16 queues each. >>>   Only one queue is enabled on each virtio device attached by the guest. >>>   The first two virtio devices ar

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-10 Thread Jan Scheurich
Hi Ilya, > > > > With a simple pvp setup of mine. > > 1c/2t poll two physical ports. > > 1c/2t poll four vhost ports with 16 queues each. > >   Only one queue is enabled on each virtio device attached by the guest. > >   The first two virtio devices are bound to the virtio kmod. > >   The last two

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-10 Thread Ilya Maximets
On 09.04.2019 17:49, Kevin Traynor wrote: > On 09/04/2019 12:41, Ilya Maximets wrote: >> On 09.04.2019 11:34, Ilya Maximets wrote: >>> On 08.04.2019 16:44, David Marchand wrote: Hello Ilya, On Mon, Apr 8, 2019 at 10:27 AM Ilya Maximets >>> > wrote:

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-10 Thread David Marchand
Hello Ilya, On Tue, Apr 9, 2019 at 1:42 PM Ilya Maximets wrote: > > What do you think about something like this (not even compile tested): > --- > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c > index bd9718824..0cf492a3b 100644 > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -591,

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-09 Thread Kevin Traynor
On 09/04/2019 12:41, Ilya Maximets wrote: > On 09.04.2019 11:34, Ilya Maximets wrote: >> On 08.04.2019 16:44, David Marchand wrote: >>> Hello Ilya, >>> >>> On Mon, Apr 8, 2019 at 10:27 AM Ilya Maximets >> > wrote: >>> >>> On 04.04.2019 22:49, David Marchand wrote:

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-09 Thread Ilya Maximets
On 09.04.2019 11:34, Ilya Maximets wrote: > On 08.04.2019 16:44, David Marchand wrote: >> Hello Ilya, >> >> On Mon, Apr 8, 2019 at 10:27 AM Ilya Maximets > > wrote: >> >> On 04.04.2019 22:49, David Marchand wrote: >> > We tried to lower the number of rebalance

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-09 Thread Ilya Maximets
On 08.04.2019 16:44, David Marchand wrote: > Hello Ilya, > > On Mon, Apr 8, 2019 at 10:27 AM Ilya Maximets > wrote: > > On 04.04.2019 22:49, David Marchand wrote: > > We tried to lower the number of rebalances but we don't have a > > satisfying solution

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-08 Thread David Marchand
Hello Ilya, On Mon, Apr 8, 2019 at 10:27 AM Ilya Maximets wrote: > On 04.04.2019 22:49, David Marchand wrote: > > We tried to lower the number of rebalances but we don't have a > > satisfying solution at the moment, so this patch rebalances on each > > update. > > Hi. > > Triggering the reconfig

Re: [ovs-dev] [RFC] dpif-netdev: only poll enabled vhost queues

2019-04-08 Thread Ilya Maximets
On 04.04.2019 22:49, David Marchand wrote: > We currently poll all available queues based on the max queue count > exchanged with the vhost peer and rely on the vhost library in DPDK to > check the vring status beneath. > This can lead to some overhead when we have a lot of unused queues. > This si