Fixing the issue of incorrect outer UDP checksum in packets sent by E810.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Reported-at: https://github.com/openvswitch/ovs-issues/issues/321
Signed-off-by: Jun Wang
---
lib/netdev-dpdk.c | 6 ++
1 file changed, 6 insertions(+)
Bleep bloop. Greetings Jun Wang, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Jun Wang needs to sign off.
Lines checked: 36, Warnings: 0, Errors: 1
Please check
Fixing the issue of incorrect outer UDP checksum in packets sent by E810.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Reported-at: https://github.com/openvswitch/ovs-issues/issues/321
Signed-ff-by: Jun Wang
---
lib/netdev-dpdk.c | 6 ++
1 file changed, 6 insertions(+)
Great! You're welcome!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Mar 18, 2024 at 11:27 AM Mark Michelson wrote:
>
> Hi Han,
>
> I have a comment below
>
> On 3/5/24 01:27, Han Zhou wrote:
> > The ovn-ofctrl-wait-before-clear setting is designed to minimize
> > downtime during the initial start-up of the ovn-controller. For this
> > purpose, the
On 3/20/24 19:47, Ilya Maximets wrote:
> Currently, ovs-vswitchd is subscribed to all the routing changes in the
> kernel. On each change, it marks the internal routing table cache as
> invalid, then resets it and dumps all the routes from the kernel from
> scratch. The reason for that is kernel
On 2/21/24 19:06, Mike Pattrick wrote:
> This patch adopts the proposed RFC 6935 by allowing null UDP checksums
> even if the tunnel protocol is IPv6. This is already supported by Linux
> through the udp6zerocsumtx tunnel option. It is disabled by default and
> IPv6 tunnels are flagged as
Thanks Ales, looks good to me.
Acked-by: Mark Michelson
On 3/19/24 11:57, Ales Musil wrote:
The memory usage would be increased for size of sb_addrset_ref
struct, but decreased for the size of the struct + the name.
That would slowly lead to underflows in some cases.
Reported-at:
On 3/20/24 06:23, Ales Musil wrote:
On Wed, Mar 13, 2024 at 5:40 PM Martin Kalcok
wrote:
Couple places in the documentation reference "--wait" and "--no-wait"
options for "ovn-sbctl" but it doesn't support these options [0].
Trying, for example, "ovn-sbctl --no-wait init" exits with:
Hi Ales, thanks for providing this patch. However, branch-22.03 is now
in maintenance mode. It only is receiving patches for security issues
and other high-severity issues. I'm not planning to merge this, but if
there is a good reason that we should, I'm willing to hear it.
On 3/20/24 06:13,
Thanks Ales, I pushed this and patch 2 to branch-23.09.
On 3/20/24 06:16, Ales Musil wrote:
The way how tcpdump was called in tests was inconsistent,
a lot fo the tests didn't even wait for the tcpdump to properly
start, some of them didn't redirect the stderr which could cause
leak into the
Thanks Ales, I pushed this and patch 2 to branch-23.06.
On 3/20/24 06:59, Ales Musil wrote:
The way how tcpdump was called in tests was inconsistent,
a lot fo the tests didn't even wait for the tcpdump to properly
start, some of them didn't redirect the stderr which could cause
leak into the
On 3/20/24 19:05, Mike Pattrick wrote:
> In v4.0, LibreSwan changed a default paths that had been hardcoded in
> ovs-monitor-ipsec, breaking some uses of this script. This patch adds
> support for both old and newer versions by auto detecting the version
> of LibreSwan and then choosing the
On 3/20/24 19:48, Mike Pattrick wrote:
> On Wed, Mar 20, 2024 at 2:05 PM Mike Pattrick wrote:
>>
>> In v4.0, LibreSwan changed a default paths that had been hardcoded in
>> ovs-monitor-ipsec, breaking some uses of this script. This patch adds
>> support for both old and newer versions by auto
On Wed, Mar 20, 2024 at 2:05 PM Mike Pattrick wrote:
>
> In v4.0, LibreSwan changed a default paths that had been hardcoded in
> ovs-monitor-ipsec, breaking some uses of this script. This patch adds
> support for both old and newer versions by auto detecting the version
> of LibreSwan and then
Currently, ovs-vswitchd is subscribed to all the routing changes in the
kernel. On each change, it marks the internal routing table cache as
invalid, then resets it and dumps all the routes from the kernel from
scratch. The reason for that is kernel routing updates not being
reliable in a sense
I pushed this change to main and all branches back to 23.06.
On 3/18/24 13:14, Mark Michelson wrote:
Thanks for finding and fixing this!
Acked-by: Mark Michelson
On 3/4/24 23:54, Igor Zhukov wrote:
I found the broken link at
https://docs.ovn.org/en/latest/internals/release-process.html.
I
In v4.0, LibreSwan changed a default paths that had been hardcoded in
ovs-monitor-ipsec, breaking some uses of this script. This patch adds
support for both old and newer versions by auto detecting the version
of LibreSwan and then choosing the correct path.
Reported-at:
On Wed, Mar 20, 2024 at 2:56 AM Dumitru Ceara wrote:
>
> On 3/20/24 06:41, Han Zhou wrote:
> > ovn-controller runs at 100% cpu when OVS exits. This is because the
> > ofctrl_run is not called while ofctrl_wait is always called in the main
> > loop. Because of the missing ofctrl_run, it doesn't
On 3/19/24 10:44, Dumitru Ceara wrote:
> Hi all,
>
> The next OVN technical community meeting is scheduled to happen today,
> at 4PM UTC.
>
> Feel free to add topics you might want to discuss today to the agenda
> doc below. I added the ones saw being mentioned in other settings (IRC
> meeting)
References: <20240320143958.39052-4-naveen.yerramn...@nutanix.com>
Bleep bloop. Greetings Naveen Yerramneni, I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is
Ilya Maximets writes:
> On 3/19/24 20:56, Aaron Conole wrote:
>> Ilya Maximets writes:
>>
>>> Currently, ovs-vswitchd is subscribed to all the routing changes in the
>>> kernel. On each change, it marks the internal routing table cache as
>>> invalid, then resets it and dumps all the routes
Added tests for DHCP Relay feature.
Signed-off-by: Naveen Yerramneni
---
tests/atlocal.in| 3 +
tests/ovn-northd.at | 38 +++
tests/ovn.at| 256
tests/system-ovn.at | 148 +
4 files changed, 445
NB SCHEMA CHANGES
-
1. New DHCP_Relay table
"DHCP_Relay": {
"columns": {
"name": {"type": "string"},
"servers": {"type": {"key": "string",
"min": 0,
Added changes in pinctrl to process DHCP Relay opcodes:
- ACTION_OPCODE_DHCP_RELAY_REQ_CHK: For request packets
- ACTION_OPCODE_DHCP_RELAY_RESP_CHK: For response packet
Signed-off-by: Naveen Yerramneni
---
controller/pinctrl.c | 596 ++-
lib/ovn-l7.h
NEW OVN ACTIONS
---
1. dhcp_relay_req_chk(, )
- This action executes on the source node on which the DHCP request
originated.
- This action relays the DHCP request coming from client to the server.
Relay-ip is used to update GIADDR in the DHCP header.
2.
This patch contains changes to enable DHCP Relay Agent support for overlay
subnets.
USE CASE:
--
- Enable IP address assignment for overlay subnets from the centralized
DHCP server present in the underlay network.
PREREQUISITES
--
- Logical
On Tue, Mar 19, 2024 at 5:35 PM Ilya Maximets wrote:
>
> On 3/13/24 22:54, Mike Pattrick wrote:
> > In v4.0, LibreSwan changed a default paths that had been hardcoded in
> > ovs-monitor-ipsec, breaking some uses of this script. This patch adds
> > support for both old and newer versions by auto
On 3/19/24 20:56, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> Currently, ovs-vswitchd is subscribed to all the routing changes in the
>> kernel. On each change, it marks the internal routing table cache as
>> invalid, then resets it and dumps all the routes from the kernel from
>> scratch.
On 3/20/24 03:23, Jun Wang wrote:
> Signed-off-by: Jun Wang
Hi. Thanks for the patch!
Could you, please, add some information about the issue to the
commit message?
Following tags will also be appropriate to have:
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Reported-at:
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers:
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers:
Hi
Thanks Ales for the feedback.
There is also a small change needed to make userspace tests to work as well
(as pointed out by ovs_robot).
I'll send a v2.
Thanks
Xavier
On Wed, Mar 20, 2024 at 12:11 PM Ales Musil wrote:
>
>
> On Wed, Mar 20, 2024 at 8:12 AM Xavier Simonart
> wrote:
>
>>
On Thu, Mar 14, 2024 at 2:13 PM Martin Kalcok
wrote:
> Hello all,
> I have one more follow-up regarding the comments in v1. @amusil, you were
> concerned about the impact this change would have on the performance so I
> ran some tests to try to gauge it. I used following setup with two physical
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers:
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers:
On Tue, Mar 12, 2024 at 9:18 PM Martin Kalcok
wrote:
Hi Martin,
sorry for the late reply.
Following up on the comments from v1.
>
> @amusil You were right that the struct in actions.h was not necessary
> then. However I also noticed that I forgot to modify `format_CT_COMMIT_V1`
> function and
On Wed, Mar 20, 2024 at 8:12 AM Xavier Simonart wrote:
> This issue is happening for instance when running test
> "ovn-controller - Chassis other_config".
>
> Signed-off-by: Xavier Simonart
> ---
> controller/pinctrl.c | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
>
On Wed, Mar 20, 2024 at 8:12 AM Xavier Simonart wrote:
> Pinctrl is responsible of creating MAC_Bindings on peer router datapaths.
> However, when sb was read-only, this did not happen.
> This caused the test "neighbor update on same HV" to fail in a flaky way.
>
> Signed-off-by: Xavier Simonart
The way how tcpdump was called in tests was inconsistent,
a lot fo the tests didn't even wait for the tcpdump to properly
start, some of them didn't redirect the stderr which could cause
leak into the test stderr and fail the test.
To prevent that add macro that starts tcpdump and properly
waits
Fedora received an update of netcat to version 7.94, this version
brings ability for UDP to accept multiple connections without closing
(-k/--keep-open) [0]. That had negative impact on the tests as the UDP
netcat server was closing sooner that expected.
Make sure that the server is alive when we
On Wed, Mar 13, 2024 at 5:40 PM Martin Kalcok
wrote:
> Couple places in the documentation reference "--wait" and "--no-wait"
> options for "ovn-sbctl" but it doesn't support these options [0].
>
> Trying, for example, "ovn-sbctl --no-wait init" exits with:
>
> ovn-sbctl: --no-wait not supported
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or committers:
Fedora received an update of netcat to version 7.94, this version
brings ability for UDP to accept multiple connections without closing
(-k/--keep-open) [0]. That had negative impact on the tests as the UDP
netcat server was closing sooner that expected.
Make sure that the server is alive when we
The way how tcpdump was called in tests was inconsistent,
a lot fo the tests didn't even wait for the tcpdump to properly
start, some of them didn't redirect the stderr which could cause
leak into the test stderr and fail the test.
To prevent that add macro that starts tcpdump and properly
waits
The way how tcpdump was called in tests was inconsistent,
a lot fo the tests didn't even wait for the tcpdump to properly
start, some of them didn't redirect the stderr which could cause
leak into the test stderr and fail the test.
To prevent that add macro that starts tcpdump and properly
waits
On 3/20/24 06:41, Han Zhou wrote:
> ovn-controller runs at 100% cpu when OVS exits. This is because the
> ofctrl_run is not called while ofctrl_wait is always called in the main
> loop. Because of the missing ofctrl_run, it doesn't even detect that the
> ofctrl connection is disconnected.
>
>
On 19.03.24 16:41, Eelco Chaudron wrote:
>
> On 19 Mar 2024, at 16:19, Ilya Maximets wrote:
>
>> On 3/19/24 15:54, Eelco Chaudron wrote:
>>>
>>> On 19 Mar 2024, at 15:46, Ilya Maximets wrote:
>>>
On 3/19/24 15:17, Eelco Chaudron wrote:
>
> On 19 Mar 2024, at 15:00, Ilya Maximets
Pinctrl is responsible of creating MAC_Bindings on peer router datapaths.
However, when sb was read-only, this did not happen.
This caused the test "neighbor update on same HV" to fail in a flaky way.
Signed-off-by: Xavier Simonart
---
controller/pinctrl.c | 2 +-
tests/ovn-macros.at | 10
This issue is happening for instance when running test
"ovn-controller - Chassis other_config".
Signed-off-by: Xavier Simonart
---
controller/pinctrl.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/controller/pinctrl.c b/controller/pinctrl.c
index
On Tue, Mar 19, 2024 at 6:03 PM Ilya Maximets wrote:
> On 3/19/24 17:43, Ales Musil wrote:
> > Instead of tracking address set per struct expr_constant_set track it
> > per individual struct expr_constant. This allows more fine grained
> > control for I-P processing of address sets in
51 matches
Mail list logo
