[ovs-dev] [PATCH RFC] route-table: Add support for v4 via v6 route.

2024-04-26 Thread William Tu via dev
Add route-table that support ipv4 dst via ipv6. BGP unnumbered is mechanism that allows BGP to establish peering sessions without the need to explicitly configure IP addresses on the interfaces involved in the peering. Without using IP address assignments, it uses link-local IPv6 addresses of the

[ovs-dev] [PATCH] socket: Don't fail when AF_UNIX connect() returns EAGAIN.

2024-04-26 Thread Ihar Hrachyshka
POSIX defines EINPROGRESS as the return value for non-blocking connect() [1]. But in Linux, AF_UNIX connect() returns EAGAIN instead of EINPROGRESS. (but only for AF_UNIX sockets!) [2] Both cases should be handled the same way - by returning the `fd` and letting the caller to complete connection

[ovs-dev] [PATCH ovn] docs: List supported rolling upgrade paths.

2024-04-26 Thread Ihar Hrachyshka
The wording above is not completely clear without these scenarios listed. A confused reader may incorrectly read it as: ``` Only LTS-to-LTS is supported for rolling upgrades. ``` which is wrong. Signed-off-by: Ihar Hrachyshka --- Documentation/intro/install/ovn-upgrades.rst | 5 + 1 file

[ovs-dev] [PATCH ovn] docs: Explain nature of ovs dependency.

2024-04-26 Thread Ihar Hrachyshka
The dependency is during build time, not runtime. Signed-off-by: Ihar Hrachyshka --- Documentation/intro/install/ovn-upgrades.rst | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/Documentation/intro/install/ovn-upgrades.rst

Re: [ovs-dev] [PATCH ovn v3] northd: Add support for disabling vxlan mode.

2024-04-26 Thread Ihar Hrachyshka
Hi Vladislav, This looks good to me. I think documentation should be adjusted to not explain in detail ID allocations for VXLAN in two separate places. Assuming the documentation is de-duplicated and typos Dumitru spotted are addressed, Acked-by: Ihar Hrachyshka On Thu, Apr 4, 2024 at 2:41 PM

Re: [ovs-dev] [PATCH ovn] lflow: Add missing sample flow.

2024-04-26 Thread Mark Michelson
Thank you for this Xavier, I have one minor suggestion below. It can be fixed when this is merged. Acked-by: Mark Michelson On 4/26/24 06:52, Xavier Simonart wrote: If lflow inode had to be recomputed (e.g. due to non_vif_data change), then there could be some missing sample actions. This

Re: [ovs-dev] [PATCH ovn v7 0/6] Correct tunnel ids exhaustion scenario.

2024-04-26 Thread Mark Michelson
Thanks for the update, Ihar. For the series, Acked-by: Mark Michelson On 4/26/24 13:54, Ihar Hrachyshka wrote: v2+ of the original test patch exposed a ubsan failure in port tunnel id allocation code when tunnel id space is exhausted. This series fixes the ubsan failure (patches 1-2); then

[ovs-dev] [PATCH ovn v7 6/6] northd: Remove unused nbrp arg in ls_port_reinit.

2024-04-26 Thread Ihar Hrachyshka
It's always NULL. Signed-off-by: Ihar Hrachyshka --- northd/northd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index 2fef95f38..5e12fd1e8 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -4364,7 +4364,6 @@

[ovs-dev] [PATCH ovn v7 5/6] northd: Remove unused `sb` arg in ls_port_create.

2024-04-26 Thread Ihar Hrachyshka
It's always NULL. Signed-off-by: Ihar Hrachyshka --- northd/northd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index 934c22dac..2fef95f38 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -4342,7 +4342,7 @@

[ovs-dev] [PATCH ovn v7 4/6] northd: Don't create pb in ls_port_init too early.

2024-04-26 Thread Ihar Hrachyshka
This allows callers to avoid cleanup of the record in case the function fails. Signed-off-by: Ihar Hrachyshka --- northd/northd.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index 4800a44bd..934c22dac 100644

[ovs-dev] [PATCH ovn v7 1/6] northd: Don't cleanup op in ovn_port_allocate_key.

2024-04-26 Thread Ihar Hrachyshka
Let the callers do the cleanup as needed. Signed-off-by: Ihar Hrachyshka --- northd/northd.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index b541e8455..3bdd0648c 100644 --- a/northd/northd.c +++

[ovs-dev] [PATCH ovn v7 3/6] tests: Correct tunnel ids exhaustion scenario.

2024-04-26 Thread Ihar Hrachyshka
The original version of the scenario passed with or without the fix. This is because all LSs were processed in one go, so the allocate function was never entered with *hint==0. Also, added another scenario that will check behavior when *hint is out of [min;max] bounds but > max (this happens in

[ovs-dev] [PATCH ovn v7 2/6] northd: Don't detach op->list when it wasn't used.

2024-04-26 Thread Ihar Hrachyshka
In some scenarios, op->list is not attached anywhere, which makes attempts to detach it trigger ubsan failure. ovn/ovs/include/openvswitch/list.h:252:17: runtime error: member access within null pointer of type 'struct ovs_list' #0 0x?? in ovs_list_remove

[ovs-dev] [PATCH ovn v7 0/6] Correct tunnel ids exhaustion scenario.

2024-04-26 Thread Ihar Hrachyshka
v2+ of the original test patch exposed a ubsan failure in port tunnel id allocation code when tunnel id space is exhausted. This series fixes the ubsan failure (patches 1-2); then adjusts the invalid scenario to trigger the originally intended failure mode - id space exhausted (patch 3). Finally,

[ovs-dev] [PATCH] tc: Fix -Wgnu-variable-sized-type-not-at-end warning with Clang 18.

2024-04-26 Thread Ilya Maximets
Clang 18.1.3-2.fc41 throws a warning: lib/tc.c:3060:25: error: field 'sel' with variable sized type 'struct tc_pedit_sel' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end] 3060 | struct tc_pedit sel;

Re: [ovs-dev] [PATCH ovn v6 4/6] northd: Delete pb if tunnel is not allocated.

2024-04-26 Thread Ihar Hrachyshka
On Tue, Apr 23, 2024 at 4:59 PM Mark Michelson wrote: > On 4/11/24 21:57, Ihar Hrachyshka wrote: > > This allows callers to avoid cleanup of the record in case the function > > fails. > > > > Signed-off-by: Ihar Hrachyshka > > --- > > northd/northd.c | 10 +- > > 1 file changed, 5

Re: [ovs-dev] [PATCH] tests: Fix build failure with Clang 18 due to -Wformat-truncation.

2024-04-26 Thread Ilya Maximets
On 4/26/24 18:35, Ilya Maximets wrote: > Cirrus CI is broken on FreeBSD 13.3 due to clang version update. > It now complains about snprintf truncation the same way GCC does: > > tests/test-util.c:1129:16: error: 'snprintf' will always be truncated; > specified size is 5, but format

[ovs-dev] [PATCH v3] docs: Document manual cluster recovery procedure.

2024-04-26 Thread Ihar Hrachyshka
Remove the notion of cluster/leave --force since it was never implemented. Instead of these instructions, document how a broken cluster can be re-initialized with the old database contents. Signed-off-by: Ihar Hrachyshka --- v1: initial version. v2: remove --force mentioned in ovsdb-server(1).

[ovs-dev] [PATCH] tests: Fix build failure with Clang 18 due to -Wformat-truncation.

2024-04-26 Thread Ilya Maximets
Cirrus CI is broken on FreeBSD 13.3 due to clang version update. It now complains about snprintf truncation the same way GCC does: tests/test-util.c:1129:16: error: 'snprintf' will always be truncated; specified size is 5, but format string expands to at least 6

[ovs-dev] [PATCH ovn] lflow: Add missing sample flow.

2024-04-26 Thread Xavier Simonart
If lflow inode had to be recomputed (e.g. due to non_vif_data change), then there could be some missing sample actions. This issue was highlighted by some flaky failures of test "Check default openflow flows". The test "Check default openflow flows" has been updated to create a race-condition

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-26 Thread Simon Horman
On Fri, Apr 26, 2024 at 09:59:50AM +0100, Simon Horman wrote: > On Thu, Apr 25, 2024 at 11:52:55AM +0100, Kevin Traynor wrote: > > On 22/04/2024 13:37, Paolo Valerio wrote: > > > When no parameters other than the datapath are specified a segfault > > > occurs. > > > > > > Fix it by checking the

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Improve error print to the user for flow control error.

2024-04-26 Thread Simon Horman
On Wed, Apr 17, 2024 at 10:54:14AM +0300, Roi Dayan wrote: > When failing to get flow control parameters use VLOG_WARN_BUF() > to expose the error string in ovs-vsctl show. > > Signed-off-by: Roi Dayan > Suggested-by: Simon Horman > Acked-by: Eli Britstein Thanks Roi, Applied to main. -

Re: [ovs-dev] [PATCH] dpctl: fix segfault on ct-{set,del}-limits

2024-04-26 Thread Simon Horman
On Thu, Apr 25, 2024 at 11:52:55AM +0100, Kevin Traynor wrote: > On 22/04/2024 13:37, Paolo Valerio wrote: > > When no parameters other than the datapath are specified a segfault > > occurs. > > > > Fix it by checking the argument access is inside the bounds. > > > > Signed-off-by: Paolo Valerio

Re: [ovs-dev] [PATCH] GitHub: Add Coverity scan as a daily GitHub action.

2024-04-26 Thread Simon Horman
On Tue, Apr 16, 2024 at 09:44:52AM +0200, Eelco Chaudron wrote: > This patch adds a daily Coverity run for the OVS main branch > to the GitHub actions. The result of the runs can be found here: > > https://scan.coverity.com/projects/openvswitch > > Before applying, we need to add the following

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-26 Thread Simon Horman
On Thu, Apr 25, 2024 at 12:21:51PM -0700, Jakub Kicinski wrote: > On Thu, 25 Apr 2024 19:57:19 +0100 Simon Horman wrote: > > openvswitch.sh does not appear to have any dependencies on Open vSwitch > > user-space. My understanding is that, rather, it makes use of > >