[ovs-dev] [PATCH v3 2/6] selinux: create a transition type for module loading

2018-06-01 Thread Aaron Conole
exec_t' transition context. A future commit will instruct the selinux policy on how to label the appropriate script with extended attributes to make use of this new domain. Acked-By: Timothy Redaelli Signed-off-by: Aaron Conole --- selinux/openvswitch-custom.te.in | 83 +

[ovs-dev] [PATCH v3 0/6] selinux: introduce a transition domain for loading kmods

2018-06-01 Thread Aaron Conole
he selinux-policy module version * Added changes to the centos build in 4/4 to match the fedora build * Fixed the manpage in 1/5 Aaron Conole (6): ovs-kmod-ctl: introduce a kernel module load script selinux: create a transition type for module loading selinux: allow openvswitch_t net_broadca

[ovs-dev] [PATCH v3 3/6] selinux: allow openvswitch_t net_broadcast and net_raw

2018-06-01 Thread Aaron Conole
bility=11 scontext=system_u:system_r:openvswitch_t:s0 tcontext=system_u:system_r:openvswitch_t:s0 tclass=capability permissive=0 Signed-off-by: Aaron Conole --- selinux/openvswitch-custom.te.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/selinux/openvswitch-custom.te.in b

[ovs-dev] [PATCH v3 1/6] ovs-kmod-ctl: introduce a kernel module load script

2018-06-01 Thread Aaron Conole
utility 'ovs-kmod-ctl' will be used in an upcoming commit for RHEL-based distributions to have a separate transition domain that will allow module loading to be given to a separate selinux domain from the openvswitch_t domain. Acked-By: Timothy Redaelli Signed-off-by: Aaron Conole -

[ovs-dev] [PATCH v3 4/6] selinux: tag the custom policy version

2018-06-01 Thread Aaron Conole
Since the policy is an intermediate file, it can inherit the policy module version from release version. Also include an SPDX identifier. Suggested-by: Ansis Atteka Acked-by: Ansis Atteka Signed-off-by: Aaron Conole --- selinux/openvswitch-custom.te.in | 4 +++- 1 file changed, 3 insertions

[ovs-dev] [PATCH v3 6/6] rhel: selinux-policy to invoke proper label macros

2018-06-01 Thread Aaron Conole
fined in the .fc.in file are applied properly. Acked-by: Ansis Atteka Acked-By: Timothy Redaelli Signed-off-by: Aaron Conole --- rhel/openvswitch-fedora.spec.in | 10 -- rhel/openvswitch.spec.in| 10 -- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a

[ovs-dev] [PATCH v3 5/6] selinux: introduce domain transitioned kmod helper

2018-06-01 Thread Aaron Conole
labelled. This merely instructs the selinux tools that ovs-kmod-ctl should have a label applied. Acked-by: Ansis Atteka Acked-By: Timothy Redaelli Signed-off-by: Aaron Conole --- selinux/.gitignore | 4 selinux/automake.mk | 3 ++- selinux/openvswitch-custom.fc.in

Re: [ovs-dev] OVS-DPDK public meeting

2018-06-05 Thread Aaron Conole
Hi Christian, Christian Ehrhardt writes: > On Tue, Jun 5, 2018 at 3:28 PM, Stokes, Ian wrote: >> > On Wed, May 30, 2018 at 7:49 PM, Kevin Traynor >> > wrote: >> > >> > > Minutes of meeting Wed 30th May. >> > > >> > > [...] >> > > >> > >> > >> > > - DPDK 18.05 >> > > -- Will be released today/t

Re: [ovs-dev] [PATCH v3 1/6] ovs-kmod-ctl: introduce a kernel module load script

2018-06-06 Thread Aaron Conole
Aaron Conole writes: > Currently, Open vSwitch on linux embeds the logic of loading and unloading > kernel modules into the ovs-ctl and ovs-lib script files. This works, but > it means that there is no way to leverage extended filesystem attributes > to grant fine grain permissions

Re: [ovs-dev] [PATCH v3 1/6] ovs-kmod-ctl: introduce a kernel module load script

2018-06-06 Thread Aaron Conole
Ansis Atteka writes: > On Wed, Jun 6, 2018, 7:31 AM Aaron Conole wrote: > > Aaron Conole writes: > > > Currently, Open vSwitch on linux embeds the logic of loading and unloading > > kernel modules into the ovs-ctl and ovs-lib script files. This works, but > >

Re: [ovs-dev] [PATCH v4] Upcall/Slowpath rate-limiter for OVS

2018-06-07 Thread Aaron Conole
Manohar Krishnappa Chidambaraswamy writes: > Jan, > > Have addressed your comments/suggestions. Please take a look and let me > know if you have any more comments. > > Signed-off-by: Manohar K C > > CC: Jan Scheurich > --- Hi Jan, and Manohar, Have you considered making this token bucket per-

Re: [ovs-dev] [PATCH v4] Upcall/Slowpath rate-limiter for OVS

2018-06-12 Thread Aaron Conole
Manohar Krishnappa Chidambaraswamy writes: > How are you stress testing this? Is there some framework you're using? > [manu] Since the number/rate of new flows coming in depends on the > deployment (expected traffic pattern), upcall ratelimit parameters > need to be tuned for a given deploym

Re: [ovs-dev] [PATCH v4] Upcall/Slowpath rate-limiter for OVS

2018-06-12 Thread Aaron Conole
Jan Scheurich writes: >> Have you considered making this token bucket per-port instead of >> per-pmd? As I read it, a greedy port can exhaust all the tokens from a >> particular PMD, possibly leading to an unfair performance for that PMD >> thread. Am I just being overly paranoi

Re: [ovs-dev] [PATCH] rhel: Add python-netifaces as a dependency for openvswitch-test

2018-06-12 Thread Aaron Conole
Timothy Redaelli writes: > Currently python-netifaces is needed for ovs-tcpdump that is installed > by openvswitch-test package. > > This commit adds {python,python2}-netifaces as a dependency for the > openvswitch-test package. > > Signed-off-by: Timothy Redaelli > ---

[ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-13 Thread Aaron Conole
it to 18 bytes (as a precaution against a signed value, which again would never happen). Signed-off-by: Aaron Conole --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 2e2f568b8..e75943bb2 100644 --- a/lib/netdev-dpd

[ovs-dev] [PATCH 1/2] lldp: fix string warnings

2018-06-13 Thread Aaron Conole
quot;, ", 2); ^~~~ Closer inspection shows that buffer is only used to output protocol names when debug logging is enabled, so restructure the code a bit as well. Signed-off-by: Aaron Conole --- lib/lldp/lldpd.c | 40 +++- 1 file changed, 19 i

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-14 Thread Aaron Conole
Ben Pfaff writes: > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: >> lib/netdev-dpdk.c: In function : >> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the last >> format character [-Wformat-truncation=] >> snprintf(vhos

Re: [ovs-dev] [PATCH 1/2] lldp: fix string warnings

2018-06-14 Thread Aaron Conole
Ben Pfaff writes: > On Wed, Jun 13, 2018 at 03:43:03PM -0400, Aaron Conole wrote: >> lib/lldp/lldpd.c: In function : >> lib/lldp/lldpd.c:520:17: warning: output truncated before >> terminating nul copying as many bytes from a string as its length >

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-14 Thread Aaron Conole
Ben Pfaff writes: > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: >> lib/netdev-dpdk.c: In function : >> lib/netdev-dpdk.c:2865:49: warning: output may be truncated before the last >> format character [-Wformat-truncation=] >> snprintf(vhos

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: fix snprintf call

2018-06-14 Thread Aaron Conole
Ben Pfaff writes: > On Thu, Jun 14, 2018 at 05:11:39PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Wed, Jun 13, 2018 at 03:43:04PM -0400, Aaron Conole wrote: >> >> lib/netdev-dpdk.c: In function : >> >> lib/netdev-dpdk.c:2865:

[ovs-dev] [PATCH v2] netdev-dpdk: fix snprintf call

2018-06-15 Thread Aaron Conole
bits, the largest value ever would only be 17 bytes, including the terminating nul. Stretch it to 18 bytes (as a precaution against a signed value, which again would never happen). Suggested-by: Ben Pfaff Signed-off-by: Aaron Conole --- lib/netdev-dpdk.c | 5 ++--- 1 file changed, 2 insertions(+), 3

Re: [ovs-dev] Automated robotic reply. Re: ...

2018-06-19 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Vishal Deep Ajmera, I am a robot and I have tried out > your patch > with message ID > <1529202111-20855-1-git-send-email-vishal.deep.ajm...@ericsson.com> > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See th

[ovs-dev] [ANNOUNCE] SkyNet (aka the 0-day Robot)

2018-06-19 Thread Aaron Conole
Greetings list, I've set up a robot that pulls series information from patchwork, and runs a jenkins task that does a few basic sanity checks on the patch, and emails the mailing list if it detects things are incorrect. The robot will send from ro...@bytheb.org for now (unless someone wants to do

Re: [ovs-dev] Automated robotic reply. Re: ...

2018-06-20 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your > patch > with message ID <1529454160-88413-1-git-send-email-jpet...@ovn.org> > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > c

Re: [ovs-dev] Automated robotic reply. Re: ...

2018-06-20 Thread Aaron Conole
Justin Pettit writes: >> On Jun 20, 2018, at 8:47 AM, Ben Pfaff wrote: >> >>> On Wed, Jun 20, 2018 at 08:20:19AM -0700, Justin Pettit wrote: >>> >>>> On Jun 20, 2018, at 8:15 AM, Aaron Conole wrote: >>>> >>>> 0-day Robot

[ovs-dev] [PATCH 2/2] checkpatch: Only consider certain signoffs

2018-06-20 Thread Aaron Conole
. This commit updates checkpatch to only consider those signoff lines which start at the beginning of a line. So the following: Signed-off-by: Foo Bar should not trigger. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[ovs-dev] [PATCH 1/2] checkpatch: add quiet option

2018-06-20 Thread Aaron Conole
This allows scripts which only want to process error messages to silence the normal 'warm and fuzzy' status messages from checkpatch. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a

Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v2] ovn.at: Add stateful test for ACL on port groups.

2018-06-25 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > == Checking 6cbdf56ce88d ("datapath-windows: Compute ct hash b

Re: [ovs-dev] Automated robotic reply. Re: *

2018-06-25 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your > patch > with message ID > Thanks for your contribution. > > I encountered a 'make distcheck' failure. See the details below. > 2613: mcast - check multicasts to trunk ports are not duplicated ok >

Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v2] ovn: Allow for automatic dynamic updates of IPAM

2018-06-25 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > == Checking a417a986243d ("ovn: Allow for automatic dynam

Re: [ovs-dev] Automated robotic reply. Re: ofp-actions: Fix buffer overread in decode_LEARN_specs().

2018-06-25 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > == Checking 913dd37571cf ("ofp-actions: Fix buffer overread i

Re: [ovs-dev] [PATCH] utilities: On RHEL 7 systems clean up after upgrade

2018-06-25 Thread Aaron Conole
Hi Greg, Greg Rose writes: > When upgrading from older versions of OVS that used the built-in geneve > kernel module on RHEL 7 systems to newer versions that use the 'compat' > vport_geneve and vport_vxlan drivers we need to clean up some cruft > that might have been left over after the upgrade.

Re: [ovs-dev] Automated robotic reply. Re: ofp-actions: Avoid buffer overread in BUNDLE action decoding.

2018-06-25 Thread Aaron Conole
Ben Pfaff writes: > This seems to be no error at all? :-/ This is another trigger from the subject. Sorry about that. Now that the series is applied, I've updated the job only to use the '-q' specifier. It shouldn't trigger again (but I'll do some testing with it on 'dry-run mode'). > On Mo

[ovs-dev] [PATCH] checkpatch: fix scissors line regex

2018-06-26 Thread Aaron Conole
://mail.openvswitch.org/pipermail/ovs-dev/2018-June/348625.html Fixes: c599d5ccf316 ("checkpatch.py: A simple script for finding patch issues") Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/check

Re: [ovs-dev] Automated robotic reply. Re: AUTHORS: Update email-id of Manohar K C

2018-06-26 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Manohar Krishnappa Chidambaraswamy, I am a > robot and I have tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: No signatures found. > Lines c

Re: [ovs-dev] [PATCH v1] dpdk: Support both shared and per port mempools.

2018-06-26 Thread Aaron Conole
Hi Ian, Ian Stokes writes: > This commit re-introduces the concept of shared mempools as the default > memory model for DPDK devices. Per port mempools are still available but > must be enabled explicitly by a user. > > OVS previously used a shared mempool model for ports with the same MTU > and

Re: [ovs-dev] [PATCH] checkpatch: fix scissors line regex

2018-06-27 Thread Aaron Conole
Ben Pfaff writes: > On Tue, Jun 26, 2018 at 08:58:38AM -0400, Aaron Conole wrote: >> The scissors line is always three dashes on a line. The regex would >> previously match on any three dashes in a row. >> >> This means that a patch (such as [1]) would trigger the

Re: [ovs-dev] Automated robotic reply. Re: *

2018-06-27 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out > your patch > with message ID > Thanks for your contribution. I'm disabling the distcheck output until the tests can run consistently on the system. ___

Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v1] conntrack: Support global drop statistics.

2018-06-27 Thread Aaron Conole
Hi Darrell, 0-day Robot writes: > Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-

Re: [ovs-dev] [PATCH 0/3] IPsec support for tunneling

2018-06-27 Thread Aaron Conole
Qiuyu Xiao writes: > This patch series reintroduce IPsec support for OVS tunneling and adds new > features to prepare for the OVN IPsec support. The new features are: > > 1) Add CA-cert based authentication support to ovs-monitor-ipsec. > 2) Enable ovs-pki to generate x.509 version 3 certificate.

Re: [ovs-dev] [PATCH 1/3] ipsec: reintroduce IPsec support for tunneling

2018-06-27 Thread Aaron Conole
Thanks for the patch. It's really cool to see IPSec being re-integrated. Just a few quick comments inline. Qiuyu Xiao writes: > From: Ansis Atteka > > This patch reintroduces ovs-monitor-ipsec daemon that > was previously removed by commit 2b02d770 ("openvswitch: > Allow external IPsec tunnel

Re: [ovs-dev] [PATCH 2/3] ipsec: add CA-cert based authentication

2018-06-27 Thread Aaron Conole
Qiuyu Xiao writes: > This patch adds CA-cert based authentication to the ovs-monitor-ipsec > daemon. With CA-cert based authentication enabled, OVS approves IPsec > tunnel if the peer has a cert signed by a trusted CA and the identity of > the peer cert is as expected. Belows are the major change

[ovs-dev] [PATCH v2] checkpatch: fix patch separator line regex

2018-06-27 Thread Aaron Conole
the signed-off checks. Now, bound the check only to use what git-mailinfo would use as a separator. --- --- 1: https://mail.openvswitch.org/pipermail/ovs-dev/2018-June/348625.html Fixes: c599d5ccf316 ("checkpatch.py: A simple script for finding patch issues") Signed-off-by: Aa

Re: [ovs-dev] [PATCH V2] utilities: On RHEL 7 systems clean up after upgrade

2018-06-29 Thread Aaron Conole
Justin Pettit writes: >> On Jun 26, 2018, at 10:19 AM, Greg Rose wrote: >> >> When upgrading from older versions of OVS that used the built-in geneve >> kernel module on RHEL 7 systems to newer versions that use the 'compat' >> vport_geneve and vport_vxlan drivers we need to clean up some cruft

Re: [ovs-dev] [PATCH V2] utilities: On RHEL 7 systems clean up after upgrade

2018-06-29 Thread Aaron Conole
Gregory Rose writes: > On 6/29/2018 10:48 AM, Aaron Conole wrote: >> Justin Pettit writes: >> >>>> On Jun 26, 2018, at 10:19 AM, Greg Rose wrote: >>>> >>>> When upgrading from older versions of OVS that used the built-in geneve >>>

Re: [ovs-dev] [PATCH V3 1/2] utilities: On RHEL 7 systems clean up after upgrade

2018-06-29 Thread Aaron Conole
the "unassociated datapath" errors that can sometimes occur in some > environments. > > Signed-off-by: Greg Rose > > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V3 2/2] utilities: Fix conntrack flush command

2018-06-29 Thread Aaron Conole
one before the stop_forwarding command. > > In addition, make the message more human friendly. > > Signed-off-by: Greg Rose > > --- > Good catch. Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/3] ipsec: reintroduce IPsec support for tunneling

2018-07-03 Thread Aaron Conole
Ben Pfaff writes: > On Wed, Jun 27, 2018 at 04:00:00PM -0400, Aaron Conole wrote: >> Thanks for the patch. It's really cool to see IPSec being >> re-integrated. Just a few quick comments inline. >> >> Qiuyu Xiao writes: >> >> > From: Ansi

Re: [ovs-dev] [ovs-dev, patch_v1] db-ctl-base: Use boolean variable values.

2018-07-06 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-by l

Re: [ovs-dev] [PATCH] ofproto: Return error codes for Rule insertions

2018-07-08 Thread Aaron Conole
Hi Arvind, Aravind Prasad writes: > Currently, rule_insert() API doesnot have return value. There are some > possible > scenarios where rule insertions can fail at run-time even though the static > checks during rule_construct() had passed previously. > > Some possible scenarios for failure of r

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.9

2018-07-08 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-by lin

Re: [ovs-dev] [ovs-dev, RFC, 5 of 9] ovn-nbctl: Don't dup the error message just to report it.

2018-07-09 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > Okay - I *think* I enabled the RFC series detection. Sorry about this.

[ovs-dev] [PATCH] xlate: use const struct in6_addr in linklocal check

2018-07-10 Thread Aaron Conole
error: member reference base type 'const uint8_t' (aka 'const unsigned char') is not a structure or union Fixes: 83c2757bd16e ("xlate: Move tnl_neigh_snoop() to terminate_native_tunnel()") Cc: Zoltan Balogh Cc: Jan Scheurich Signed-off-by: Aaron Conol

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Check the right IPv6 address in is_nd_dst_correct().

2018-07-10 Thread Aaron Conole
Ben Pfaff writes: > Fixes test 815 "tunnel_push_pop_ipv6 - action". > > CC: Aaron Conole > Fixes: 6f231f7c3a9e ("xlate: use const struct in6_addr in linklocal check") > Signed-off-by: Ben Pfaff > --- D'oh! The names ki

Re: [ovs-dev] [PATCH] sparse: Make IN6_IS_ADDR_MC_LINKLOCAL and IN6_ARE_ADDR_EQUAL pickier.

2018-07-10 Thread Aaron Conole
ly pickier so that we catch any introduced > problems more quickly. > > CC: Aaron Conole > Signed-off-by: Ben Pfaff > --- LGTM Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] bot suggestion

2018-07-11 Thread Aaron Conole
Ben Pfaff writes: > The bot couldn't apply this patch presumably because it tried to apply > it against master. Maybe the bot should notice version numbers in [] in > subject lines and try against that branch. Good call. I'm at a conference at the moment, but will try to get that integrated th

Re: [ovs-dev] [ovs-dev, 01 of 15] table: Allow default style to be used in an assignment.

2018-07-12 Thread Aaron Conole
Jakub Sitnicki writes: > Hey Aaron, > > On Wed, 11 Jul 2018 15:55:34 -0400 > 0-day Robot wrote: > >> Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have tried out >> your patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the detail

Re: [ovs-dev] [ovs-dev, PATCHv3] datapath: work around the single GRE receive limitation.

2018-07-12 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings William Tu, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-by line

Re: [ovs-dev] [ovs-dev, 12 of 15] ovn-nbctl: Initial support for daemon mode.

2018-07-12 Thread Aaron Conole
Jakub Sitnicki writes: > On Wed, 11 Jul 2018 16:04:32 -0400 > 0-day Robot wrote: > >> Bleep bloop. Greetings Jakub Sitnicki, I am a robot and I have >> tried out your patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >>

Re: [ovs-dev] [PATCH] ofproto: Return error codes for Rule insertions

2018-07-12 Thread Aaron Conole
Aravind Prasad S writes: > Currently, rule_insert() API doesnot have return value. There are some > possible /doesnot/doesn't/ or /doesnot/does not/ Or maybe even just remove that sentence. :) > scenarios where rule insertions can fail at run-time even though the static > checks during rul

Re: [ovs-dev] [PATCH] tests: Ignore recirc_id in "MPLS xlate action" test.

2018-07-13 Thread Aaron Conole
After this gets applied, I'll wait a bit and see if the tests consistently pass. If that's so, I'll re-enable the make distcheck in the bot for output. Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] configure: Enable GCC relevant new 8.x warning options.

2018-07-13 Thread Aaron Conole
; > Signed-off-by: Ben Pfaff > --- LGTM. Sorry it took so long to review. Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] selinux: changes to support newer hugetlbfs restrictions

2018-07-18 Thread Aaron Conole
information for the DPDK .rte_config, and clearing actions copying from /dev/zero will trigger selinux denials. This commit allows openvswitch to have more permissions for the hugetlbfs allocation and use. Signed-off-by: Aaron Conole --- NOTE: I seem to have lost the system with the logs th

Re: [ovs-dev] build: Add gitattribute file to build-aux

2018-07-18 Thread Aaron Conole
Hi Alin, 0-day Robot writes: > Bleep bloop. Greetings Alin Gabriel Serdean, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > I suggest folding in something like the following (sinc

Re: [ovs-dev] [PATCH] Documentation:

2018-07-18 Thread Aaron Conole
Hi Greg, Greg Rose writes: > Add netstat when mentioning testing. Many check-kmod failures result > when it is not present. > > Signed-off-by: Greg Rose > --- Just wanted to point out that the subject looks incomplete. Otherwise: Acked-b

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

2018-07-18 Thread Aaron Conole
lock. > > We can workaround this by switching to 'root' user when we are > performing this pre-startup steps and fixup the DB permissions before > we start the actual ovsdb-server daemon. > > [1]: https://bugzilla.suse.com/show_bug.cgi?id=1098630 > Cc: Aaron Conole

Re: [ovs-dev] [PATCH] Documentation:

2018-07-18 Thread Aaron Conole
Gregory Rose writes: > On 7/18/2018 8:03 AM, Aaron Conole wrote: >> Hi Greg, >> >> Greg Rose writes: >> >>> Add netstat when mentioning testing. Many check-kmod failures result >>> when it is not present. >>> >>> Signed-off-by:

Re: [ovs-dev] [PATCH V2] Documentation: Add netstat to testing instructions

2018-07-18 Thread Aaron Conole
Greg Rose writes: > Add netstat when mentioning testing. Many check-kmod failures result > when it is not present. > > Signed-off-by: Greg Rose > > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://ma

Re: [ovs-dev] Introduce ovs-appctl command to monitor HVs sb connection status

2018-07-19 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have > tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-b

Re: [ovs-dev] [PATCH v2] build: Add gitattribute file to build-aux

2018-07-19 Thread Aaron Conole
a .gittatribute file to build-aux to force LF endings > on Windows. > > Signed-off-by: Alin Gabriel Serdean > Co-authored-by: Aaron Conole > --- Signed-off-by: Aaron Conole Thanks, Alin! ___ dev mailing list d...@openvswitch.org https:

[ovs-dev] [PATCH] netlink-conntrack: undef the correct macro

2018-07-23 Thread Aaron Conole
Fixes: 6830a0c0e6bf ("netlink-conntrack: New module.") Cc: Daniele Di Proietto Signed-off-by: Aaron Conole --- lib/netlink-conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netlink-conntrack.c b/lib/netlink-conntrack.c index e5a5fc118..42be1d9ce 10

Re: [ovs-dev] [PATCH] netlink-conntrack: undef the correct macro

2018-07-25 Thread Aaron Conole
Ben Pfaff writes: > On Mon, Jul 23, 2018 at 04:40:49PM -0400, Aaron Conole wrote: >> Fixes: 6830a0c0e6bf ("netlink-conntrack: New module.") >> Cc: Daniele Di Proietto >> Signed-off-by: Aaron Conole > > Thanks, applied to master. > > I didn't back

Re: [ovs-dev] Revert "dp-packet: Handle multi-seg mbufs in resize__()."

2018-07-25 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Tiago Lam, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > Hi Ian (and all), Given there are currently two trees (mainline and dpdk_merg

Re: [ovs-dev] [ovs-dev, RFC] dp-packet: Don't resize DPBUF_DPDK packets.

2018-07-25 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Tiago Lam, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > Sorry for the noise. The robot was improperly matching the RFC tag (so ''PA

Re: [ovs-dev] dpif-netdev: Fix zero length keys insertion to EMC.

2018-07-25 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > This isn't an issue with your patch, Ilya. The current mainline has a f

[ovs-dev] [PATCH] dpif-netdev: compatible function type

2018-07-25 Thread Aaron Conole
initialization for 'dpif_netdev_class.flow_dump_create') [-Werror] Fixes: ab15e70eb587 ("dpctl: Expand the flow dump type filter") Cc: Gavi Teitz Cc: Roi Dayan Cc: Simon Horman Signed-off-by: Aaron Conole --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [ovs-dev] [PATCH v2] tc: Fix sparse warnings.

2018-07-25 Thread Aaron Conole
on Horman > Fixes: 61e8655cfc7a ("tc: Add VLAN tpid for push action") > Signed-off-by: Ben Pfaff > --- Looks good - passed with sparse 0.5.2 Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] selinux: changes to support newer hugetlbfs restrictions

2018-07-27 Thread Aaron Conole
Aaron Conole writes: > Newer selinux base policies now split out 'map' actions, as well as > adding more explicit checks for hugetlbfs objects. Where previously these > weren't required, recent changes have flagged the allocation of hugepages > and subsequent cle

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

2018-07-27 Thread Aaron Conole
Flavio Leitner writes: > On Wed, Jul 18, 2018 at 11:24:43AM -0400, Aaron Conole wrote: >> Markos Chandras writes: >> >> > When ovsdb-server is starting, it performs some DB steps such as >> > creating and upgrading the OvS DB. When we are running as >> &

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

2018-07-27 Thread Aaron Conole
Markos Chandras writes: > Hello Aaron, > > On 18/07/18 16:24, Aaron Conole wrote: >> >> I think there's actually a race condition here. Most likely, >> ovsdb-server doesn't need to be started before network.service. >> >> Looking at the bug, I

Re: [ovs-dev] [ovs-dev, v3, 2 of 6] ipsec: reintroduce IPsec support for tunneling

2018-07-30 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Qiuyu Xiao, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-by lin

Re: [ovs-dev] [PATCH] selinux: more changes to support newer hugetlbfs restrictions

2018-07-31 Thread Aaron Conole
Timothy Redaelli writes: > The new 'map' action is needed for 'hugetlbfs_t:file' too. > > CC: Aaron Conole > Fixes: d2675a146130 ("selinux: changes to support newer hugetlbfs > restrictions") > > Signed-off-by: Timothy R

Re: [ovs-dev] robot suggestion

2018-07-31 Thread Aaron Conole
Ben Pfaff writes: > Today we've seen some failure reports from the robot because the build > was broken on master. That will happen occasionally (often, as in this > case, because the robot uses a GCC version different from the > submitter). Maybe the robot should even report it, probably in a

Re: [ovs-dev] [PATCH] ovn: Clean up log() action parsing errors.

2018-07-31 Thread Aaron Conole
Justin Pettit writes: >> On Jul 31, 2018, at 5:21 AM, Mark Michelson wrote: >> >> The 0-day Robot needs to lay off the pipe. > > Yeah, I'm not sure what was happening there. I emailed Aaron about it. Sorry about that. I'll work on protecting the list for when the robot indulges in compile-al

Re: [ovs-dev] [PATCH 1/9] tests: Simplify the setting of aliases.

2018-08-01 Thread Aaron Conole
Hi Ilya, Ilya Maximets writes: > There is no need to create a separate function for each alias. > This will simplify adding new default options and utils. > > Signed-off-by: Ilya Maximets > --- > tests/ovs-macros.at | 35 +-- > 1 file changed, 5 insertions(+), 3

Re: [ovs-dev] [PATCH] utilities: Run ovsdb-server pre-startup DB steps as root

2018-08-01 Thread Aaron Conole
Ben Pfaff writes: > I don't understand the conclusion in this thread. Does anyone want me > to apply some patch? Or should I stay tuned for further discussion? Stay tuned for the exciting conclusion, please :) > Thanks, > > Ben. ___ dev mailing list

[ovs-dev] [PATCH 4/6] system-dpdk: Use a different character marker for sed commands

2018-08-01 Thread Aaron Conole
The default marker for sed commands according to the manual is /, but this is inconvenient when working with paths. The solution is either to escape all instances of / or use sed's \cREGEXc feature. Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 14 +++--- 1 file chang

[ovs-dev] [PATCH 0/6] system-dpdk: add support to ping two namespaces

2018-08-01 Thread Aaron Conole
This allows system-dpdk test suite to ping two namespaces via a pair of dpdkvhostuserclient ports, using testpmd as a forwarding agent. Currently, the final patch in the series (which adds the test) isn't reliable enough yet, so it is still RFC. Submitted for early feedback. Aaron Cono

[ovs-dev] [RFC 6/6] system-dpdk: Connect two namespaces via virtio

2018-08-01 Thread Aaron Conole
From: Bala Sankaran This adds a new test to the 'check-dpdk' subsystem that will exercise allocations, PMDs, and the vhost-user code path. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- NOTE: This currently is broken, and needs some h

[ovs-dev] [PATCH 5/6] system-dpdk: Convert /tmp to use OVS_RUNDIR

2018-08-01 Thread Aaron Conole
Aaron Conole Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at index 834ba06fb..58dc8aaae 100644 --- a/tests/system-dpdk.at +++ b/tests/system-dpdk.at @@ -54,20 +54,20 @@ OVS_DPDK_

[ovs-dev] [PATCH 3/6] system-dpdk: Allow running the dpdk tests from a VM

2018-08-01 Thread Aaron Conole
Some VM configurations result in CPU flags that cause warnings to be issued by the DPDK libraries. When these warnings are issued, the tests will fail. This commit adds the unreliable tsc warning to the list of ignored warnings. Signed-off-by: Aaron Conole --- tests/system-dpdk.at | 3 +++ 1

[ovs-dev] [PATCH 2/6] system-dpdk: skip all tests if there are no hugepages

2018-08-01 Thread Aaron Conole
From: Bala Sankaran A failure is quite harsh in this scenario. It's better to simply skip all the tests and let the user look at the logs to understand the missing hugepages. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- tests/system

[ovs-dev] [PATCH 1/6] system-dpdk: update test suite for non-phy testing

2018-08-01 Thread Aaron Conole
This allows a system that doesn't have a dedicated DPDK nic to execute some DPDK tests. In this fashion, tests that operate on virtual ports (such as dpdkvhostuserclient) can be executed in a wider set of environments. Signed-off-by: Aaron Conole --- tests/system-dpdk-macros.at

Re: [ovs-dev] [PATCH] AUTHORS: Update email address for Jakub Sitnicki.

2018-08-02 Thread Aaron Conole
Jakub Sitnicki writes: > Signed-off-by: Jakub Sitnicki > --- > > The j...@redhat.com address will be valid only until August 4th. :'( With sadness: Acked-by: Aaron Conole > AUTHORS.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [ovs-dev] Revert "dp-packet: Handle multi-seg mbufs in resize__()."

2018-08-03 Thread Aaron Conole
Ian Stokes writes: > On 7/25/2018 2:56 PM, Aaron Conole wrote: >> 0-day Robot writes: >> >>> Bleep bloop. Greetings Tiago Lam, I am a robot and I have tried out your >>> patch. >>> Thanks for your contribution. >>> >>> I encountere

Re: [ovs-dev] [PATCH] utilities: don't use a bashism to check that datapath exists

2018-08-03 Thread Aaron Conole
C: Martin Xu > Fixes: 9763d17fbd05 ("utilities: check datapath exists before conntrack > flush") > > Signed-off-by: Timothy Redaelli > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 0/9] tests: Clean up syslog.

2018-08-03 Thread Aaron Conole
push-pop-ipv6.at | 2 +- > tests/tunnel-push-pop.at | 2 +- > tests/vlog.at | 15 +-- > tests/vtep-ctl.at | 4 +- > 28 files changed, 463 insertions(+), 238 deletions(-) For the series: Acked-by: Aaron Conole As a note, I saw a mix of '--det

Re: [ovs-dev] [PATCH] utilities: Launch ovsdb-tool without using PAM

2018-08-06 Thread Aaron Conole
(usually "openvswitch") and the remaining group > IDs are used as supplementary groups (usually "hugetlbfs", if OVS is > built with DPDK support). > > [1]: https://bugzilla.suse.com/show_bug.cgi?id=1098630 > Reported-by: Markos Chandras > Reported-at: > http

Re: [ovs-dev] [PATCH] ovs-ofctl: Better validate OpenFlow message length in "ofp-parse-pcap".

2018-08-06 Thread Aaron Conole
Ben Pfaff writes: > Reported-by: Oscar Wilde > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2018-July/047070.html > Signed-off-by: Ben Pfaff > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvs

Re: [ovs-dev] [ovs-dev,v3] tests: Test for ovs-ofctl snoop command

2018-08-07 Thread Aaron Conole
Ashish Varma writes: > Hi Aaron, > > My patch is already committed by Ben. Not sure what is wrong here. Thanks for the heads up. This happens - usually if the patch is committed before the bot has run against it. I have it on my list of TODOs, so as soon as my next 'work on the bot' time comes

  1   2   3   4   5   6   7   8   9   10   >