Re: [ovs-dev] [PATCH] checkpatch: Also check switch, HMAP_FOR_EACH, etc.

2017-05-30 Thread Aaron Conole
are just places where the usage is incorrect. Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] meta-flow: Remove dead condition in mf_set().

2017-05-31 Thread Aaron Conole
ergedDefectId=179568 > Signed-off-by: Ben Pfaff > --- Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] physical: Tolerate missing distributed-port key for chassisredirect ports.

2017-05-31 Thread Aaron Conole
889/p10449/fileInstanceId=14763078&defectInstanceId=4305288&mergedDefectId=179857 > Signed-off-by: Ben Pfaff > --- Yikes! Coverity++ Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovsdb-client: Use correct operand to 'sizeof' in do_dump().

2017-05-31 Thread Aaron Conole
2014, 2015, 2016, 2017 > Nicira, Inc. Maybe change this to + * Copyright (c) 2009-2017 Nicira, Inc. Otherwise: Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] checkpatch: Omit some checks on comment lines.

2017-06-01 Thread Aaron Conole
ing like "*x = 1;".) > > Suggested-by: Joe Stringer > Signed-off-by: Ben Pfaff > --- Acked-by: Aaron Conole Thanks Ben and Joe for all the checkpatch enhancements. :) ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] checkpatch: Fix typo for use as filter.

2017-06-01 Thread Aaron Conole
Traceback (most recent call last): File "utilities/checkpatch.py", line 415, in sys.exit(ovs_checkpatch_parse(sys.stdin.read()), '-') TypeError: ovs_checkpatch_parse() takes exactly 2 arguments (1 given) :/ Sorry I missed it during my review. Acked-by: Aaro

Re: [ovs-dev] [patch_v2] dpdk: Fix device cleanup.

2017-07-30 Thread Aaron Conole
ach is to revert 5dcde09c80a8. This patch does not do that > but reinstates the command ovs-appctl netdev-dpdk/detach to handle > cases when del-port will not work. > > To detach the device, run the reinstated command > ovs-appctl netdev-dpdk/detach :04:00.1 > Observe console output &

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

2017-07-30 Thread Aaron Conole
to 17.05.1. > - rhel/openvswitch-fedora.spec.in: DPDK version change > from 16.11 to 17.05.1 > > v1->v2: Patch rebase. > v2->v3: Fixed wrong formating after v2 patch rebase. > v3->v4: Minor documentation changes. > > Signed-off-by: Michal

Re: [ovs-dev] [PATCH 4/5] Automatically verify that OVS header files work OK in C++ also.

2017-08-01 Thread Aaron Conole
Ben Pfaff writes: > On Mon, Jul 31, 2017 at 04:44:10PM -0400, Russell Bryant wrote: >> On Mon, Jul 31, 2017 at 4:33 PM, Ben Pfaff wrote: >> > On Mon, Jul 31, 2017 at 01:05:32PM -0700, Ben Pfaff wrote: >> >> On Mon, Jul 31, 2017 at 03:50:59PM -0400, Russell Bryant wrote: >> >> > On Sun, Jul 30, 2

[ovs-dev] [PATCH v3 0/6] rhel/fedora: non-root OvS out of the box

2017-08-01 Thread Aaron Conole
https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/334946.html Refactor for the dpdk non-root user portion due to an issue discovered where the generated service file didn't honor new configuration when re-running ./configure. Also, converted the "Reviewed-by" to "Acked-by"

[ovs-dev] [PATCH v3 1/6] redhat: allow arbitrary user:group

2017-08-01 Thread Aaron Conole
efaults to root:root, but can be overridden by changing the /etc/sysconfig/openvswitch environment file. Acked-by: Markos Chandras Signed-off-by: Aaron Conole --- rhel/automake.mk | 1 + rhel/etc_openvswitch_default.conf | 5 +

[ovs-dev] [PATCH v3 2/6] redhat: dynamically allocate and reference ovs user

2017-08-01 Thread Aaron Conole
mpact existing installations, the /etc/openvswitch directory will be created during the installation, rather than being provided as part of the rpm. Acked-by: Markos Chandras Signed-off-by: Aaron Conole --- rhel/openvswitch-fedora.spec.in | 13 +

[ovs-dev] [PATCH v3 3/6] makefile: create destdir when generating files

2017-08-01 Thread Aaron Conole
available. This commit adds a 'mkdir -p' before generating the output files. Signed-off-by: Aaron Conole --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 373ef6e..30794ff 100644 --- a/Makefile.am +++ b/Makefile.am @@ -139,6 +139,7 @

[ovs-dev] [PATCH v3 4/6] redhat: dynamic service file for vswitchd

2017-08-01 Thread Aaron Conole
This commit changes the service file from static configuration to an autogenerated file, produced during the build. This will be relevant in a future commit. Signed-off-by: Aaron Conole --- rhel/.gitignore | 1 + rhel/automake.mk

[ovs-dev] [PATCH v3 5/6] dpdkstrip: add a preprocessor tool for stripping dpdk blocks

2017-08-01 Thread Aaron Conole
-processor. For those files which are not, this commit adds a new pre-processor tool for .in files to either include or exclude those stanzas as appropriate. Signed-off-by: Aaron Conole --- Makefile.am| 5 + build-aux/dpdkstrip.pl | 35 +++ 2 files

[ovs-dev] [PATCH v3 6/6] redhat: allow dpdk to also run as non-root user

2017-08-01 Thread Aaron Conole
ever grows an uninit / reinit function, non-root ovs likely could never use it. This does not change OvS+DPDK's SELinux requirements. It still must be disabled. Signed-off-by: Aaron Conole --- Documentation/intro/install/dpdk.rst| 7 +++

Re: [ovs-dev] [PATCH v3 6/6] redhat: allow dpdk to also run as non-root user

2017-08-02 Thread Aaron Conole
Sergio Gonzalez Monroy writes: > Hi Aaron, Hi Sergio, > On 01/08/2017 23:05, Aaron Conole wrote: >> After this commit, users may start a dpdk-enabled ovs setup as a >> non-root user. This is accomplished by exporting the $HOME directory, >> which dpdk uses to fill in

Re: [ovs-dev] DPDK Merge Repo

2017-08-02 Thread Aaron Conole
Ilya Maximets writes: > Hi Darrell and Ben. > >> Hi All >> >> As mentioned before, I am using a repo for DPDK patch merging. >> The repo is here: >> https://github.com/darball/ovs/ >> >> There are still some outstanding patches from Bhanu that have not >> completed review yet: >> >> util: Add

Re: [ovs-dev] [PATCH v3 3/6] makefile: create destdir when generating files

2017-08-02 Thread Aaron Conole
Ben Pfaff writes: > On Tue, Aug 01, 2017 at 06:05:40PM -0400, Aaron Conole wrote: >> When intermediary files are generated, the destination directory is assumed >> to exist. This has worked so far because most files are built prior to >> the dist-packaging step. How

Re: [ovs-dev] [PATCH v3 3/6] makefile: create destdir when generating files

2017-08-02 Thread Aaron Conole
Ben Pfaff writes: > On Wed, Aug 02, 2017 at 05:25:36PM -0400, Aaron Conole wrote: >> Ben Pfaff writes: >> >> > On Tue, Aug 01, 2017 at 06:05:40PM -0400, Aaron Conole wrote: >> >> When intermediary files are generated, the destination directory is >> &

Re: [ovs-dev] [PATCH v3 6/6] redhat: allow dpdk to also run as non-root user

2017-08-04 Thread Aaron Conole
Sergio Gonzalez Monroy writes: > On 02/08/2017 16:07, Aaron Conole wrote: >> Sergio Gonzalez Monroy writes: >> >>> Hi Aaron, >> Hi Sergio, >> >>> On 01/08/2017 23:05, Aaron Conole wrote: >>>> After this commit, users may start a

[ovs-dev] [PATCH v4 0/5] rhel/fedora: non-root OvS out of the box

2017-08-04 Thread Aaron Conole
l.openvswitch.org/pipermail/ovs-dev/2017-July/334946.html Refactor for the dpdk non-root user portion due to an issue discovered where the generated service file didn't honor new configuration when re-running ./configure. Also, converted the "Reviewed-by" to "Acked-by".

[ovs-dev] [PATCH v4 1/5] redhat: allow arbitrary user:group

2017-08-04 Thread Aaron Conole
efaults to root:root, but can be overridden by changing the /etc/sysconfig/openvswitch environment file. Acked-by: Markos Chandras Signed-off-by: Aaron Conole --- rhel/automake.mk | 1 + rhel/etc_openvswitch_default.conf | 5 +

[ovs-dev] [PATCH v4 2/5] redhat: dynamically allocate and reference ovs user

2017-08-04 Thread Aaron Conole
mpact existing installations, the /etc/openvswitch directory will be created during the installation, rather than being provided as part of the rpm. Acked-by: Markos Chandras Signed-off-by: Aaron Conole --- rhel/openvswitch-fedora.spec.in | 13 +

[ovs-dev] [PATCH v4 4/5] redhat: dynamic service file for vswitchd

2017-08-04 Thread Aaron Conole
This commit changes the service file from static configuration to an autogenerated file, produced during the build. This will be relevant in a future commit. Signed-off-by: Aaron Conole --- rhel/.gitignore | 1 + rhel/automake.mk

[ovs-dev] [PATCH v4 3/5] dpdkstrip: add a preprocessor tool for stripping dpdk blocks

2017-08-04 Thread Aaron Conole
-processor. For those files which are not, this commit adds a new pre-processor tool for .in files to either include or exclude those stanzas as appropriate. Signed-off-by: Aaron Conole --- Makefile.am| 1 + build-aux/dpdkstrip.pl | 35 +++ 2 files

[ovs-dev] [PATCH v4 5/5] redhat: allow dpdk to also run as non-root user

2017-08-04 Thread Aaron Conole
ever grows an uninit / reinit function, non-root ovs likely could never use it. This does not change OvS+DPDK's SELinux requirements. It still must be disabled. Signed-off-by: Aaron Conole --- Documentation/intro/install/dpdk.rst| 7 +++

Re: [ovs-dev] [PATCH v4 5/5] redhat: allow dpdk to also run as non-root user

2017-08-06 Thread Aaron Conole
Russell Bryant writes: > On Fri, Aug 4, 2017 at 1:00 PM, Aaron Conole wrote: >> After this commit, users may start a dpdk-enabled ovs setup as a >> non-root user. This is accomplished by exporting the $HOME directory, >> which dpdk uses to fill in it's semi-pe

Re: [ovs-dev] [PATCH v4 5/5] redhat: allow dpdk to also run as non-root user

2017-08-08 Thread Aaron Conole
Russell Bryant writes: > On Sun, Aug 6, 2017 at 7:24 AM, Aaron Conole wrote: >> Russell Bryant writes: >> >>> On Fri, Aug 4, 2017 at 1:00 PM, Aaron Conole wrote: >>>> After this commit, users may start a dpdk-enabled ovs setup as a >>>> non-r

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Aaron Conole
Darrell Ball writes: > Thanks Joe > I forgot to add your Tested-by to V5; I have been testing this myself; > but let me know if you would like it added – I can send a V6. It will automatically be added by patchwork. It is sufficient to download (ex: https://patchwork.ozlabs.org/patch/799499/mbo

[ovs-dev] [PATCH] netdev-dpdk: include dpdk PCI header directly

2017-08-09 Thread Aaron Conole
As part of a devargs rework in DPDK, the PCI header file was removed, and needs to be directly included. This isn't required to build with 17.05 or earlier, but will be required should a future update happen. Signed-off-by: Aaron Conole --- lib/netdev-dpdk.c | 1 + 1 file changed, 1 inse

[ovs-dev] [PATCH] redhat: add vfio udev rules

2017-08-09 Thread Aaron Conole
This commit builds on the non-root ovs work and adds a udev rule which will automatically set the group permissions of vfio devices. Signed-off-by: Aaron Conole --- Systemd folks say that this is not something that should be a part of systemd, but should be part of openvswitch. I can make a

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-10 Thread Aaron Conole
Darrell Ball writes: > -Original Message- > From: Aaron Conole > Date: Wednesday, August 9, 2017 at 12:51 PM > To: Darrell Ball > Cc: Joe Stringer , Darrell Ball , ovs > dev > Subject: Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags > on in

Re: [ovs-dev] [PATCH] netdev-dpdk: include dpdk PCI header directly

2017-08-10 Thread Aaron Conole
Ben Pfaff writes: > On Wed, Aug 09, 2017 at 04:00:53PM -0400, Aaron Conole wrote: >> As part of a devargs rework in DPDK, the PCI header file was removed, and >> needs to be directly included. This isn't required to build with 17.05 or >> earlier, but will be requi

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-10 Thread Aaron Conole
Darrell Ball writes: > -Original Message- > From: Aaron Conole > Date: Thursday, August 10, 2017 at 10:13 AM > To: Darrell Ball > Cc: ovs dev > Subject: Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags > on init. > &g

Re: [ovs-dev] [PATCH v3 2/2] rhel: delete transient ports on boot when starting ovsdb-server

2017-08-11 Thread Aaron Conole
Timothy Redaelli writes: > Use ovs-ctl --delete-transient-ports-on-boot to start ovsdb-server. > > This feature can be disabled by appending --no-delete-transient-ports-on-boot > to OPTIONS in /etc/sysconfig/openvswitch > > Signed-off-by: Timothy Redaelli > --- > rhel/usr_lib_systemd_system_ovs

[ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist

2017-08-14 Thread Aaron Conole
there on others. This change allows the ExecStartPre commands to fail. In the case that the user doesn't use DPDK, it won't matter anyway. Fixes: e3e738a3d058 ('redhat: allow dpdk to also run as non-root user') Signed-off-by: Aaron Conole Reported-by: Jean-Tsung Hsiao Te

Re: [ovs-dev] pwclient XML errors and form feeds

2017-08-15 Thread Aaron Conole
eeds are illegal in XML 1.0 [2]. This makes the use of form feeds and > the use of pwclient incompatible. > > Aaron Conole pointed out that once Patchwork 2.0 is available, the git-pw > command will render pwclient obsolete. I checked, and git-pw will use > Patchwork 2.0's REST

[ovs-dev] [PATCH 0/3] updated selinux policy for Open vSwitch

2017-08-16 Thread Aaron Conole
enabled or disabled based on the build. This is chosen instead of using an selinux boolean, because it is more transparent to the end user. All of this work was tested by passing traffic, including via a dpdk bridge. Aaron Conole (3): rhel: make the selinux policy intermediate makefile: hook

[ovs-dev] [PATCH 1/3] rhel: make the selinux policy intermediate

2017-08-16 Thread Aaron Conole
This will be used by an upcoming commit to have @begin_ and @end_ dpdk blocks to keep dpdk specific policy decisions only active when dpdk is used. Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- rhel/openvswitch-fedora.spec.in | 1 + selinux/automake.mk

[ovs-dev] [PATCH 2/3] makefile: hook up dpdkstrip preprocessor

2017-08-16 Thread Aaron Conole
policy file. Additionally, this means any .in files which might want to change based on configuration to exclude blocks based on dpdk can do so. Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/Makefile.am b/Makefile.am index

[ovs-dev] [PATCH 3/3] selinux: update policy to reflect non-root and dpdk support

2017-08-16 Thread Aaron Conole
. Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- selinux/openvswitch-custom.te.in | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/selinux/openvswitch-custom.te.in b/selinux/openvswitch-custom.te.in index 47ddb56..9f3ba20 100644 --- a

Re: [ovs-dev] [PATCH] checkpatch: Enforce bracing around conditionals.

2017-08-17 Thread Aaron Conole
Hi Joe, Joe Stringer writes: > The coding style states that BSD-style brace placement should be used, > and even single statements should be enclosed. Add checks to checkpatch > for this. > > Signed-off-by: Joe Stringer > --- > utilities/checkpatch.py | 13 + > 1 file changed, 13 i

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-17 Thread Aaron Conole
Aaron Conole writes: > Darrell Ball writes: > >> -Original Message----- >> From: Aaron Conole >> Date: Thursday, August 10, 2017 at 10:13 AM >> To: Darrell Ball >> Cc: ovs dev >> Subject: Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL che

Re: [ovs-dev] [PATCHv2] checkpatch: Enforce bracing around conditionals.

2017-08-21 Thread Aaron Conole
Joe Stringer writes: > The coding style states that BSD-style brace placement should be used, > and even single statements should be enclosed. Add checks to checkpatch > for this, particularly for 'else' statements. > > Signed-off-by: Joe Stringer > --- Acked-by: A

Re: [ovs-dev] [PATCH v3] netdev-dpdk: Create separate memory pool for each port

2017-08-22 Thread Aaron Conole
"Fischetti, Antonio" writes: > Hi Kevin, pls see comments inline. > I'm going to rebase and rework this patch on behalf of Robert. > > Thanks, > Antonio > >> -Original Message- >> From: ovs-dev-boun...@openvswitch.org >> [mailto:ovs-dev-boun...@openvswitch.org] >> On Behalf Of Kevin Tr

Re: [ovs-dev] [PATCH 0/3] updated selinux policy for Open vSwitch

2017-08-22 Thread Aaron Conole
Flavio Leitner writes: > On Wed, 16 Aug 2017 16:04:49 -0400 > Aaron Conole wrote: > >> This series brings about a policy update to openvswitch allowing it to >> run on a RHEL / Fedora system, even as a non-root user, with selinux set >> to Enforcing. >> &

Re: [ovs-dev] [PATCH v3 2/2] rhel: delete transient ports on boot when starting ovsdb-server

2017-08-28 Thread Aaron Conole
"Timothy M. Redaelli" writes: > On 08/11/2017 07:12 PM, Aaron Conole wrote: >> Timothy Redaelli writes: >> >>> Use ovs-ctl --delete-transient-ports-on-boot to start ovsdb-server. >>> >>> This feature can be disabled by appending >>&g

[ovs-dev] [PATCH v2 0/3] updated selinux policy for Open vSwitch

2017-08-30 Thread Aaron Conole
outside the scope of Open vSwitch project. * Folded in Flavio Leitner's ACK Aaron Conole (3): rhel: make the selinux policy intermediate makefile: hook up dpdkstrip preprocessor selinux: update policy to reflect non-root and dpdk support Makefile.am | 4 +++ rhe

[ovs-dev] [PATCH v2 1/3] rhel: make the selinux policy intermediate

2017-08-30 Thread Aaron Conole
This will be used by an upcoming commit to have @begin_ and @end_ dpdk blocks to keep dpdk specific policy decisions only active when dpdk is used. Acked-by: Flavio Leitner Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- rhel/openvswitch-fedora.spec.in | 1

[ovs-dev] [PATCH v2 2/3] makefile: hook up dpdkstrip preprocessor

2017-08-30 Thread Aaron Conole
policy file. Additionally, this means any .in files which might want to change based on configuration to exclude blocks based on dpdk can do so. Acked-by: Flavio Leitner Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a

[ovs-dev] [PATCH v2 3/3] selinux: update policy to reflect non-root and dpdk support

2017-08-30 Thread Aaron Conole
. Acked-by: Flavio Leitner Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- selinux/openvswitch-custom.te.in | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/selinux/openvswitch-custom.te.in b/selinux/openvswitch-custom.te.in index

Re: [ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist

2017-08-30 Thread Aaron Conole
Aaron Conole writes: > The upgrade from older Open vSwitch versions on RHEL will try, as much as > possible, to preserve the system. This means no new users or groups are > created. As an effect, it's possible for the chown to fail, because the > hugetlbfs group may not exist.

Re: [ovs-dev] [PATCH v2 3/3] selinux: update policy to reflect non-root and dpdk support

2017-08-31 Thread Aaron Conole
Hi Ansis, Thanks for the review! Ansis Atteka writes: > On 30 August 2017 at 07:00, Aaron Conole wrote: >> The selinux policy that exists in the repository did not specify access to >> all of the resources needed for Open vSwitch to properly function with >> an enforcing

Re: [ovs-dev] [PATCH v2 3/3] selinux: update policy to reflect non-root and dpdk support

2017-08-31 Thread Aaron Conole
Ansis Atteka writes: > On 31 August 2017 at 11:58, Aaron Conole wrote: >> Hi Ansis, >> >> Thanks for the review! >> >> Ansis Atteka writes: >> >>> On 30 August 2017 at 07:00, Aaron Conole wrote: >>>> The selinux policy that exists

[ovs-dev] [PATCH v3 1/3] rhel: make the selinux policy intermediate

2017-08-31 Thread Aaron Conole
This will be used by an upcoming commit to have @begin_ and @end_ dpdk blocks to keep dpdk specific policy decisions only active when dpdk is used. Acked-by: Flavio Leitner Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- rhel/openvswitch-fedora.spec.in | 1

[ovs-dev] [PATCH v3 0/3] updated selinux policy for Open vSwitch

2017-08-31 Thread Aaron Conole
e are still permissions needed to be added to libvirt / qemu, but that is outside the scope of Open vSwitch project. * Folded in Flavio Leitner's ACK Aaron Conole (3): rhel: make the selinux policy intermediate makefile: hook up dpdkstrip preprocessor selinux: update policy to reflect n

[ovs-dev] [PATCH v3 2/3] makefile: hook up dpdkstrip preprocessor

2017-08-31 Thread Aaron Conole
policy file. Additionally, this means any .in files which might want to change based on configuration to exclude blocks based on dpdk can do so. Acked-by: Flavio Leitner Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a

[ovs-dev] [PATCH v3 3/3] selinux: update policy to reflect non-root and dpdk support

2017-08-31 Thread Aaron Conole
. Acked-by: Flavio Leitner Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- selinux/openvswitch-custom.te.in | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/selinux/openvswitch-custom.te.in b/selinux/openvswitch-custom.te.in index

Re: [ovs-dev] [PATCH v2 3/3] selinux: update policy to reflect non-root and dpdk support

2017-08-31 Thread Aaron Conole
Ansis Atteka writes: > On 31 August 2017 at 14:57, Aaron Conole wrote: >> Ansis Atteka writes: >> >>> On 31 August 2017 at 11:58, Aaron Conole wrote: >>>> Hi Ansis, >>>> >>>> Thanks for the review! >>>> >>>&

[ovs-dev] [PATCH 1/3] selinux: move chr_file to non-dpdk as well

2017-09-01 Thread Aaron Conole
cy to reflect non-root and dpdk support") Signed-off-by: Aaron Conole --- selinux/openvswitch-custom.te.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/selinux/openvswitch-custom.te.in b/selinux/openvswitch-custom.te.in index 853de16..c1a774f 100644 --- a/selinux/o

[ovs-dev] [PATCH 0/3] Address some fallout from the selinux patches

2017-09-01 Thread Aaron Conole
In haste to get this in, a few things were missed. Patch one addresses a last-minute change that was embarassingly not committed. Patch two updates documentation (reported by Ansis) Patch three addresses a centos rpmbuild issue (reported by Ansis) Aaron Conole (3): selinux: move chr_file to

[ovs-dev] [PATCH 2/3] selinux.rst: point to the correct file

2017-09-01 Thread Aaron Conole
in instead. Correct the documentation, so that users won't be trying to edit a generated file. Also, add a gitignore for the autogenerated file. Fixes: 7bc1aae71e89 ("rhel: make the selinux policy intermediate") Reported-by: Ansis Atteka Signed-off-by: Aaron Conole --- Documentat

[ovs-dev] [PATCH 3/3] centos: fix selinux intermediate file

2017-09-01 Thread Aaron Conole
selinux policy intermediate") Reported-by: Ansis Atteka Signed-off-by: Aaron Conole --- rhel/openvswitch.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in index 412f3cd..e510d35 100644 --- a/rhel/openvswitch.spec.in +++ b/rhel/openvswi

Re: [ovs-dev] [PATCH v3 0/3] updated selinux policy for Open vSwitch

2017-09-01 Thread Aaron Conole
Ansis Atteka writes: > On 31 August 2017 at 16:22, Aaron Conole wrote: >> This series brings about a policy update to openvswitch allowing it to >> run on a RHEL / Fedora system, even as a non-root user, with selinux set >> to Enforcing. >> >> The first two pat

Re: [ovs-dev] [PATCH v4 0/7] Add OVS DPDK keep-alive functionality.

2017-09-06 Thread Aaron Conole
Hi Bhanu, Bhanuprakash Bodireddy writes: > Keepalive feature is aimed at achieving Fastpath Service Assurance > in OVS-DPDK deployments. It adds support for monitoring the packet > processing cores(PMD thread cores) by dispatching heartbeats at regular > intervals. Incase of heartbeat misses add

Re: [ovs-dev] [PATCH v4 2/7] Keepalive: Add initial keepalive support.

2017-09-06 Thread Aaron Conole
Hi Bhanu, Bhanuprakash Bodireddy writes: > This commit introduces the initial keepalive support by adding > 'keepalive' module and also helper and initialization functions > that will be invoked by later commits. > > This commit adds new ovsdb column "keepalive" that shows the status > of the da

Re: [ovs-dev] [PATCH v4 3/7] dpif-netdev: Register packet processing cores to KA framework.

2017-09-06 Thread Aaron Conole
Bhanuprakash Bodireddy writes: > This commit registers the packet processing PMD cores to keepalive > framework. Only PMDs that have rxqs mapped will be registered and > actively monitored by KA framework. > > This commit spawns a keepalive thread that will dispatch heartbeats to > PMD cores. The

Re: [ovs-dev] [PATCH v4 0/7] Add OVS DPDK keep-alive functionality.

2017-09-06 Thread Aaron Conole
"Bodireddy, Bhanuprakash" writes: > Hi Aaron, > >>Quick comment before I do an in-depth review. >> >>One thing that is missing in this series is some form of documentation added >>to explain why this feature should exist (for instance, why can't the standard >>posix process accounting information

Re: [ovs-dev] [PATCH v4 3/7] dpif-netdev: Register packet processing cores to KA framework.

2017-09-08 Thread Aaron Conole
"Bodireddy, Bhanuprakash" writes: >>Bhanuprakash Bodireddy writes: >> >>> This commit registers the packet processing PMD cores to keepalive >>> framework. Only PMDs that have rxqs mapped will be registered and >>> actively monitored by KA framework. >>> >>> This commit spawns a keepalive thread

Re: [ovs-dev] [PATCH v4 3/7] dpif-netdev: Register packet processing cores to KA framework.

2017-09-13 Thread Aaron Conole
"Bodireddy, Bhanuprakash" writes: >>"Bodireddy, Bhanuprakash" writes: >> Bhanuprakash Bodireddy writes: > This commit registers the packet processing PMD cores to keepalive > framework. Only PMDs that have rxqs mapped will be registered and > actively monitored by KA framew

Re: [ovs-dev] MTU in i40e dpdk driver

2017-09-18 Thread Aaron Conole
Nitin Katiyar writes: > Hi, > We are using OVS-DPDK (2.6 version) with Fortville NIC (configured in > 25G mode) being used as dpdk port. The setup involves 2 VMs running on > 2 different computes (destination VM in compute with 10G NIC while > originating VM is in compute with Fortville NIC). All

Re: [ovs-dev] ovs-tcpdump error

2017-09-21 Thread Aaron Conole
Hi Bhanu, "Bodireddy, Bhanuprakash" writes: > Hi, > > > > ovs-tcpdump throws the below error when trying to capture packets on one of > the > vhostuserports. > > > > $ ovs-tcpdump -i dpdkvhostuser0 > >ERROR: Please create an interface called `midpdkvhostuser0` > > See your OS guide

[ovs-dev] [PATCH] rhel: fix log directory permissions

2017-09-22 Thread Aaron Conole
g file with the appropriate attributes. This change sets the r/x bits for other on /var/log/messages Signed-off-by: Aaron Conole Tested-by: Jean Hsiao --- rhel/openvswitch-fedora.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rhel/openvswitch-fedora.spec.in b/r

Re: [ovs-dev] [PATCH] rhel: fix log directory permissions

2017-09-25 Thread Aaron Conole
Flavio Leitner writes: > On Fri, 22 Sep 2017 09:44:18 -0400 > Aaron Conole wrote: > >> When the logrotate script runs, and Open vSwitch is running as a non-root >> user, the /var/log/openvswitch directory doesn't have other rx bits set. >> This means t

Re: [ovs-dev] [PATCH v2] dpdk: Late initialization.

2017-01-09 Thread Aaron Conole
rom ideal, because initializing DPDK might still > abort the process (e.g. if there not enough memory), so the user must > check the status of the process after setting dpdk-init to true. > > Nonetheless, I think this is an improvement, because it doesn't require > restartin

Re: [ovs-dev] [PATCH v2] dpdk: Late initialization.

2017-01-09 Thread Aaron Conole
after setting dpdk-init to true. >> >> Nonetheless, I think this is an improvement, because it doesn't require >> restarting the whole unit. >> >> CC: Aaron Conole mailto:acon...@redhat.com>> >> Signed-off-by: Daniele Di Proietto > <mailt

Re: [ovs-dev] [PATCH v2] netdev-dummy: Limits the number of tx/rx queues.

2017-01-09 Thread Aaron Conole
nickcooper-zhangtonghao writes: > This patch avoids the ovs_rcu to report WARN, caused by blocked > for a long time, when ovs-vswitchd processes a port with many > rx/tx queues. The number of tx/rx queues per port may be appropriate, > because the dpdk uses it as an default max value. > > Signed-

Re: [ovs-dev] [PATCH v3] dpdk: Late initialization.

2017-01-10 Thread Aaron Conole
rom ideal, because initializing DPDK might still > abort the process (e.g. if there not enough memory), so the user must > check the status of the process after setting dpdk-init to true. > > Nonetheless, I think this is an improvement, because it doesn't require > restartin

[ovs-dev] [RFC] libX: add new release / version info tags

2017-01-10 Thread Aaron Conole
Signed-off-by: Aaron Conole --- This is labelled as RFC. I'm not sure if it's appropriate to apply it to master before the 2.7 branch. configure.ac| 1 + lib/automake.mk | 4 ++-- m4/openvswitch.m4 | 18 ++ ofproto/automake.mk | 2 +- ovn/lib/automake.m

Re: [ovs-dev] ABI versioning (was Re: [PATCH] rhel: Support...)

2017-01-10 Thread Aaron Conole
Ben Warren via dev writes: > Hi Aaron, > >> On Jan 5, 2017, at 7:52 AM, Aaron Conole wrote: >> >> >> >>>>> Should we bump the libtool version now? We're nearing a release, so >>>>> it's about the right time. >>>

Re: [ovs-dev] [PATCH] netdev-dpdk: Assign socket id according to device's numa id

2017-01-11 Thread Aaron Conole
Binbin Xu writes: > After the commit "55e075e65ef9ecbd70e5e0fada2704c3d73724d8 > netdev-dpdk: Arbitrary 'dpdk' port naming", we could hotplug > attach DPDK ports specified via the 'dpdk-devargs' option. > > But the socket id of DPDK ports can't be assigned correctly, > it is always 0. The socket

[ovs-dev] [PATCH 1/2] libX.pc: use the correct output directory

2017-01-16 Thread Aaron Conole
: `./configure --enable-shared`). Fixes: commit e72e07a97e95 ("lib: Add support for pkgconfig for libovsdb.") Signed-off-by: Aaron Conole --- RFC to patch: Introduce this after catching the error while doing some testing. lib/automake.mk | 4 ++-- ofproto/automake.mk | 2 +- ovsdb/a

[ovs-dev] [PATCH 0/2] Library support: refactor libtool versions

2017-01-16 Thread Aaron Conole
uts. This corrects an existing erroneous behavior in the system. Patch 2 introduces the versioning and ABI documentation. Aaron Conole (2): libX.pc: use the correct output directory libX: add new release / version info tags Documentation/automake.mk | 1 + ...

[ovs-dev] [PATCH 2/2] libX: add new release / version info tags

2017-01-16 Thread Aaron Conole
. ex: $ ldd /path/to/utility linux-vdso.so.1 (0x7ffe92cf6000) libopenvswitch-2.so.6 => /lib64/libopenvswitch-2.so.6 (0x7f733b7a3000) libssl.so.10 => /lib64/libssl.so.10 (0x7f733b53) ... Note the library name and version information. Signed-off-by:

Re: [ovs-dev] [PATCH 1/2] libX.pc: use the correct output directory

2017-01-19 Thread Aaron Conole
Ben Pfaff writes: > On Mon, Jan 16, 2017 at 02:06:26PM -0500, Aaron Conole wrote: >> When the ovsdb library pkgconfig changes were introduced, they placed >> generated output in the src directory. This is incorrect, however, as >> the output files should actually b

Re: [ovs-dev] [PATCH 1/3] rhel: Fix ifdown for OVSDPDKBond.

2017-01-26 Thread Aaron Conole
Daniele Di Proietto writes: > The OVSDPDKBond case wasn't handled in the rhel ifdown script. > > Fixes: f6bf8880613a ("rhel: Add support DPDK port creation via network > scripts") > Signed-off-by: Daniele Di Proietto > -

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

2017-01-26 Thread Aaron Conole
Daniele Di Proietto writes: > On 25/01/2017 00:01, "Ansis Atteka" wrote: > >>On Jan 25, 2017 4:22 AM, "Daniele Di Proietto" wrote: >> >>Current SELinux policy in RHEL and Fedora doesn't allow the creation of >>TAP devices. >> >>A tap device is used by dpif-netdev to create internal devices. >>

[ovs-dev] [PATCH v2] libX.pc: use the correct output directory

2017-01-26 Thread Aaron Conole
: `./configure --enable-shared`). Fixes: commit e72e07a97e95 ("lib: Add support for pkgconfig for libovsdb.") Signed-off-by: Aaron Conole --- v1->v2: Remove unneeded reference to builddir RFC to patch: Introduce this after catching the error while doing some testing. lib/automa

Re: [ovs-dev] [PATCH v2] libX.pc: use the correct output directory

2017-01-26 Thread Aaron Conole
Aaron Conole writes: > When the ovsdb library pkgconfig changes were introduced, they placed > generated output in the src directory. This is incorrect, however, as > the output files should actually be placed in the build directory. It > is only seen when running `make dist

[ovs-dev] [RFC] rhel/ifup: support vhost-user client mode

2017-02-06 Thread Aaron Conole
ecause the OVSDPDKVhostUserPort type already has an appropriate entry. Signed-off-by: Aaron Conole --- NOTE: I haven't tested this yet. I'll submit formally once I do. rhel/README.RHEL.rst| 9 + rhel/etc_sysconfig_network-scripts_ifup-ovs | 10 +-

Re: [ovs-dev] [PATCH] rhel-systemd: Restart openvswitch service if a daemon crashes

2017-02-07 Thread Aaron Conole
Is it possible to add some of the information from the commit message to the README.RHEL.rst file, so that we can point people to it as expected behavior? Otherwise, Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openv

Re: [ovs-dev] [PATCH] dpdk: Fixes memory leak in dpdk_init__().

2017-02-10 Thread Aaron Conole
st > free new_val when it is no longer needed. > > Fixes: 01961bbdd34a ("dpdk: New module with some code from netdev-dpdk.") > CC: Daniele Di Proietto > Signed-off-by: nickcooper-zhangtonghao > --- Great catch! Reviewed-by: Aaron Conole

[ovs-dev] [PATCH] rhel/ifup: support vhost-user client mode

2017-02-10 Thread Aaron Conole
From: Aaron Conole This adds support for ifup to configure client-mode sockets by exposing two new variables $OVS_PORT_MODE and $OVS_PORT_PATH to the ifcfg scripts. When OVS_PORT_MODE is set to 'client', the OVS_PORT_PATH will be passed as the vhost-server-path option. No change is

Re: [ovs-dev] [RFC] rhel/ifup: support vhost-user client mode

2017-02-10 Thread Aaron Conole
Aaron Conole writes: > This adds support for ifup to configure client-mode sockets by exposing > two new variables $OVS_PORT_MODE and $OVS_PORT_PATH to the ifcfg > scripts. When OVS_PORT_MODE is set to 'client', the OVS_PORT_PATH will > be passed as the vhost-server-path

Re: [ovs-dev] [PATCH 3/3] rhel: Fix ifup and ifdown after DPDK naming change.

2017-02-14 Thread Aaron Conole
Daniele Di Proietto writes: > On 02/02/2017 12:48, "Ben Pfaff" wrote: > >>On Tue, Jan 24, 2017 at 06:21:53PM -0800, Daniele Di Proietto wrote: >>> Names like dpdk0 and dpdk1 are not enough to identify a DPDK interface. >>> We could update README.RHEL.rst and add >>> >>> OVS_EXTRA='set Interface

Re: [ovs-dev] [PATCH] netdev-dpdk: Add support for DPDK 17.02

2017-02-15 Thread Aaron Conole
Ciara Loftus writes: > This commit announces support for DPDK 17.02. Compatibility with DPDK > v16.11 is not broken yet thanks to no code changes being needed for the > upgrade. > > Signed-off-by: Ciara Loftus > --- Is it possible to make this reflect an either 16.11 or 17.02 support instead of

[ovs-dev] [PATCH] ovs-ctl: allow passing user:group to daemons

2017-02-21 Thread Aaron Conole
The Open vSwitch daemons allow passing --user user[:group] to allow spawning under different user privileges. ovs-ctl now accepts --ovs-user in the same form to pass this argument on, as well as create databases and data directories with the appropriate privileges. Signed-off-by: Aaron Conole

[ovs-dev] [PATCH] ovs-tcpdump: Set mirror port mtu

2017-02-22 Thread Aaron Conole
quot;) Reported-by: Dan Williams Signed-off-by: Aaron Conole --- utilities/ovs-tcpdump.in | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index a6e4ada..f0c0774 100755 --- a/utilities/ovs-tcpdump.in +++

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

2017-02-28 Thread Aaron Conole
Daniele Di Proietto writes: > On 26/01/2017 12:35, "Ansis Atteka" wrote: >> >> >>On 26 January 2017 at 21:24, Aaron Conole >> wrote: >> >>Daniele Di Proietto writes: >> >>> On 25/01/2017 00:01, "Ansis Atteka"

<    1   2   3   4   5   6   7   8   9   10   >