Mike Pattrick writes:
> This patch adopts the proposed RFC 6935 by allowing null UDP checksums
> even if the tunnel protocol is IPv6. This is already supported by Linux
> through the udp6zerocsumtx tunnel option. It is disabled by default and
> IPv6 tunnels are flagged as requiring a checksum, bu
Mike Pattrick writes:
> On Tue, Feb 20, 2024 at 8:56 PM Mike Pattrick wrote:
>>
>> This patch adopts the proposed RFC 6935 by allowing null UDP checksums
>> even if the tunnel protocol is IPv6. This is already supported by Linux
>> through the udp6zerocsumtx tunnel option. It is disabled by defa
un():
>
> Signed-off-by: Daniel Ding
> ---
LGTM for the linux side - maybe Alin might check the windows side.
When you post v2 you can keep my
Reviewed-by: Aaron Conole
> utilities/ovs-tcpdump.in | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/uti
Adrian Moreno writes:
> On 2/20/24 19:06, Aaron Conole wrote:
>> Eelco Chaudron writes:
>>
>>> On 19 Feb 2024, at 19:57, Aaron Conole wrote:
>>>
>>>> Eelco Chaudron writes:
>>>>
>>>>> On 12 Feb 2024, at 15:15, Aar
Adrian Moreno writes:
> On 2/16/24 16:28, Aaron Conole wrote:
>> Normally a spawned process under OVS is given a SIGTERM when the test
>> ends as part of cleanup. However, in case the process is still lingering
>> for some reason, we also send a SIGKILL to force it down fas
Eelco Chaudron writes:
> On 20 Feb 2024, at 22:47, Aaron Conole wrote:
>
>> From: Kevin Sprague
>>
>> During normal operations, it is useful to understand when a particular flow
>> gets removed from the system. This can be useful when debugging performance
>>
Resurrecting a feature from 2022, introduce a probe that indicates
why a particular flow may be selected for eviction during revalidation
and includes the flow information.
The second patch tells fedora builds to include the USDT probe support
on Fedora systems.
Aaron Conole (1):
rhel: Enable
/usdt-scripts/flow_reval_monitor.py)
which serves as a demonstration of how the new USDT probe might be used
going forward.
Acked-by: Han Zhou
Signed-off-by: Kevin Sprague
Co-authored-by: Aaron Conole
Signed-off-by: Aaron Conole
---
v8 -> v9: Reorganized the flow delete reasons enum
All supported versions of Fedora do package libbpf, so it
makes sense to enable USDT support.
Acked-by: Simon Horman
Acked-by: Eelco Chaudron
Signed-off-by: Aaron Conole
---
rhel/openvswitch-fedora.spec.in | 8
1 file changed, 8 insertions(+)
diff --git a/rhel/openvswitch
Simon Horman writes:
> + Xavier
>
> On Thu, Aug 31, 2023 at 02:52:59PM -0400, Aaron Conole wrote:
>> Ilya Maximets writes:
>>
>> > On 8/31/23 09:15, Frode Nordahl wrote:
>> >> On Wed, Aug 30, 2023 at 9:30 PM Paolo Valerio wrote:
>> >>>
so it is critical to preserve metering, whether we are
doing a plain old send to controller, or a continuation.
Fixes: 77ab5fd2a95b ("Implement serializing the state of packet traversal in
"continuations".")
Reported-at: https://issues.redhat.com/browse/FDP-455
Tested-by:
David Marchand writes:
> On Tue, Mar 7, 2023 at 2:06 PM Aaron Conole wrote:
>>
>> Open vSwitch generally tries to let the underlying operating system
>> managed the low level details of hardware, for example DMA mapping,
>> bus arbitration, etc. However, when
Flavio Leitner writes:
> On Tue, Mar 07, 2023 at 02:32:04PM +0100, David Marchand wrote:
>> On Tue, Mar 7, 2023 at 2:06 PM Aaron Conole wrote:
>> >
>> > Open vSwitch generally tries to let the underlying operating system
>> > managed the low level details
Robin Jarry writes:
> Some control protocols are used to maintain link status between
> forwarding engines (e.g. LACP). When the system is not sized properly,
> the PMD threads may not be able to process all incoming traffic from the
> configured Rx queues. When a signaling packet of such protoco
: Simon Horman
Signed-off-by: Aaron Conole
---
v1->v2: update daemon-windows for daemon_become_new_user
v2->v3: update daemon-windows for daemon_start
change log messages to be clearer
update the manpage to provide example of why
one would want the flag
0-day Robot writes:
> Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> WARNING: Line is 98 chara
Flavio Leitner writes:
> On Wed, Mar 08, 2023 at 05:37:11PM -0500, Aaron Conole wrote:
>> Open vSwitch generally tries to let the underlying operating system
>> managed the low level details of hardware, for example DMA mapping,
>> bus arbitration, etc. However, when using
: Simon Horman
Signed-off-by: Aaron Conole
---
NEWS | 4
lib/daemon-unix.c | 31 +++
lib/daemon-windows.c | 6 --
lib/daemon.c | 2 +-
lib/daemon.h | 4 ++--
ovsdb/ovsdb
Ilya Maximets writes:
> On 3/16/23 13:00, Aaron Conole wrote:
>> Open vSwitch generally tries to let the underlying operating system
>> managed the low level details of hardware, for example DMA mapping,
>> bus arbitration, etc. However, when using DPDK, the underlyin
Hi Ales,
Ales Musil writes:
> Use the backtrace functions that is provided by libc,
> this allows us to get backtrace that is independent of
> the current memory map of the process. Which in turn can
> be used for debugging/tracing purpose. The backtrace
> is not 100% accurate due to various opt
James Raphael Tiovalen writes:
> This commit addresses several high and medium-impact Coverity defects by
> fixing several possible null-pointer dereferences and potentially
> uninitialized variables.
>
> There were cases when crashes were encountered when some null pointers
> were dereferenced.
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tests: add openvswitch selftest suite")
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/openvswitch/ovs-dpctl.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
b/tools/testing/selftests/net/openvswitch/ovs
Hrrm... looks like I need to double check the filters on patch subject metadata.
0-day Robot writes:
> Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecti
The upcall socket interface can be exercised now to make sure that
future feature adjustments to the field can maintain backwards
compatibility.
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/openvswitch.sh | 38 -
.../selftests/net/openvswitch/ovs-dpctl.py| 138
apath, and then
dumping any upcalls that are received. Compare with expected ARP
upcall via arping.
Aaron Conole (3):
selftests: openvswitch: add interface support
selftests: openvswitch: add flow dump support
selftests: openvswitch: add support for upcall testing
.../selftests/net/openvs
Add a basic set of fields to print in a 'dpflow' format. This will be
used by future commits to check for flow fields after parsing, as
well as verifying the flow fields pushed into the kernel from
userspace.
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py
Includes an associated test to generate netns and connect
interfaces, with the option to include packet tracing.
This will be used in the future when flow support is added
for additional test cases.
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/openvswitch.sh | 55
Paolo Valerio writes:
> Connections that need to be removed, e.g. while forcing a direction,
> were invalidated forcing them to be expired.
> This is not actually needed, as it's typically a one-time
> operation.
> The patch replaces a call to conn_force_expire() with a call to
> conn_clean().
>
ed. Dynamic loading usually triggers
> a call to malloc(3). If you need certain calls to these two
> functions to not allocate memory (in signal handlers, for
> example), you need to make sure libgcc is loaded beforehand
>
> Reported-at: https://bugzilla.redhat.com/217776
Paolo Valerio writes:
> Ilya Maximets writes:
>
>> On 5/4/23 19:21, Paolo Valerio wrote:
>>> Ilya Maximets writes:
>>>
On 4/19/23 20:40, Paolo Valerio wrote:
> During the creation of a new connection, there's a chance both key and
> rev_key end up having the same hash. This is mor
ed. Dynamic loading usually triggers
> a call to malloc(3). If you need certain calls to these two
> functions to not allocate memory (in signal handlers, for
> example), you need to make sure libgcc is loaded beforehand
>
> Reported-at: https://bugzilla.redhat.com/2177760
> Sig
Robin Jarry writes:
> Some control protocols are used to maintain link status between
> forwarding engines (e.g. LACP). When the system is not sized properly,
> the PMD threads may not be able to process all incoming traffic from the
> configured Rx queues. When a signaling packet of such protoco
isting vport
> alloc and free functions to solve this.
>
> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on failure")
> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets")
> Signed-off-by: Eelco Chaudron
> ---
Acked-by:
isting vport
> alloc and free functions to solve this.
>
> Fixes: 95637d91fefd ("net: openvswitch: release vport resources on failure")
> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets")
> Signed-off-by: Eelco Chaudron
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
02, used:0.000s, flags:SP.,
actions:hash(sym_l4(0)),recirc(0xd)
Some performance testing with no GRO/GSO, two veths, single flow:
hash(l4(0)): 4.35 GBits/s
hash(l4_sym(0)): 4.24 GBits/s
Signed-off-by: Aaron Conole
---
include/uapi/linux/openvswitch.h | 1 +
net/openvswitch/a
o have
> the version be aligned with the downstream one.
>
> Signed-off-by: Timothy Redaelli
> ---
Thanks for this work.
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ned that the userspace
conntrack now supports matching SCTP l4 data.
If you do spin a v4 with that change, you can keep my:
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
95637d91fefd ("net: openvswitch: release vport resources on
>> >> failure")
>> >> Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall
>> >> packets")
>> >> Signed-off-by: Eelco Chaudron
>> >> -
Ilya Maximets writes:
> On 6/15/23 19:49, Paolo Valerio wrote:
>> Ilya Maximets writes:
>>
>>> On 6/14/23 21:08, Ilya Maximets wrote:
>>>> On 6/14/23 20:11, Paolo Valerio wrote:
>>>>> Ilya Maximets writes:
>>>>>
>>
Martin Kennelly writes:
> Hey ovs community,
>
> I am a developer working on ovn-kubernetes and I want to programmatically
> consume long poll information
> i.e:
> ovs|00211|timeval(handler25)|WARN|Unreasonably long 52388ms poll interval
> (752ms user, 209ms system)
>
> This is currently expose
Adrian Moreno writes:
> On 6/19/23 10:36, Eelco Chaudron wrote:
>> On 16 Jun 2023, at 19:19, Aaron Conole wrote:
>>
>>> Martin Kennelly writes:
>>>
>>>> Hey ovs community,
>>>>
>>>> I am a developer working on ovn-kuberne
Eelco Chaudron writes:
> Add additional error coverage counters for dpif operation failures.
> This could help to quickly identify netlink problems when communicating
> with the OVS kernel module.
>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2070630
> Signed-off-by: Eelco Chaudron
Eelco Chaudron writes:
> On 20 Jun 2023, at 16:17, Aaron Conole wrote:
>
>> Eelco Chaudron writes:
>>
>>> Add additional error coverage counters for dpif operation failures.
>>> This could help to quickly identify netlink problems when communic
Ilya Maximets writes:
> On 6/20/23 16:10, Aaron Conole wrote:
>> Adrian Moreno writes:
>>
>>> On 6/19/23 10:36, Eelco Chaudron wrote:
>>>> On 16 Jun 2023, at 19:19, Aaron Conole wrote:
>>>>
>>>>> Martin Kennelly writes:
>>&g
Eelco Chaudron writes:
> On 20 Jun 2023, at 16:57, Ilya Maximets wrote:
>
>> On 6/20/23 16:10, Aaron Conole wrote:
>>> Adrian Moreno writes:
>>>
>>>> On 6/19/23 10:36, Eelco Chaudron wrote:
>>>>> On 16 Jun 2023, at 19:19,
We got some warnings on this file due to line lengths. Maybe we should
exclude yml from the line length check. WDYT?
> 3 files changed, 39 insertions(+), 19 deletions(-)
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https:/
Dumitru Ceara writes:
> On 6/22/23 13:56, Aaron Conole wrote:
>> Dumitru Ceara writes:
>>
>>> This avoids manual intervention when upstream ovn-kubernetes changes
>>> its dependency versions.
>>>
>>> Signed-off-by: Patryk Diak
>>> C
Dumitru Ceara writes:
> As far as I can tell they're used mostly for CI job definitions and
> these tend to result in long lines.
>
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-dev/2023-June/405796.html
> Suggested-by: Aaron Conole
> Signed-off-by: Dumi
Flavio Leitner writes:
> Today the exit code refers to the execution of the change
> in the database. However, when not using parameter --no-wait
> (default), the ovs-vsctl also checks if OVSDB transactions
> are successfully recorded and reload by ovs-vswitchd. In this
> case, an error message i
Ilya Maximets writes:
> On 6/27/23 14:36, 0-day Robot wrote:
>> Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out
>> your patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting. See the details below.
>>
>>
>> git-am:
>> error: F
Flavio Leitner writes:
> On 6/26/23 16:48, Aaron Conole wrote:
>> Flavio Leitner writes:
>>
>>> Today the exit code refers to the execution of the change
>>> in the database. However, when not using parameter --no-wait
>>> (default), the ovs-vsctl
This is a simple ipv4 bidirectional connectivity test.
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/openvswitch.sh | 40 +++
1 file changed, 40 insertions(+)
diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh
b/tools/testing/selftests/net
rping utility. This lets us display flows, add some basic
output flows with simple matches, and test against a known good
forwarding case.
Signed-off-by: Aaron Conole
---
NOTE: 3 lines flag the line-length checkpatch warning, but there didn't
seem to bea good way of breaking the lines smalle
with actions. This
can be improved overtime to include regression testing, etc.
Aaron Conole (4):
selftests: openvswitch: add an initial flow programming case
selftests: openvswitch: add a test for ipv4 forwarding
selftests: openvswitch: add basic ct test case parsing
selftests: openvswitch
Forwarding via ct() action is an important use case for openvswitch, but
generally would require using a full ovs-vswitchd to get working. Add a
ct action parser for basic ct test case.
Signed-off-by: Aaron Conole
---
NOTE: 3 lines flag the line-length checkpatch warning, but there didnt
Building on the previous work, add a very simplistic NAT case
using ipv4. This just tests dnat transformation
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/openvswitch.sh | 64 +++
.../selftests/net/openvswitch/ovs-dpctl.py| 60 +
2 files
Simon Horman writes:
> On Wed, Jun 28, 2023 at 12:27:10PM -0400, Aaron Conole wrote:
>> The openvswitch selftests currently contain a few cases for managing the
>> datapath, which includes creating datapath instances, adding interfaces,
>> and doing some basic feature / u
ately the robot
doesn't build series_* branches on appveyor (maybe something to look
at). We may need a workaround for windows - but I'll let Alin take a
look.
Acked-by: Aaron Conole
> v2:
> Followed Aaron's suggestion to return EX_DATAERR.
>
> NEWS
Chandan Somani writes:
> A list approach lets us single out each flagged word and
> provide more useful details, like spelling suggestions.
> This will be used in an upcoming patch.
>
> Signed-off-by: Chandan Somani
> ---
> utilities/checkpatch.py | 12 +---
> 1 file changed, 9 insertio
Chandan Somani writes:
> This wil lbe useful for correcting possible spelling
> mistakes with ease. Suggestions limited to 3 at first,
> but configurable in the future
>
> Signed-off-by: Chandan Somani
> ---
This is a really useful feature! Thanks!
Acked-by: Aaron Con
Chandan Somani writes:
> This will help narrow down spelling errors that are in the
> commit subject
>
> Signed-off-by: Chandan Somani
> ---
> utilities/checkpatch.py | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
> index 57f7baf46
inted, then it is likely that the change was not
> functional anyway.
>
> Reported-at: https://bugzilla.redhat.com/1731553
> Signed-off-by: Flavio Leitner
> ---
Still looks good to me.
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Eric Garver writes:
> This adds an explicit drop action. This is used by OVS to drop packets
> for which it cannot determine what to do. An explicit action in the
> kernel allows passing the reason _why_ the packet is being dropped. We
> can then use perf tracing to match on the drop reason.
>
>
Hi Shaohua,
Some nits as well (before you send v3). I will review the code in v3.
wushao...@chinatelecom.cn writes:
> From: Shaohua Wu
>
> The icmp_id maybe conflicts in snat
> Description:
> If multiple devices send icmp packets with the same icmp_id,
> the sip of the packets changes to the s
"冮晔维" writes:
> From: gangyewei
> Fix bug of ovs-tcpdump, which will cause megaflow action wrong.
> As use ovs-tcpdump will add mipxxx NIC, and this NIC has IPv6 address by
> default.
> For vxlan topology, mipxxx will be treated as tunnel port, and will got error
> actions.
> For detail discus
ce of being dropped because the PMD cores
> cannot keep up with regular traffic.
>
> The choice of protocols is limited on purpose. This is not meant to be
> configurable by users. Some limited configurability could be considered
> in the future but it would expose to more potential issues if users are
> accidentally redirecting all traffic in the isolated queue.
>
> Cc: Anthony Harivel
> Cc: Christophe Fontaine
> Cc: David Marchand
> Cc: Ilya Maximets
> Signed-off-by: Robin Jarry
> Acked-by: Kevin Traynor
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Adrian Moreno writes:
> On 6/28/23 18:27, Aaron Conole wrote:
>> Forwarding via ct() action is an important use case for openvswitch, but
>> generally would require using a full ovs-vswitchd to get working. Add a
>> ct action parser for basic ct test case.
>>
Adrian Moreno writes:
> On 6/28/23 18:27, Aaron Conole wrote:
>> Building on the previous work, add a very simplistic NAT case
>> using ipv4. This just tests dnat transformation
>> Signed-off-by: Aaron Conole
>
> Hi Aaron,
>
> I know that the goal is not to
Chandan Somani writes:
> Single out flagged words and allow for more useful
> details, like spelling suggestions. Fixed syntax
> error from v1
>
> Signed-off-by: Chandan Somani
> ---
Thanks!
Acked-by: Aaron Conole
> utilities/checkpatch.py | 12 +---
> 1 fi
#x27;Subject'] or not mail['Subject'].strip():
> +if mail['Subject']:
> +mail.replace_header('Subject', sys.argv[-1])
> +else:
> + mail.add_header('Subject', sys.argv[-1]
Eric Garver writes:
> On Mon, Jul 10, 2023 at 06:51:19PM +0200, Ilya Maximets wrote:
>> On 7/8/23 00:06, Jakub Kicinski wrote:
>> > On Fri, 7 Jul 2023 18:04:36 +0200 Ilya Maximets wrote:
>> That already exists, right? Johannes added it in the last release for
>> WiFi.
>> >>>
>> >>> I
Viacheslav Galaktionov writes:
> On 7/14/23 19:11, Ilya Maximets wrote:
>> On 7/13/23 11:26, Viacheslav Galaktionov via dev wrote:
>>> Currently, if the user wants to track related connections, they have to
>>> specify a helper in all CT actions, which contradicts the behaviour
>>> described in t
Xin Long writes:
> With the OVS upcall, the original ct in the skb will be dropped, and when
> the skb comes back from userspace it has to create a new ct again through
> nf_conntrack_in() in either OVS __ovs_ct_lookup() or TC tcf_ct_act().
>
> However, the new ct will not be able to have the exp
master info to flower parsing via
> tc_skb_cb is also not possible (tc_skb_cb size is not big enough).
>
> The simple and clear fix is to not remove the exp at the 1st flow, namely,
> not set IPS_CONFIRMED in tmpl when commit is not set in act_ct.
>
> Reported-by: Shuang L
es.
>
> This patch allows exp not to be removed by setting IPS_CONFIRMED
> in the status of the tmpl.
>
> Signed-off-by: Xin Long
> ---
LGTM
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Xin Long writes:
> By not setting IPS_CONFIRMED in tmpl that allows the exp not to be removed
> from the hashtable when lookup, we can simplify the exp processing code a
> lot in openvswitch conntrack.
>
> Signed-off-by: Xin Long
> ---
Acke
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
> Signed-off-by: Mike Pattrick
>
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> OVS configuration is based on port names and OpenFlow port numbers.
> Names are stored in the database and translated later to OF ports.
> On the datapath level, each port has a name and a datapath port number.
> Port name in the database has to match datapath port name, u
Faicker Mo via dev writes:
> The warning message is
> |1|tc(handler4)|WARN|can't offload rewrite of IP/IPV6 with ip_proto: X.
>
> Some ip protocols like ipip, gre and so on do not need the recalculation of
> the checksum of themself except for the ip header checksum recalculation
> in the ip
to
take incase zeroconf is setup for ipv4 on the system, but hopefully that
is managed separately.
> Signed-off-by: simon
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ilya Maximets writes:
> On 7/20/23 16:55, Aaron Conole wrote:
>> Ilya Maximets writes:
>>
>>> OVS configuration is based on port names and OpenFlow port numbers.
>>> Names are stored in the database and translated later to OF ports.
>>> On the
Adrian Moreno writes:
> There is currently a gap in drop visibility in the openvswitch module.
> This series tries to improve this by adding a new drop reason subsystem
> for OVS.
>
> Apart from adding a new drop reasson subsystem and some common drop
> reasons, this series takes Eric's prelimina
Adrian Moreno writes:
> From: Eric Garver
>
> This adds an explicit drop action. This is used by OVS to drop packets
> for which it cannot determine what to do. An explicit action in the
> kernel allows passing the reason _why_ the packet is being dropped or
> zero to indicate no particular erro
Adrian Moreno writes:
> Make ovs-dpctl.py support explicit drops as:
> "drop" -> implicit empty-action drop
> "drop(0)" -> explicit non-error action drop
> "drop(42)" -> explicit error action drop
>
> Signed-off-by: Adrian Moreno
> ---
> .../selftests/net/openvswitch/openvswitch.sh | 25 ++
Adrian Moreno writes:
> Use drop reasons from include/net/dropreason-core.h when a reasonable
> candidate exists.
>
> Signed-off-by: Adrian Moreno
> ---
> net/openvswitch/actions.c | 17 ++---
> net/openvswitch/conntrack.c | 3 ++-
> net/openvswitch/drop.h | 6 ++
> 3 f
Simon Jones writes:
> Hi Aaron,
>
> Thanks for your suggestion. This is my opinion as below.
>
>
> Simon Jones
>
> Aaron Conole 于2023年7月20日周四 23:41写道：
>
> Hi Simon,
>
> Thanks for the contribution!
>
> Simon Jones writes:
>
> > From:
801 - 900 of 1897 matches
Mail list logo
