Adrian Moreno writes:
> On 6/28/23 18:27, Aaron Conole wrote:
>> The openvswitch self-tests can test much of the control side of
>> the module (ie: what a vswitchd implementation would process),
>> but the actual packet forwarding cases aren't supported, making
>&
"ipv4(src=192.168.1.1/24)"
"ipv4(src=192.168.1.1/255.255.255.0)"
"tcp(src=8080)" -> mask = 0x
"tcp(src=8080/0xf0f0)"
Signed-off-by: Adrian Moreno
Acked-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 96 ---
1 file c
This is a simple ipv4 bidirectional connectivity test.
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/openvswitch.sh | 40 +++
1 file changed, 40 insertions(+)
diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh
b/tools/testing/selftests/net
Building on the previous work, add a very simplistic NAT case
using ipv4. This just tests dnat transformation
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/openvswitch.sh | 64
.../selftests/net/openvswitch/ovs-dpctl.py| 75 +++
2 files
Forwarding via ct() action is an important use case for openvswitch, but
generally would require using a full ovs-vswitchd to get working. Add a
ct action parser for basic ct test case.
Signed-off-by: Aaron Conole
---
NOTE: 3 lines flag the line-length checkpatch warning, but there didnt
t key masks
Aaron Conole (4):
selftests: openvswitch: add an initial flow programming case
selftests: openvswitch: add a test for ipv4 forwarding
selftests: openvswitch: add basic ct test case parsing
selftests: openvswitch: add ct-nat test case with ipv4
Adrian Moreno (1):
selftests: openvs
rping utility. This lets us display flows, add some basic
output flows with simple matches, and test against a known good
forwarding case.
Signed-off-by: Aaron Conole
---
NOTE: 3 lines flag the line-length checkpatch warning, but there didn't
seem to bea good way of breaking the lines smalle
Adrian Moreno writes:
> On 7/28/23 13:59, Aaron Conole wrote:
>> Building on the previous work, add a very simplistic NAT case
>> using ipv4. This just tests dnat transformation
>> Signed-off-by: Aaron Conole
>> ---
>> .../selftests/net
Ilya Maximets writes:
> On 7/20/23 21:18, Aaron Conole wrote:
>> Ilya Maximets writes:
>>
>>> On 7/20/23 16:55, Aaron Conole wrote:
>>>> Ilya Maximets writes:
>>>>
>>>>> OVS configuration is based on port names and OpenFlow port
mit...@outlook.com writes:
> From: Lin Huang
>
> OvS has supported packet-per-second policer which can be set at ingress
> and egress side in kernel datapath. But the userspace datapath doesn't
> support for ingress and egress packet-per-second policing now.
>
> So, this patch add support for use
mit...@outlook.com writes:
> From: Lin Huang
>
> OvS has supported packet-per-second policer which can be set at ingress
> and egress side in kernel datapath. But the userspace datapath dosen't
> support for ingress and egress packet-per-second policing now.
>
> So, this patch add support for use
3. Fix error message when invalid bridge is passed
4. Fold in Adrian's patch to support key masks
Aaron Conole (4):
selftests: openvswitch: add an initial flow programming case
selftests: openvswitch: add a test for ipv4 forwarding
selftests: openvswitch: add basic ct test case parsing
rping utility. This lets us display flows, add some basic
output flows with simple matches, and test against a known good
forwarding case.
Signed-off-by: Aaron Conole
Reviewed-by: Adrian Moreno
---
NOTE: 3 lines flag the line-length checkpatch warning, but there didn't
seem to be a g
This is a simple ipv4 bidirectional connectivity test.
Signed-off-by: Aaron Conole
Reviewed-by: Adrian Moreno
---
NOTE: 4 lines flag the line-length checkpatch warning, but there didn't
seem to be a good way of breaking the lines smaller.
.../selftests/net/openvswitch/openvswit
/24)"
"ipv4(src=192.168.1.1/255.255.255.0)"
"tcp(src=8080)" -> mask = 0x
"tcp(src=8080/0xf0f0)"
Signed-off-by: Adrian Moreno
Acked-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 96 ---
1 file changed, 64 insertion
Forwarding via ct() action is an important use case for openvswitch, but
generally would require using a full ovs-vswitchd to get working. Add a
ct action parser for basic ct test case.
Signed-off-by: Aaron Conole
Reviewed-by: Adrian Moreno
---
NOTE: A number of lines flag the line-length
Building on the previous work, add a very simplistic NAT case
using ipv4. This just tests dnat transformation
Signed-off-by: Aaron Conole
---
NOTE: A number of lines flag the line-length checkpatch
warning, but there didnt seem to be a really good
way of breaking the lines smaller
Paolo Abeni writes:
> On Tue, 2023-08-01 at 17:22 -0400, Aaron Conole wrote:
>> The openvswitch selftests currently contain a few cases for managing the
>> datapath, which includes creating datapath instances, adding interfaces,
>> and doing some basic feature / upcall test
aximets
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
;
> Implementation-wise, most of these skb-consuming actions already call
> "consume_skb" internally and return directly from within the
> do_execute_actions() loop so with minimal changes we can assume that
> any skb that exits the loop normally is a packet drop.
>
> Signed
Adrian Moreno writes:
> Add a drop reason for packets that are dropped because an action
> returns a non-zero error code.
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvs
Adrian Moreno writes:
> From: Eric Garver
>
> From: Eric Garver
>
> This adds an explicit drop action. This is used by OVS to drop packets
> for which it cannot determine what to do. An explicit action in the
> kernel allows passing the reason _why_ the packet is being dropped or
> zero to indi
Adrian Moreno writes:
> By using an independent drop reason it makes it easy to ditinguish
nit: distinguish
> between QoS-triggered or flow-triggered drop.
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
> net/openvswitch/actions.c | 2 +-
> net/open
Adrian Moreno writes:
> Use drop reasons from include/net/dropreason-core.h when a reasonable
> candidate exists.
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.
Adrian Moreno writes:
> Make ovs-dpctl.py support explicit drops as:
> "drop" -> implicit empty-action drop
> "drop(0)" -> explicit non-error action drop
I also suggest a test in netlink_checks to make sure drop can't be
followed by additional actions. Something like:
3,drop(0),2
which shou
Adrian Moreno writes:
> Test if the correct drop reason is reported when OVS drops a packet due
> to an explicit flow.
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
___
dev mailing list
d...@openvs
Adrian Moreno writes:
> On 8/8/23 17:02, Aaron Conole wrote:
>> Adrian Moreno writes:
>>
>>> Make ovs-dpctl.py support explicit drops as:
>>> "drop" -> implicit empty-action drop
>>> "drop(0)" -> explicit non-error action dro
Adrian Moreno writes:
> Test explicit drops generate the right drop reason. Also, verify that
> the kernel rejects flows with actions following an explicit drop.
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
___
dev
Adrian Moreno writes:
> Create a new drop reason subsystem for openvswitch and add the first
> drop reason to represent last-action drops.
>
> Last-action drops happen when a flow has an empty action list or there
> is no action that consumes the packet (output, userspace, recirc, etc).
> It is t
The attribute here isn't used by the ovs-vswitchd, so probably why we
never caught an issue before. I'll think about how to improve the
fuzzing on the ovs module. At the very least, maybe we can have some
additional checks in the netlink selftest.
I noticed that since I copied the
wed-by: Johannes Berg
> Reviewed-by: Jiri Pirko
> Signed-off-by: Jakub Kicinski
> ---
Seems the OVS side didn't change from v2 so still:
Reviewed-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Jakub Kicinski writes:
> On Tue, 15 Aug 2023 08:41:50 -0400 Aaron Conole wrote:
>> > Validate the inputes. Now the second command correctly returns:
>>
>> s/inputes/inputs/
>
> Thanks, fixed when applying
>
>> > $ ./cli.py --spec netlin
Paolo Valerio writes:
> From: hepeng
>
> The patch avoids the extra allocation for nat_conn.
> Currently, when doing NAT, the userspace conntrack will use an extra
> conn for the two directions in a flow. However, each conn has actually
> the two keys for both orig and rev directions. This patch
David Marchand writes:
> On Wed, Aug 23, 2023 at 5:35 PM David Marchand
> wrote:
>>
>> Integrate system-traffic.at tests as part of check-dpdk.
>
> CI (thinking of Intel robot) other than GHA might not be too happy
> about this change.
> It is hard to tell what fails in the report I received.
>
Faicker Mo writes:
> Add tc csum offload support of protocols IGMP/UDPLITE/SCTP
>
> Signed-off-by: Faicker Mo
> ---
Acked-by: Aaron Conole
> lib/tc.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/lib/tc.c b/lib/tc.c
> index f49048cda..52a74d
Faicker Mo writes:
> The warning message is
> |1|tc(handler4)|WARN|can't offload rewrite of IP/IPV6 with ip_proto: X.
>
> IPIP and GRE only need the checksum recalculation of the IP header if the
> IP header is rewritten.
>
> Fixes: d6118e628988 ("netdev-tc-offloads: Verify csum flags on dum
David Marchand writes:
> On Fri, Aug 25, 2023 at 1:40 PM Eelco Chaudron wrote:
>> On 23 Aug 2023, at 17:34, David Marchand wrote:
>>
>> > As reported by Ales, net/tap has broken support for checksum offloading.
>> > Fixes have been sent to the DPDK side, but waiting for the fixes, simply
>> > di
possible for these calls to
> `dp_packet_data()` to return NULL.
>
> Signed-off-by: James Raphael Tiovalen
> Reviewed-by: Simon Horman
> ---
Acked-by: Aaron Conole
> lib/dp-packet.c | 15 ++-
> lib/netdev-native-tnl.c | 6 +-
> lib/pcap-file.c
> *parent,
>struct ovsrec_port *port_cfg)
> {
> -struct vsctl_port *port;
> +struct vsctl_port *port = xzalloc(sizeof *port);
Not sure why we moved the assignment to here? I would prefer it be left
in-place and just change the xmalloc to x
James Raphael Tiovalen writes:
> This commit adds various null pointer checks to some files in the `lib`
> and the `ovsdb` directories to fix several Coverity defects. These
> changes are grouped together as they perform similar checks, returning
> early or skipping some action if a null pointer
Faicker Mo via dev writes:
> The warning message is
> |1|tc(handler4)|WARN|can't offload rewrite of IP/IPV6 with ip_proto: X.
>
> IPIP and GRE only need the checksum recalculation of the IP header if the
> IP header is rewritten.
>
> Fixes: d6118e628988 ("netdev-tc-offloads: Verify csum flags
work.ozlabs.org/project/openvswitch/patch/20201129033255.64647-2-hepeng.0...@bytedance.com/
>
> Signed-off-by: Peng He
> Co-authored-by: Paolo Valerio
> Signed-off-by: Paolo Valerio
> ---
Thanks Paolo and Peng!
Acked-by: Aaron Conole
> v2:
> - use enum value instead of bool (Aaron).
&g
Eelco Chaudron writes:
> This patch adds an utility that can be used to determine if
> an issue is related to a lack of Linux kernel resources.
>
> This tool is also featured in a Red Hat developers blog article:
>
>
> https://developers.redhat.com/articles/2023/07/24/troubleshooting-open-vswi
Ales Musil writes:
> The SCTP protocol ports were excluded from
> the netlink encoding. Which resulted in the
> lookup failure in kernel, leading to the entry
> not being flushed. Allow the flush of SCTP protocol
> based on port numbers.
>
> Signed-off-by: Ales Musil
&
gt; use them in the existing tests.
>
> Signed-off-by: David Marchand
> ---
Acked-by: Aaron Conole
> tests/system-common-macros.at| 12
> tests/system-offloads-traffic.at | 6 +++---
> tests/system-traffic.at | 32
ut these are not available in Ubuntu 22.04 image.
>
> This should be fixed by GitHub, but until new images are available
> reducing ASLR entropy manually to 28 bits to make builds work.
>
> Reported-at: https://github.com/actions/runner-images/issues/9491
> Signed-off-by: Ilya Maximets
>
Ilya Maximets writes:
> Currently, ovs-vswitchd is subscribed to all the routing changes in the
> kernel. On each change, it marks the internal routing table cache as
> invalid, then resets it and dumps all the routes from the kernel from
> scratch. The reason for that is kernel routing updates
Ilya Maximets writes:
> On 3/7/24 18:25, Aaron Conole wrote:
>> Open vSwitch supports the ability to invoke a controller action by way
>> of a sample action with a specified meter. In the normal case, this
>> sample action is transparently generated during xlate processi
Ilya Maximets writes:
> On 3/19/24 20:56, Aaron Conole wrote:
>> Ilya Maximets writes:
>>
>>> Currently, ovs-vswitchd is subscribed to all the routing changes in the
>>> kernel. On each change, it marks the internal routing table cache as
>>> invali
Handle route updates more robustly.")
> Fixes: ea83a2fcd0d3 ("lib: Show tunnel egress interface in ovsdb")
> Reported-at: https://github.com/openvswitch/ovs-issues/issues/185
> Reported-at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2022-October/052091.html
> Signed-off-by: Ilya Maximets
> ---
Thanks!
Acked-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
so it is critical to preserve metering, whether we are
doing a plain old send to controller, or a continuation.
Fixes: 77ab5fd2a95b ("Implement serializing the state of packet traversal in
"continuations".")
Reported-at: https://issues.redhat.com/browse/FDP-455
Tested-by:
ket loss, time 1061ms
In this case, the first ping request receives the FRAG_NEEDED message and
a local routing exception is created.
Reported-at: https://issues.redhat.com/browse/FDP-164
Fixes: 58264848a5a7 ("openvswitch: Add vxlan tunneling support.")
Signed-off-by: Aaron Conole
---
Ilya Maximets writes:
> On 3/22/24 14:40, Aaron Conole wrote:
>> Open vSwitch supports the ability to invoke a controller action by way
>> of a sample action with a specified meter. In the normal case, this
>> sample action is transparently generated during xlate processi
Eelco Chaudron writes:
> On 22 Mar 2024, at 20:06, Aaron Conole wrote:
>
>> Open vSwitch is originally intended to switch at layer 2, only dealing with
>> Ethernet frames. With the introduction of l3 tunnels support, it crossed
>> into the realm of needing to care
Aaron Conole writes:
> Ilya Maximets writes:
>
>> On 3/22/24 14:40, Aaron Conole wrote:
>>> Open vSwitch supports the ability to invoke a controller action by way
>>> of a sample action with a specified meter. In the normal case, this
>>> sample action
Eelco Chaudron writes:
> On 25 Mar 2024, at 13:37, Ilya Maximets wrote:
>
>> On 3/25/24 13:22, Aaron Conole wrote:
>>> Eelco Chaudron writes:
>>>
>>>> On 22 Mar 2024, at 20:06, Aaron Conole wrote:
>>>>
>>>>> Open vSwitch
Cheng Li writes:
> Force expire a connection and then create new connection of the same
> tuple(cmap hash). This makes ct->conns cmap operation expensive(
> within ct->ct_lock).
>
> This patch cover the scenario by doing the clean immediately instead
> of setting expire. Also this patch fix ct_cl
Daniel Ding writes:
> When I try filter geneve protocol with a vlan, the warning message
> occurs that tell me the kernel cann't support this combination.
^ can't
>
> $ ovs-tcpdump -i eth2 -nne vlan 10 and geneve
> Warning: Kernel filter failed: Invalid argument
>
mit...@outlook.com writes:
> From: miter
>
> Ofproto_class_find__() may return NULL, and dereference it to cause
> segfault.
>
> Tested-by: Zhang YuHuang
> Signed-off-by: Lin Huang
> ---
I guess that type_run and type_wait aren't flagged this way because the
only users walk the ofproto types l
Felix Huettner via dev writes:
> Extract checking for a given kernel version to a separate function.
> It will be used also in the next patch.
>
> Acked-by: Mike Pattrick
> Acked-by: Eelco Chaudron
> Signed-off-by: Felix Huettner
> ---
Acked-by: Aaron Conole
&g
By: Luca Czesla
> Signed-off-by: Luca Czesla
> Co-Authored-By: Max Lamprecht
> Signed-off-by: Max Lamprecht
> Signed-off-by: Felix Huettner
> ---
Acked-by: Aaron Conole
Thanks!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tutorials/ovs-conntrack.rst | 2 +-
> NEWS | 3 ++
> README.rst | 2 +-
> 12 files changed, 50 insertions(+), 47 deletions(-)
Acked-by: Aaron Conole
> diff --git a/Documentation/in
Daniel Ding writes:
> 2024年3月30日 上午2:43，Aaron Conole 写道：
>
> Daniel Ding writes:
>
> When I try filter geneve protocol with a vlan, the warning message
> occurs that tell me the kernel cann't support this combination.
>
> ^ can
rings.
>
> Signed-off-by: Adrian Moreno
> ---
Thanks, Adrian.
Reviewed-by: Aaron Conole
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Chris Riches writes:
> On 15/04/2024 14:39, Jon Kohler wrote:
>>> On Apr 11, 2024, at 9:43 AM, Chris Riches wrote:
>>>
>>> On 11/04/2024 14:24, Ilya Maximets wrote:
On 4/11/24 10:59, Chris Riches wrote:
> From what we know so far, the DB was full of stale connection-tracking
> info
o prevent this, it should be changed to hlist_for_each_entry_safe.
>
> Fixes: 11efd5cb04a1 ("openvswitch: Support conntrack zone limit")
> Signed-off-by: Hyunwoo Kim
> ---
Reviewed-by: Aaron Conole
___
dev mailing list
d...@open
Jun Gu writes:
> dev_get_by_name will provide a reference on the netdev. So ensure that
> the reference of netdev is released after completed.
>
> Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name")
> Signed-off-by: Jun Gu
> ---
Thanks
Simon Horman writes:
> Hi Aaron, Jakub, all,
>
> I have recently been exercising the Open vSwitch kernel selftests,
> using vng, something like this:
>
> TESTDIR="tools/testing/selftests/net/openvswitch"
>
> vng -v --run . --user root --cpus 2 \
> --overlay-rwdir "$P
Benjamin Poirier writes:
> On 2024-04-24 18:37 +0100, Simon Horman wrote:
>> On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote:
>> > Hi Aaron, Jakub, all,
>> >
>> > I have recently been exercising the Open vSwitch kernel selftests,
>> > using vng, something like this:
>> >
>> >TE
Jakub Kicinski writes:
> On Wed, 24 Apr 2024 17:44:05 +0100 Simon Horman wrote:
>> I have recently been exercising the Open vSwitch kernel selftests,
>> using vng,
>
> Speaking of ovs tests, we currently don't run them in CI (and suffer
> related skips in pmtu.sh) because Amazon Linux doesn't hav
Simon Horman writes:
> On Wed, Apr 24, 2024 at 02:14:09PM -0400, Aaron Conole wrote:
>> Simon Horman writes:
>>
>> > Hi Aaron, Jakub, all,
>> >
>> > I have recently been exercising the Open vSwitch kernel selftests,
>> > using vng, somet
Jakub Kicinski writes:
> On Thu, 25 Apr 2024 19:57:19 +0100 Simon Horman wrote:
>> openvswitch.sh does not appear to have any dependencies on Open vSwitch
>> user-space. My understanding is that, rather, it makes use of
>> tools/testing/selftests/net/openvswitch/ovs-dpctl.py to talk to the Kernel
Adrian Moreno writes:
> On 5/3/24 11:43 AM, Eelco Chaudron wrote:
>> On 24 Apr 2024, at 15:50, Adrian Moreno wrote:
>>
>>> Add support for psample sampling via two new attributes to the
>>> OVS_ACTION_ATTR_SAMPLE action.
>>>
>>> OVS_SAMPLE_ATTR_PSAMPLE_GROUP used to pass an integer psample group
f8907c37 ("openvswitch: Add original direction conntrack
> tuple to sw_flow_key.")
> Reported-by: Antonin Bas
> Closes: https://github.com/openvswitch/ovs-issues/issues/327
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Aaron Conole
> Note: I'm working on a self
f to bridge in delete reasons.
> - Added comment pointing back to delete reasons in .c.
> v2: - Converted the list of strings to dictionary.
> - Added comment to code to keep code and script in sync.
> - Unified flow_delete reason comments and script output.
> ---
Acked-by:
ch: Add vxlan tunneling support.")
Signed-off-by: Aaron Conole
---
v1->v2: Include a comment as requested by Eelco, and add some details about
bridge port packets.
net/openvswitch/actions.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/net/openvswitch/actions.c b/net/
Eelco Chaudron writes:
> On 16 May 2024, at 14:46, Ilya Maximets wrote:
>
>> On 5/14/24 15:15, Eelco Chaudron wrote:
>>> The flow_reval_monitor.py script incorrectly reported the reasons for
>>> FDR_PURGE and FDR_TOO_EXPENSIVE, as their descriptions were swapped.
>>> This patch rectifies the orde
Ilya Maximets writes:
> On 5/16/24 19:03, Adrian Moreno wrote:
>>
>>
>> On 4/24/24 9:53 PM, Adrian Moreno wrote:
>>> This is the userspace counterpart of the work being done in the kernel
>>> [1]. Sending it as RFC to get some early feedback on the overall
>>> solution.
>>>
>>> ** Problem descr
Adrian Moreno writes:
> In the action formatting function ("dpstr"), the iteration is made over
> the nla_map, so if there are more than one attribute from the same type
> we only print the first one.
>
> Fix this by iterating over the actual attributes.
>
> Signed-off-by: Adrian Moreno
> ---
>
.setvalue(cell[1])
> File "[...]/pyroute2/netlink/__init__.py", line 1265, in setvalue
> nlv.setvalue(nla_tuple[1])
> ~^^^
> IndexError: list index out of range
>
> Signed-off-by: Adrian Moreno
> ---
Acked-by: Aaron Conole
I don't know
Daniel Ding writes:
> When I try filter geneve protocol with a vlan, the warning message
> occurs that tell me the kernel can't support this combination.
>
> $ ovs-tcpdump -i eth2 -nne vlan 10 and geneve
> Warning: Kernel filter failed: Invalid argument
>
> The fix is to make a convenience argume
Mike Pattrick writes:
> When conntrack is reassembling packet fragments, the same reassembly
> context can be shared across multiple threads handling different packets
> simultaneously. Once a full packet is assembled, it is added to a packet
> batch for processing, in the case where there are mu
Ilya Maximets writes:
> On 6/5/24 16:54, Aaron Conole wrote:
>> Mike Pattrick writes:
>>
>>> When conntrack is reassembling packet fragments, the same reassembly
>>> context can be shared across multiple threads handling different packets
>>> simultane
Mike Pattrick writes:
> When conntrack is reassembling packet fragments, the same reassembly
> context can be shared across multiple threads handling different packets
> simultaneously. Once a full packet is assembled, it is added to a packet
> batch for processing, this is most likely the batch
Mike Pattrick writes:
> When conntrack is reassembling packet fragments, the same reassembly
> context can be shared across multiple threads handling different packets
> simultaneously. Once a full packet is assembled, it is added to a packet
> batch for processing, in the case where there are mu
Adrian Moreno writes:
> Current regexp used to check whitespaces around operators does not
> consider that there can be more than one "*" together to express pointer
> to pointer.
>
> As a result, false positive warnings are raised when the
> patch contains a simple list of pointers, e.g: "char *
Eelco Chaudron writes:
> On 7 Jun 2024, at 15:46, Mike Pattrick wrote:
>
>> On Fri, Jun 7, 2024 at 2:35 AM Eelco Chaudron wrote:
>>>
>>>
>>>
>>> On 6 Jun 2024, at 3:07, Mike Pattrick wrote:
>>>
This patch extends the extra_keywords list from 324 to 747 keywords and
moves this list to a
Aaron Conole writes:
> Adrian Moreno writes:
>
>> Current regexp used to check whitespaces around operators does not
>> consider that there can be more than one "*" together to express pointer
>> to pointer.
>>
>> As a result, false positive wa
Adrian Moreno writes:
> Add support for a new action: emit_sample.
>
> This action accepts a u32 group id and a variable-length cookie and uses
> the psample multicast group to make the packet available for
> observability.
>
> The maximum length of the user-defined cookie is set to 16, same as
>
Adrián Moreno writes:
> On Mon, Jun 10, 2024 at 11:46:14AM GMT, Aaron Conole wrote:
>> Adrian Moreno writes:
>>
>> > Add support for a new action: emit_sample.
>> >
>> > This action accepts a u32 group id and a variable-length cookie and uses
>>
Ilya Maximets writes:
> On 6/5/24 16:54, Aaron Conole wrote:
>> Mike Pattrick writes:
>>
>>> When conntrack is reassembling packet fragments, the same reassembly
>>> context can be shared across multiple threads handling different packets
>>> simultane
Adrián Moreno writes:
> On Mon, Jun 03, 2024 at 03:00:03PM GMT, Aaron Conole wrote:
>> Adrian Moreno writes:
>>
>> > In the action formatting function ("dpstr"), the iteration is made over
>> > the nla_map, so if there are more than one attribute from
ackets via these
tunnels, and will be used in an upcoming commit for testing the
path MTU.
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 81 +--
1 file changed, 75 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/net/openv
These will be used in upcoming commits to set specific attributes for
interacting with tunnels. Since set() will use the key parsing routine, we
also make sure to prepend it with an open paren, for the action parsing to
properly understand it.
Signed-off-by: Aaron Conole
---
.../selftests/net
The pmtu testing will require that the OVS module is installed,
so do that.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/config | 5 +
1 file changed, 5 insertions(+)
diff --git a/tools/testing/selftests/net/config
b/tools/testing/selftests/net/config
index 04de7a6ba6f3
: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 43 ---
1 file changed, 28 insertions(+), 15 deletions(-)
diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
index 5545e5cab1d6..2577a06c58cf 100644
This will be used when setting details about the tunnel to use as
transport. There is a difference between the ODP format between tunnel():
the 'key' flag is not actually a flag field, so we don't support it in the
same way that the vswitchd userspace supports displaying it.
Signe
the ovs-dpctl.py utility rather than the
typical OVS userspace utilities.
NOTE: This could also be applied as-is. I'm trying to get the vng test
working in my environment, so I submitted as RFC because I didn't
get to test with the config change in 7/7.
Aaron Conole (6):
an be added to the internal ovs test infrastructure, but that is work for
the future. For now, enable the most common cases - wide mega flows with
no other prerequisites.
Signed-off-by: Aaron Conole
---
tools/testing/selftests/net/pmtu.sh | 87 ++---
1 file changed, 67 inser
sting
code will be unable to print all of the sets - it will only print the
first.
Refactor this code to be easier to read and support multiple actions of the
same type in an action list.
Signed-off-by: Aaron Conole
---
.../selftests/net/openvswitch/ovs-dpctl.py| 45 ++-
1
901 - 1000 of 1897 matches
Mail list logo
